Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix test-debug-signal-cluster.js flakyness #8568

Closed
wants to merge 3 commits into from

Conversation

misterdjules
Copy link

Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

Tests.

Description of change

Do not assume any order and buffering/atomicity of output from child
processes' debugger agents.

Fixes #3796.

Do not assume any order and buffering/atomicity of output from child
processes' debugger agents.

Fixes nodejs#3796.
@misterdjules
Copy link
Author

@mscdex mscdex added cluster Issues and PRs related to the cluster subsystem. debugger labels Sep 16, 2016

assert.deepStrictEqual(outputLines, expectedLines);
assert.equal(expectedContent, '');
Copy link
Member

@Trott Trott Sep 16, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: assert.strictEqual() (not necessary, just a preference, hence the Nit, ignore if you have strong contrary feelings)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI and stress tests come up clean

// output may be interleaved arbitrarily. Moreover, child processes' output
// may be written using an arbitrary number of system calls, and no assumption
// on buffering or atomicity of output should be made. Thus, we process the
// output of all chid processes' debugger agents character by character, and
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: spotted a comment typo

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

Copy link
Member

@imyller imyller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending CI and stress test

@misterdjules
Copy link
Author

Rerunning tests on FreeBSD since tests failed to start on that platform during the previous CI tests run.

@misterdjules
Copy link
Author

Updated PR according to code reviews with one separate commit: I'll squash all commits in this PR into one when/if it lands.

Tests on FreeBSD all passed, still waiting for stress tests to complete.

Copy link
Member

@imyller imyller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with changes and green CI

@misterdjules
Copy link
Author

Pushed another commit that actually removes the test from the list of flaky tests. My apologies for omitting that from the first commit. We shouldn't need to rerun CI tests though, as they all turned green and we're running specific stress tests on the two platforms for which we're changing the flaky tests list.

@imyller
Copy link
Member

imyller commented Sep 16, 2016

Agreed. CI clean (with usual unrelated failures) and stress test looks very promising

@misterdjules
Copy link
Author

Stress tests all passed, will land asap.

misterdjules pushed a commit that referenced this pull request Sep 16, 2016
Do not assume any order and buffering/atomicity of output from child
processes' debugger agents.

Fixes: #3796
PR-URL: #8568
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
@misterdjules
Copy link
Author

Thank you @Trott and @imyller, landed in 7926886.

@Fishrock123
Copy link
Contributor

Does not land cleanly on v6, attempting to patch maked the tests fail.

@gibfahn gibfahn mentioned this pull request Jun 15, 2017
3 tasks
@misterdjules misterdjules deleted the fix-issue-3797 branch July 24, 2017 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cluster Issues and PRs related to the cluster subsystem. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants