Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code style: linting whitespace at the end of the file. #8918

Closed
shmuga opened this issue Oct 3, 2016 · 1 comment
Closed

Code style: linting whitespace at the end of the file. #8918

shmuga opened this issue Oct 3, 2016 · 1 comment
Assignees
@Trott
Labels
tools Issues and PRs related to the tools directory.

Comments

@shmuga
Copy link
Contributor

shmuga commented Oct 3, 2016

  • Version: v6.3.0
  • Platform: 16.0.0 Darwin Kernel Version 16.0.0: Mon Aug 29 17:56:20 PDT 2016; root:xnu-3789.1.32~3/RELEASE_X86_64 x86_64
  • Subsystem: build

Rules are not configured to track for whitespace lines at the end of the file.
Probably it's better to add this rule for checking? I have faced this problem during the review of my PR. And it's definitely not cool to spend time tracking things that can be tracked with tools 🔨
@mscdex mscdex added the tools Issues and PRs related to the tools directory. label Oct 3, 2016
@Trott Trott self-assigned this Oct 4, 2016
Trott added a commit to Trott/io.js that referenced this issue Oct 4, 2016
@Trott
test: remove blank lines at end of files
faced77 
In preparation for a lint rule that disallows empty lines at the end of
a file, remove such lines from a number of test files.

Refs: nodejs#8918
Trott added a commit to Trott/io.js that referenced this issue Oct 4, 2016
@Trott
tools: disallow extra blank lines at end of files
77fefaf 
Fixes: nodejs#8918
@Trott Trott mentioned this issue Oct 4, 2016
Closed
2 tasks
@Trott
Copy link
Member

Trott commented Oct 4, 2016

PR for this: #8920

Trott added a commit to Trott/io.js that referenced this issue Oct 4, 2016
@Trott
test: remove blank lines at end of files
ef19156 
In preparation for a lint rule that disallows empty lines at the end of
a file, remove such lines from a number of test files.

Refs: nodejs#8918
Trott added a commit to Trott/io.js that referenced this issue Oct 4, 2016
@Trott
tools: disallow extra blank lines at EOF/BOF
c096c13 
Enabling linting to disallow extra blank lines at the start or end of
JavaScript files in our code base.

Fixes: nodejs#8918
Trott added a commit to Trott/io.js that referenced this issue Oct 6, 2016
@Trott
test: remove blank lines at end of files
5b2a805 
In preparation for a lint rule that disallows empty lines at the end of
a file, remove such lines from a number of test files.

Refs: nodejs#8918
PR-URL: nodejs#8920
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@Trott Trott closed this as completed in 5e6ae83 Oct 6, 2016
jasnell pushed a commit that referenced this issue Oct 6, 2016
@Trott @jasnell
test: remove blank lines at end of files
533b538 
In preparation for a lint rule that disallows empty lines at the end of
a file, remove such lines from a number of test files.

Refs: #8918
PR-URL: #8920
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
jasnell pushed a commit that referenced this issue Oct 6, 2016
@Trott @jasnell
tools: disallow extra blank lines at EOF/BOF
9964bf0 
Enabling linting to disallow extra blank lines at the start or end of
JavaScript files in our code base.

Fixes: #8918
PR-URL: #8920
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Fishrock123 pushed a commit that referenced this issue Oct 11, 2016
@Trott @Fishrock123
test: remove blank lines at end of files
636026a 
In preparation for a lint rule that disallows empty lines at the end of
a file, remove such lines from a number of test files.

Refs: #8918
PR-URL: #8920
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Fishrock123 pushed a commit that referenced this issue Oct 11, 2016
@Trott @Fishrock123
tools: disallow extra blank lines at EOF/BOF
58c5510 
Enabling linting to disallow extra blank lines at the start or end of
JavaScript files in our code base.

Fixes: #8918
PR-URL: #8920
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Trott Trott

Labels
tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tools: disallow extra blank lines at end of files Trott/io.js
3 participants
@mscdex @Trott @shmuga