-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Node REPL preprocessing input string for custom eval functions #9743
Labels
repl
Issues and PRs related to the REPL subsystem.
Comments
Working on it! |
3 tasks
princejwesley
added a commit
to princejwesley/node
that referenced
this issue
Dec 3, 2016
Code preprocessing is applicable only for default eval function. Therefore, Moved `preprocess` function invocation inside `defaultEval` function. Fixes: nodejs#9743 PR-URL: nodejs#9752 Reviewed-By: Anna Henningsen <anna@addaleax.net>
Landed in 9366b8 |
jmdarling
pushed a commit
to jmdarling/node
that referenced
this issue
Dec 8, 2016
Code preprocessing is applicable only for default eval function. Therefore, Moved `preprocess` function invocation inside `defaultEval` function. Fixes: nodejs#9743 PR-URL: nodejs#9752 Reviewed-By: Anna Henningsen <anna@addaleax.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Run the following:
When inside the REPL write
function f() {}
. The REPL will logvar f = function f() {}
.This sort of preprocessing should only happen for the default
eval
function.The line where the preprocessing occurs: repl.js#L503
This should probably be moved to inside the
defaultEval
function.The text was updated successfully, but these errors were encountered: