test: change var to const/let - change assert.equal to assert.strictE… #10018
Conversation
imyller
added
the
code-and-learn
|
Please see the commit message guidelines here. |
|
Thanks for opening a pull request. The |
|
Whoops! Ignore the previous comment. It looks like the lint failure in CI is an infrastructure glitch and not a lint problem. Sorry about that. |
|
|
||
| function testCipher1(key, iv) { | ||
| // Test encyrption and decryption with explicit key and iv | ||
| var plaintext = | ||
| let plaintext = |
There was a problem hiding this comment.
It seems like this could be const.
| '32|RmVZZkFUVmpRRkp0TmJaUm56ZU9qcnJkaXNNWVNpTTU*|iXmckfRWZBGWWELw' + | ||
| 'eCBsThSsfUHLeRe0KCsK8ooHgxie0zOINpXxfZi/oNG7uq9JWFVCk70gfzQH8ZUJ' + | ||
| 'jAfaFg**'; | ||
| var cipher = crypto.createCipheriv('des-ede3-cbc', key, iv); | ||
| var ciph = cipher.update(plaintext, 'utf8', 'hex'); | ||
| let cipher = crypto.createCipheriv('des-ede3-cbc', key, iv); |
There was a problem hiding this comment.
Also could be const, it would seem.
|
Actually, the lint failures were real after all. The |
Trott
force-pushed
the
issue-test-crypto-cipheriv-decipheriv_aileen
branch
from
6be766a
to
8f46bcc
Compare
|
(Those |
Make change in test file from var to const/let.
Trott
force-pushed
the
issue-test-crypto-cipheriv-decipheriv_aileen
branch
from
8f46bcc
to
0b8800d
Compare
|
Pushed changes. CI: https://ci.nodejs.org/job/node-test-pull-request/5169/ |
|
CI is good except for one unrelated AIX build failure. |
Make change in test file from var to const/let. PR-URL: nodejs#10018 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
|
Landed in 07ef682. Thanks for the contribution! 🎉 |
Make change in test file from var to const/let. PR-URL: #10018 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Make change in test file from var to const/let. PR-URL: nodejs#10018 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Make change in test file from var to const/let. PR-URL: nodejs#10018 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Make change in test file from var to const/let. PR-URL: #10018 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Make change in test file from var to const/let. PR-URL: #10018 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Make change in test file from var to const/let. PR-URL: #10018 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test
Description of change
…qual
Make change in test file per issue received in NINA 2016 involving the change from var to const/let and the change of assert.equal to assert.strictEqual