-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add test for url module domainToAscii and domainToUnicode #10031
Conversation
/cc @jasnell |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there. Just needs one small fix
['भारत.org', 'xn--h2brj9c.org'] | ||
]; | ||
|
||
domainWithASCII.forEach(pair => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please wrap the pair
in parens to match the common style
@jasnell updated, how to i kick off ci again ? |
Still getting some linting issues...
|
okay cool, ill make sure and run lint from now on thanks, will update |
CI is ✅ |
PR-URL: #10031 Reviewed-By: James M Snell <jasnell@gmail.com>
Landed in f8e07d0. Thank you for the PR and for participating in the code-and-learn! |
PR-URL: #10031 Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: nodejs#10031 Reviewed-By: James M Snell <jasnell@gmail.com>
Checklist
Affected core subsystem(s)
Tests
Description of change
Added tests for url.URL.domainToASCII and url.URL.domainToUnicode with see data that transforms one way, and checks, then transform backwards and checks for strictEqual