Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: refactor test-repl-mode.js #10061

Closed
wants to merge 1 commit into from
Closed

test: refactor test-repl-mode.js #10061

wants to merge 1 commit into from

Conversation

cesarhq
Copy link
Contributor

@cesarhq cesarhq commented Dec 1, 2016

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
Affected core subsystem(s)
  • test
Description of change
    * var -> const/let
    * assert.equal() -> assert.strictEqual()

@cesarhq
test: refactor test-repl-mode.js
acd4779 
        * var -> const/let
        * assert.equal() -> assert.strictEqual()
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 1, 2016
@evanlucas
Copy link
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/5052/

evanlucas
evanlucas approved these changes Dec 1, 2016
View reviewed changes
Copy link
Contributor

@evanlucas evanlucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@julianduque julianduque added code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. repl Issues and PRs related to the REPL subsystem. labels Dec 1, 2016
Trott pushed a commit to Trott/io.js that referenced this pull request Dec 5, 2016
@cesarhq @Trott
test: refactor test-repl-mode.js
4f3c761 
* var -> const/let
* assert.equal() -> assert.strictEqual()

PR-URL: nodejs#10061
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@Trott
Copy link
Member

Trott commented Dec 5, 2016

Landed in 4f3c761.
Thanks for the contribution! 🎉

@Trott Trott closed this Dec 5, 2016
Fishrock123 pushed a commit that referenced this pull request Dec 5, 2016
@cesarhq @Fishrock123
test: refactor test-repl-mode.js
9fddf29 
* var -> const/let
* assert.equal() -> assert.strictEqual()

PR-URL: #10061
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@Fishrock123 Fishrock123 mentioned this pull request Dec 5, 2016
Merged
2 tasks
addaleax pushed a commit to addaleax/node that referenced this pull request Dec 8, 2016
@cesarhq @addaleax
test: refactor test-repl-mode.js
f78b817 
* var -> const/let
* assert.equal() -> assert.strictEqual()

PR-URL: nodejs#10061
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
jmdarling pushed a commit to jmdarling/node that referenced this pull request Dec 8, 2016
@cesarhq
test: refactor test-repl-mode.js
4a149e9 
* var -> const/let
* assert.equal() -> assert.strictEqual()

PR-URL: nodejs#10061
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
@cesarhq @MylesBorins
test: refactor test-repl-mode.js
61255eb 
* var -> const/let
* assert.equal() -> assert.strictEqual()

PR-URL: #10061
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@MylesBorins MylesBorins mentioned this pull request Dec 21, 2016
Merged
targos pushed a commit that referenced this pull request Dec 28, 2016
@cesarhq @targos
test: refactor test-repl-mode.js
82e53d1 
* var -> const/let
* assert.equal() -> assert.strictEqual()

PR-URL: #10061
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
targos pushed a commit that referenced this pull request Jan 23, 2017
@cesarhq @targos
test: refactor test-repl-mode.js
beffa82 
* var -> const/let
* assert.equal() -> assert.strictEqual()

PR-URL: #10061
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 24, 2017
@cesarhq @MylesBorins
test: refactor test-repl-mode.js
06c8ddd 
* var -> const/let
* assert.equal() -> assert.strictEqual()

PR-URL: #10061
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@MylesBorins MylesBorins mentioned this pull request Jan 24, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Feb 1, 2017
@cesarhq @MylesBorins
test: refactor test-repl-mode.js
ce91bb2 
* var -> const/let
* assert.equal() -> assert.strictEqual()

PR-URL: #10061
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@Fishrock123 Fishrock123 Fishrock123 approved these changes

@evanlucas evanlucas evanlucas approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. repl Issues and PRs related to the REPL subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@cesarhq @evanlucas @Trott @Fishrock123 @cjihrig @MylesBorins @julianduque @addaleax @targos @nodejs-github-bot