Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stream_base: .writev() has limited support #1008

Closed
wants to merge 1 commit into from

Conversation

indutny
Copy link
Member

@indutny indutny commented Feb 28, 2015

Only TCP and JSStream do support .writev() on all platforms at the
moment. Ensure that it won't be enabled everywhere.

Fix: #995

cc @rvagg @piscisaureus should fix that writev ENOTSUP thing on windows.

Only TCP and JSStream do support `.writev()` on all platforms at the
moment. Ensure that it won't be enabled everywhere.

Fix: nodejs#995
@indutny indutny mentioned this pull request Feb 28, 2015
@rvagg
Copy link
Member

rvagg commented Feb 28, 2015

@piscisaureus
Copy link
Contributor

lgtm - but I didn't test (only have my phone here)

@indutny
Copy link
Member Author

indutny commented Feb 28, 2015

Thanks

@rvagg
Copy link
Member

rvagg commented Feb 28, 2015

according to CI, this fixes

  • test-child-process-stdio-big-write-end
  • test-pipe-head

@indutny
Copy link
Member Author

indutny commented Feb 28, 2015

Yay!

@rvagg
Copy link
Member

rvagg commented Feb 28, 2015

lgtm, can you merge @indutny or shall I?

@indutny
Copy link
Member Author

indutny commented Feb 28, 2015

@rvagg better you

indutny added a commit that referenced this pull request Feb 28, 2015
Only TCP and JSStream do support `.writev()` on all platforms at the
moment. Ensure that it won't be enabled everywhere.

Fix: #995
PR-URL: #1008
Reviewed-by: Bert Belder <bertbelder@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
@rvagg
Copy link
Member

rvagg commented Feb 28, 2015

landed @ 2b47fd2

@rvagg rvagg closed this Feb 28, 2015
rvagg added a commit that referenced this pull request Mar 3, 2015
Notable changes:

* stream: Fixed problems for platforms without `writev()` support,
  particularly Windows. Changes introduced in 1.4.1, via
  #926, broke some
  functionality for these platforms, this has now been addressed.
  #1008 (Fedor Indutny)
* arm: We have the very beginnings of ARMv8 / ARM64 / AARCH64
  support. An upgrade to OpenSSL 1.0.2 is one requirement for full
  support. #1028
  (Ben Noordhuis)
* Add new collaborator: Julian Duque @julianduque
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants