test: updated test-stream-pipe-unpipe-stream #10100
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjihrig
requested changes
Dec 3, 2016
| @@ -25,6 +25,9 @@ source.unpipe(dest2); | |||
| assert.strictEqual(source._readableState.pipes, dest1); | |||
| assert.notStrictEqual(source._readableState.pipes, dest2); | |||
|
|
|||
| dest2.on('unpipe', assert.fail); | |||
There was a problem hiding this comment.
Can you use common.fail instead of assert.fail.
There was a problem hiding this comment.
Do you think it needs to include a message?
There was a problem hiding this comment.
I don't, but others probably do. In that case, you'd have to do something like:
() => { common.fail('your message here'); }There was a problem hiding this comment.
Updated PR, not using message as it looks obvious in the code and most of the common.fail aren't using message.
test readableStream.unpipe(dest) is no operation when dest is not a destination for readable stream
rajapanidepu
force-pushed
the
rpanidepu/unpipe_test
branch
from
be91f7f
to
23c1aa4
Compare
cjihrig
approved these changes
Dec 3, 2016
|
Merging now. |
|
Merged as acb44d0 |
mcollina
pushed a commit
that referenced
this pull request
Dec 5, 2016
test readableStream.unpipe(dest) is no operation when dest is not a destination for readable stream. PR-URL: #10100 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Fishrock123
pushed a commit
that referenced
this pull request
Dec 5, 2016
test readableStream.unpipe(dest) is no operation when dest is not a destination for readable stream. PR-URL: #10100 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
addaleax
pushed a commit
to addaleax/node
that referenced
this pull request
Dec 8, 2016
test readableStream.unpipe(dest) is no operation when dest is not a destination for readable stream. PR-URL: nodejs#10100 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
jmdarling
pushed a commit
to jmdarling/node
that referenced
this pull request
Dec 8, 2016
test readableStream.unpipe(dest) is no operation when dest is not a destination for readable stream. PR-URL: nodejs#10100 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 20, 2016
test readableStream.unpipe(dest) is no operation when dest is not a destination for readable stream. PR-URL: #10100 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2016
test readableStream.unpipe(dest) is no operation when dest is not a destination for readable stream. PR-URL: #10100 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2016
test readableStream.unpipe(dest) is no operation when dest is not a destination for readable stream. PR-URL: #10100 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test
Description of change
test readableStream.unpipe(dest) is no operation when dest is
not a destination for readable stream