Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: refactor test-fs-append-file #10110

Closed
wants to merge 1 commit into from

Conversation

radelmann
Copy link
Contributor

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Description of change
  • Replaced var with either const or let.
  • Replaced assert.equal() with assert.strictEqual().
  • Replaced all error checks with assert.ifError(e).

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 4, 2016
@mscdex mscdex added the fs Issues and PRs related to the fs subsystem / file system. label Dec 4, 2016
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replaced var with either const or let. Replaced
assert.equal() with assert.strictEqual(). Replaced all
error checks with assert.ifError(e).
@cjihrig
Copy link
Contributor

cjihrig commented Dec 5, 2016

Landed in f7fbe42. Thanks!

@cjihrig cjihrig closed this Dec 5, 2016
cjihrig pushed a commit that referenced this pull request Dec 5, 2016
- Replaced var with either const or let.
- Replaced assert.equal() with assert.strictEqual().
- Replaced all error checks with assert.ifError(e).

PR-URL: #10110
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
addaleax pushed a commit that referenced this pull request Dec 5, 2016
- Replaced var with either const or let.
- Replaced assert.equal() with assert.strictEqual().
- Replaced all error checks with assert.ifError(e).

PR-URL: #10110
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
@Fishrock123 Fishrock123 mentioned this pull request Dec 5, 2016
2 tasks
addaleax pushed a commit to addaleax/node that referenced this pull request Dec 8, 2016
- Replaced var with either const or let.
- Replaced assert.equal() with assert.strictEqual().
- Replaced all error checks with assert.ifError(e).

PR-URL: nodejs#10110
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
jmdarling pushed a commit to jmdarling/node that referenced this pull request Dec 8, 2016
- Replaced var with either const or let.
- Replaced assert.equal() with assert.strictEqual().
- Replaced all error checks with assert.ifError(e).

PR-URL: nodejs#10110
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
- Replaced var with either const or let.
- Replaced assert.equal() with assert.strictEqual().
- Replaced all error checks with assert.ifError(e).

PR-URL: #10110
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Dec 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fs Issues and PRs related to the fs subsystem / file system. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants