test: increase test coverage of BufferList #10171
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joyeecheung
force-pushed
the
test-buffer-list
branch
3 times, most recently
from
887e1ea
to
4842402
Compare
Fishrock123
reviewed
Dec 7, 2016
There was a problem hiding this comment.
Seems ok otherwise, CI: https://ci.nodejs.org/job/node-test-pull-request/5293/
| // Flags: --expose_internals | ||
| 'use strict'; | ||
| require('../common'); | ||
| var assert = require('assert'); |
There was a problem hiding this comment.
Mind to use const/let? :D
There was a problem hiding this comment.
Thanks for pointing this out. Addressed.
italoacasas
reviewed
Dec 7, 2016
| assert.deepStrictEqual(emptyList.concat(0), Buffer.alloc(0)); | ||
|
|
||
| // Test buffer list with one element. | ||
| var list = new BufferList(); |
There was a problem hiding this comment.
Thanks for pointing this out. Addressed.
italoacasas
reviewed
Dec 7, 2016
|
|
||
| assert.strictEqual(list.join(','), 'foo'); | ||
|
|
||
| var shifted = list.shift(); |
|
CI: https://ci.nodejs.org/job/node-test-pull-request/5296/ EDIT: Whoops, CI was already run. Sorry for the duplicate. It was ✅ green already... |
cjihrig
approved these changes
Dec 7, 2016
Add tests for edges cases of BufferList - test operations when the length is 0 - test operations when the list only has one element
joyeecheung
force-pushed
the
test-buffer-list
branch
from
4842402
to
a136e2d
Compare
|
Thank you for the review, I've updated the |
addaleax
approved these changes
Dec 8, 2016
|
Landed f0da38a Thanks for the contribution. |
|
@italoacasas I don’t think this is a problem in this case but try to keep the 48/72 hour rule for landing PRs in mind :) |
Fishrock123
pushed a commit
that referenced
this pull request
Dec 13, 2016
Add tests for edges cases of BufferList: - test operations when the length is 0 - test operations when the list only has one element PR-URL: #10171 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Jan 16, 2017
Add tests for edges cases of BufferList: - test operations when the length is 0 - test operations when the list only has one element PR-URL: #10171 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 24, 2017
Add tests for edges cases of BufferList: - test operations when the length is 0 - test operations when the list only has one element PR-URL: #10171 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Jan 31, 2017
Add tests for edges cases of BufferList: - test operations when the length is 0 - test operations when the list only has one element PR-URL: #10171 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test
Description of change
Add tests for edges cases of BufferList