-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: Add node-inspect #10187
Closed
Closed
deps: Add node-inspect #10187
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
e85aaf8
deps: Add node-inspect 1.10.1
46ab980
build: Add node-inspect integration test for unix
3ac0a5e
deps: Update node-inspect to 1.10.2
144c7dc
Use node instead of shell script
3b3a1e0
Enable test-node-inspect in vcbuild.bat
3ccb3b7
Add unix install for node-inspect
da2793f
lib: build `node inspect` into `node`
addaleax df54244
build: Undo custom make install integration
ad3dc75
deps: Update to node-inspect 1.10.4
3c1a65c
test: Ensure conflict-free test-npm-package runs
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
root = true | ||
|
||
[*] | ||
indent_style = space | ||
indent_size = 2 | ||
charset = utf-8 | ||
trim_trailing_whitespace = true | ||
insert_final_newline = true | ||
|
||
[*.md] | ||
trim_trailing_whitespace = false |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,147 @@ | ||
root: true | ||
|
||
env: | ||
node: true | ||
es6: true | ||
|
||
parserOptions: | ||
ecmaVersion: 2016 | ||
|
||
rules: | ||
# Possible Errors | ||
# http://eslint.org/docs/rules/#possible-errors | ||
comma-dangle: [2, only-multiline] | ||
no-control-regex: 2 | ||
no-debugger: 2 | ||
no-dupe-args: 2 | ||
no-dupe-keys: 2 | ||
no-duplicate-case: 2 | ||
no-empty-character-class: 2 | ||
no-ex-assign: 2 | ||
no-extra-boolean-cast: 2 | ||
no-extra-parens: [2, functions] | ||
no-extra-semi: 2 | ||
no-func-assign: 2 | ||
no-invalid-regexp: 2 | ||
no-irregular-whitespace: 2 | ||
no-obj-calls: 2 | ||
no-proto: 2 | ||
no-template-curly-in-string: 2 | ||
no-unexpected-multiline: 2 | ||
no-unreachable: 2 | ||
no-unsafe-negation: 2 | ||
use-isnan: 2 | ||
valid-typeof: 2 | ||
|
||
# Best Practices | ||
# http://eslint.org/docs/rules/#best-practices | ||
dot-location: [2, property] | ||
no-fallthrough: 2 | ||
no-global-assign: 2 | ||
no-multi-spaces: 2 | ||
no-octal: 2 | ||
no-redeclare: 2 | ||
no-self-assign: 2 | ||
no-unused-labels: 2 | ||
no-useless-call: 2 | ||
no-useless-escape: 2 | ||
no-void: 2 | ||
no-with: 2 | ||
|
||
# Strict Mode | ||
# http://eslint.org/docs/rules/#strict-mode | ||
strict: [2, global] | ||
|
||
# Variables | ||
# http://eslint.org/docs/rules/#variables | ||
no-delete-var: 2 | ||
no-undef: 2 | ||
no-unused-vars: [2, {args: none}] | ||
|
||
# Node.js and CommonJS | ||
# http://eslint.org/docs/rules/#nodejs-and-commonjs | ||
no-mixed-requires: 2 | ||
no-new-require: 2 | ||
no-path-concat: 2 | ||
no-restricted-modules: [2, sys, _linklist] | ||
no-restricted-properties: [2, { | ||
object: assert, | ||
property: deepEqual, | ||
message: Please use assert.deepStrictEqual(). | ||
}, { | ||
property: __defineGetter__, | ||
message: __defineGetter__ is deprecated. | ||
}, { | ||
property: __defineSetter__, | ||
message: __defineSetter__ is deprecated. | ||
}] | ||
|
||
# Stylistic Issues | ||
# http://eslint.org/docs/rules/#stylistic-issues | ||
brace-style: [2, 1tbs, {allowSingleLine: true}] | ||
comma-spacing: 2 | ||
comma-style: 2 | ||
computed-property-spacing: 2 | ||
eol-last: 2 | ||
func-call-spacing: 2 | ||
func-name-matching: 2 | ||
indent: [2, 2, {SwitchCase: 1, MemberExpression: 1}] | ||
key-spacing: [2, {mode: minimum}] | ||
keyword-spacing: 2 | ||
linebreak-style: [2, unix] | ||
max-len: [2, 80, 2] | ||
new-parens: 2 | ||
no-mixed-spaces-and-tabs: 2 | ||
no-multiple-empty-lines: [2, {max: 2, maxEOF: 0, maxBOF: 0}] | ||
no-tabs: 2 | ||
no-trailing-spaces: 2 | ||
quotes: [2, single, avoid-escape] | ||
semi: 2 | ||
semi-spacing: 2 | ||
space-before-blocks: [2, always] | ||
space-before-function-paren: [2, never] | ||
space-in-parens: [2, never] | ||
space-infix-ops: 2 | ||
space-unary-ops: 2 | ||
|
||
# ECMAScript 6 | ||
# http://eslint.org/docs/rules/#ecmascript-6 | ||
arrow-parens: [2, always] | ||
arrow-spacing: [2, {before: true, after: true}] | ||
constructor-super: 2 | ||
no-class-assign: 2 | ||
no-confusing-arrow: 2 | ||
no-const-assign: 2 | ||
no-dupe-class-members: 2 | ||
no-new-symbol: 2 | ||
no-this-before-super: 2 | ||
prefer-const: [2, {ignoreReadBeforeAssign: true}] | ||
rest-spread-spacing: 2 | ||
template-curly-spacing: 2 | ||
|
||
# Custom rules in tools/eslint-rules | ||
align-function-arguments: 2 | ||
align-multiline-assignment: 2 | ||
assert-fail-single-argument: 2 | ||
new-with-error: [2, Error, RangeError, TypeError, SyntaxError, ReferenceError] | ||
|
||
# Global scoped method and vars | ||
globals: | ||
COUNTER_HTTP_CLIENT_REQUEST: false | ||
COUNTER_HTTP_CLIENT_RESPONSE: false | ||
COUNTER_HTTP_SERVER_REQUEST: false | ||
COUNTER_HTTP_SERVER_RESPONSE: false | ||
COUNTER_NET_SERVER_CONNECTION: false | ||
COUNTER_NET_SERVER_CONNECTION_CLOSE: false | ||
DTRACE_HTTP_CLIENT_REQUEST: false | ||
DTRACE_HTTP_CLIENT_RESPONSE: false | ||
DTRACE_HTTP_SERVER_REQUEST: false | ||
DTRACE_HTTP_SERVER_RESPONSE: false | ||
DTRACE_NET_SERVER_CONNECTION: false | ||
DTRACE_NET_STREAM_END: false | ||
LTTNG_HTTP_CLIENT_REQUEST: false | ||
LTTNG_HTTP_CLIENT_RESPONSE: false | ||
LTTNG_HTTP_SERVER_REQUEST: false | ||
LTTNG_HTTP_SERVER_RESPONSE: false | ||
LTTNG_NET_SERVER_CONNECTION: false | ||
LTTNG_NET_STREAM_END: false |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
node_modules/ | ||
npm-debug.log | ||
/tmp | ||
/.vs |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
registry=https://registry.npmjs.org |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
language: node_js | ||
node_js: | ||
- '6.8' | ||
before_deploy: | ||
- git config --global user.email "jan.krems@gmail.com" | ||
- git config --global user.name "Jan Krems" | ||
deploy: | ||
provider: script | ||
script: ./node_modules/.bin/nlm release | ||
skip_cleanup: true | ||
'on': | ||
branch: master | ||
node: '6.8' |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally, there's be a similar job for Windows in vcbuild.bat.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, didn't have a Windows machine set up to look into
vcbuild.bat
, that's why I only copiedtools/test-npm.sh
in the first push. Should be able to work on the Windows part next week.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Windows part is done.