-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
url: improve parsing speed #102
Conversation
The url.parse() function now checks whether an escapable character is in the URL before trying to escape it. PR-URL: nodejs/node-v0.x-archive#8638 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Based on the ad-hoc benchmark from nodejs/node-v0.x-archive#8638.
Please tag it, @caineio |
@chrisdickinson Maybe you can review b7fc957? That one can go in without having to wait for the OPR (original pull requester; yes, I made that up on the spot.) |
@bnoordhuis done and done. Had one request + a italicized verdant hope for a v8 feature, otherwise b7fc957 looks good. |
Based on the ad-hoc benchmark from nodejs/node-v0.x-archive#8638 plus an additional benchmark for user:pass auth URLs. PR-URL: #102 Reviewed-by: Chris Dickinson <christopher.s.dickinson@gmail.com>
Cheers Chris, incorporated the feedback and landed in 21a679a.
I suppose doing a few url.parse() trial runs, then calling |
Closing, this landed by way of the joyent/v0.12 merge in 94e1475. |
The url.parse() function now checks whether an escapable character is
in the URL before trying to escape it.
PR-URL: nodejs/node-v0.x-archive#8638
@CGavrila Would you be willing to sign the commit with your real name?