Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: refactor test-http-after-connect.js #10229

Closed
wants to merge 1 commit into from
Closed

test: refactor test-http-after-connect.js #10229

wants to merge 1 commit into from

Conversation

larissayvette
Copy link
Contributor

Affected core subsystem(s)

test

Description of change
  • Replace assert.equal() to assert.strictEqual()
  • Replace var with const where applicable
  • Removed firstBodyChunk which is never used
  • remove the process.on('exit', ...) and replace its functionality by using common.mustCall() where applicable

@nodejs-github-bot nodejs-github-bot added test Issues and PRs related to the tests. lts-watch-v4.x labels Dec 11, 2016
@benjamingr
Copy link
Member

LGTM

@Trott
Copy link
Member

Trott commented Dec 12, 2016

CI: https://ci.nodejs.org/job/node-test-pull-request/5361/

@Trott
Copy link
Member

Trott commented Dec 12, 2016

The linter is failing (which you can see quickly running make jslint and also make test although that will take longer) because serverConnected and serverRequests are now unused variables. Can you remove them and push that change? (It's OK if it's a second commit as it can be squashed on landing. But if you want to squash it and force push, that's fine too.)

@mscdex mscdex added the http Issues or PRs related to the http subsystem. label Dec 12, 2016
@larissayvette larissayvette force-pushed the fix-test-http-after-connect branch from 65f19a7 to 43a16e1 Compare December 12, 2016 13:16
@larissayvette
Copy link
Contributor Author

@Trott I removed those variables and squashed the 2 commits

@Trott
Copy link
Member

Trott commented Dec 12, 2016

CI: https://ci.nodejs.org/job/node-test-pull-request/5369/

@italoacasas
Copy link
Contributor

Landed 8329605

Thanks for the contribution.

italoacasas pushed a commit that referenced this pull request Dec 13, 2016
@larissayvette @italoacasas
test: refactor test-http-after-connect.js
8329605 
- Replace assert.equal() to assert.strictEqual()
- Replace var with const where applicable
- Removed firstBodyChunk which is never used
- Remove the process.on('exit', ...) and replace its functionality by
- Using common.mustCall() where applicable

PR-URL: #10229
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@larissayvette larissayvette deleted the fix-test-http-after-connect branch December 13, 2016 15:53
Fishrock123 pushed a commit that referenced this pull request Dec 13, 2016
@larissayvette @Fishrock123
test: refactor test-http-after-connect.js
be87441 
- Replace assert.equal() to assert.strictEqual()
- Replace var with const where applicable
- Removed firstBodyChunk which is never used
- Remove the process.on('exit', ...) and replace its functionality by
- Using common.mustCall() where applicable

PR-URL: #10229
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
AnnaMag pushed a commit to AnnaMag/node that referenced this pull request Dec 13, 2016
@larissayvette @AnnaMag
test: refactor test-http-after-connect.js
db5d910 
- Replace assert.equal() to assert.strictEqual()
- Replace var with const where applicable
- Removed firstBodyChunk which is never used
- Remove the process.on('exit', ...) and replace its functionality by
- Using common.mustCall() where applicable

PR-URL: nodejs#10229
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@italoacasas italoacasas mentioned this pull request Dec 15, 2016
Merged
targos pushed a commit that referenced this pull request Dec 28, 2016
@larissayvette @targos
test: refactor test-http-after-connect.js
08d2f6f 
- Replace assert.equal() to assert.strictEqual()
- Replace var with const where applicable
- Removed firstBodyChunk which is never used
- Remove the process.on('exit', ...) and replace its functionality by
- Using common.mustCall() where applicable

PR-URL: #10229
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 22, 2017
@larissayvette @MylesBorins
test: refactor test-http-after-connect.js
8109d61 
- Replace assert.equal() to assert.strictEqual()
- Replace var with const where applicable
- Removed firstBodyChunk which is never used
- Remove the process.on('exit', ...) and replace its functionality by
- Using common.mustCall() where applicable

PR-URL: #10229
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 22, 2017
@larissayvette @MylesBorins
test: refactor test-http-after-connect.js
ccfbbc0 
- Replace assert.equal() to assert.strictEqual()
- Replace var with const where applicable
- Removed firstBodyChunk which is never used
- Remove the process.on('exit', ...) and replace its functionality by
- Using common.mustCall() where applicable

PR-URL: #10229
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 24, 2017
@larissayvette @MylesBorins
test: refactor test-http-after-connect.js
f0916ca 
- Replace assert.equal() to assert.strictEqual()
- Replace var with const where applicable
- Removed firstBodyChunk which is never used
- Remove the process.on('exit', ...) and replace its functionality by
- Using common.mustCall() where applicable

PR-URL: #10229
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 24, 2017
@larissayvette @MylesBorins
test: refactor test-http-after-connect.js
f2fd122 
- Replace assert.equal() to assert.strictEqual()
- Replace var with const where applicable
- Removed firstBodyChunk which is never used
- Remove the process.on('exit', ...) and replace its functionality by
- Using common.mustCall() where applicable

PR-URL: #10229
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
This was referenced Jan 24, 2017
Merged
Merged
MylesBorins pushed a commit that referenced this pull request Jan 31, 2017
@larissayvette @MylesBorins
test: refactor test-http-after-connect.js
10747f4 
- Replace assert.equal() to assert.strictEqual()
- Replace var with const where applicable
- Removed firstBodyChunk which is never used
- Remove the process.on('exit', ...) and replace its functionality by
- Using common.mustCall() where applicable

PR-URL: #10229
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 1, 2017
@larissayvette @MylesBorins
test: refactor test-http-after-connect.js
9c9d422 
- Replace assert.equal() to assert.strictEqual()
- Replace var with const where applicable
- Removed firstBodyChunk which is never used
- Remove the process.on('exit', ...) and replace its functionality by
- Using common.mustCall() where applicable

PR-URL: #10229
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@italoacasas italoacasas italoacasas approved these changes

@cjihrig cjihrig cjihrig approved these changes

@benjamingr benjamingr benjamingr approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
http Issues or PRs related to the http subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@larissayvette @benjamingr @Trott @italoacasas @cjihrig @mscdex @MylesBorins @targos @nodejs-github-bot