Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: define missing operator delete functions #10356

Closed
wants to merge 2 commits into from

Conversation

bnoordhuis
Copy link
Member

@bnoordhuis bnoordhuis commented Dec 20, 2016

Refs #10173, includes the changes to Isolate and SealHandleScope.

Section 3.2 of the C++ standard states that destructor definitions
implicitly "use" operator delete functions. Therefore, these operator
delete functions must be defined even if they are never called by
user code explicitly.
http://www.open-std.org/JTC1/SC22/WG21/docs/cwg_defects.html#261

gcc allows them to remain as empty definitions. However, not all
compilers allow this.

This pull request creates definitions which if ever called, result
in an abort.

@jBarz I've used your ca.ibm.com email address as the author email.

CI: https://ci.nodejs.org/job/node-test-pull-request/5487/

Section 3.2 of the C++ standard states that destructor definitions
implicitly "use" operator delete functions. Therefore, these operator
delete functions must be defined even if they are never called by
user code explicitly.
http://www.open-std.org/JTC1/SC22/WG21/docs/cwg_defects.html#261

gcc allows them to remain as empty definitions. However, not all
compilers allow this.

This pull request creates definitions which if ever called, result
in an abort.
@nodejs-github-bot nodejs-github-bot added v0.12 v8 engine Issues and PRs related to the V8 dependency. labels Dec 20, 2016
@richardlau
Copy link
Member

Does the V8 patch level need to be bumped?

@gibfahn
Copy link
Member

gibfahn commented Dec 20, 2016

CI 2: https://ci.nodejs.org/job/node-test-commit/6742/
CI 3: https://ci.nodejs.org/job/node-test-commit/6747/

(I think the failures in the first CI were unrelated)

@bnoordhuis
Copy link
Member Author

Does the V8 patch level need to be bumped?

Yes. I'll do that when I land it. (Could have done that right away, come to think of it, not much risk of a conflict at this stage.)

@rvagg
Copy link
Member

rvagg commented Dec 20, 2016

lgtm, can you expedite this one and do the V8 bump please @bnoordhuis? gotta get this release done.

rvagg pushed a commit that referenced this pull request Dec 21, 2016
Section 3.2 of the C++ standard states that destructor definitions
implicitly "use" operator delete functions. Therefore, these operator
delete functions must be defined even if they are never called by
user code explicitly.
http://www.open-std.org/JTC1/SC22/WG21/docs/cwg_defects.html#261

gcc allows them to remain as empty definitions. However, not all
compilers allow this.

This pull request creates definitions which if ever called, result
in an abort.

PR-URL: #10356
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rod Vagg <rod@vagg.org>
@rvagg
Copy link
Member

rvagg commented Dec 21, 2016

landed @ 830584c, thanks all

@rvagg rvagg closed this Dec 21, 2016
@bnoordhuis bnoordhuis deleted the pr10173 branch December 21, 2016 14:22
gibfahn pushed a commit to ibmruntimes/node that referenced this pull request Dec 22, 2016
Section 3.2 of the C++ standard states that destructor definitions
implicitly "use" operator delete functions. Therefore, these operator
delete functions must be defined even if they are never called by
user code explicitly.
http://www.open-std.org/JTC1/SC22/WG21/docs/cwg_defects.html#261

gcc allows them to remain as empty definitions. However, not all
compilers allow this.

This pull request creates definitions which if ever called, result
in an abort.

PR-URL: nodejs/node#10356
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rod Vagg <rod@vagg.org>
gibfahn pushed a commit to ibmruntimes/node that referenced this pull request Dec 22, 2016
Section 3.2 of the C++ standard states that destructor definitions
implicitly "use" operator delete functions. Therefore, these operator
delete functions must be defined even if they are never called by
user code explicitly.
http://www.open-std.org/JTC1/SC22/WG21/docs/cwg_defects.html#261

gcc allows them to remain as empty definitions. However, not all
compilers allow this.

This pull request creates definitions which if ever called, result
in an abort.

PR-URL: nodejs/node#10356
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rod Vagg <rod@vagg.org>
jBarz added a commit to ibmruntimes/node that referenced this pull request Dec 22, 2016
Section 3.2 of the C++ standard states that destructor definitions
implicitly "use" operator delete functions. Therefore, these operator
delete functions must be defined even if they are never called by
user code explicitly.
http://www.open-std.org/JTC1/SC22/WG21/docs/cwg_defects.html#261

gcc allows them to remain as empty definitions. However, not all
compilers allow this.

This pull request creates definitions which if ever called, result
in an abort.

PR-URL: nodejs/node#10356
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rod Vagg <rod@vagg.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants