Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: make global non-enumerable #10405

Closed
wants to merge 1 commit into from
Closed

src: make global non-enumerable #10405

wants to merge 1 commit into from

Commits on Dec 22, 2016

  1. src: make global non-enumerable 

    Per https://github.com/tc39/proposal-global, the global value `global`
should be configurable, writable, and non-enumerable. `node` has always
provided it as configurable, writable, and enumerable.

The plan is to make it non-enumerable, and barring strong evidence that
node can not ship `global` as non-enumerable, this will be how it lands
as stage 4 (in the spec).
    @ljharb
    ljharb committed Dec 22, 2016
    Configuration menu
    Copy the full SHA
    4744e3f View commit details
    Browse the repository at this point in the history