Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

process: improve performance of nextTick (v4.x backport) #10433

Closed
wants to merge 1 commit into from

Conversation

evanlucas
Copy link
Contributor

This replaces TickObject with an object literal. This offers
performance improvements of up to ~20%.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

process

Description of change

Backport of #8932

This replaces TickObject with an object literal. This offers
performance improvements of up to ~20%.

This replaces TickObject with an object literal. This offers
performance improvements of up to ~20%.
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. v4.x labels Dec 23, 2016
@mscdex
Copy link
Contributor

mscdex commented Dec 23, 2016

Did you check that it's still a perf increase with node v4?

@mscdex mscdex added the process Issues and PRs related to the process subsystem. label Dec 23, 2016
@evanlucas
Copy link
Contributor Author

evanlucas commented Dec 23, 2016

@mscdex yes #8932 (comment)

That was a few months ago though, so double checking now

@evanlucas
Copy link
Contributor Author

Actually, next-tick-breadth.js is pretty consistently 8-10% slower on v4.x. I'll go ahead and close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. process Issues and PRs related to the process subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants