Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: refactor test-debugger-remote #10455

Closed

Commits on Dec 28, 2016

  1. test: refactor test-debugger-remote

    1. The test doesn't attach an event listener for `exit` events and
       removes them before killing. The intention is to fail the tests if
       the processes exit normally. This patch attaches the `exit` event
       handlers.
    
    2. Replace `var`s with `let`s and `const`s.
    
    3. Replace `==` based assertion with `strictEqual` assertion.
    
    4. Use `common.PORT` instead of `5959`.
    
    5. The test used to expect only one string "connecting to
       localhost:5959 ... ok", but the debugger actually emits another
       string, "break in test/fixtures/empty.js:2". This patch asserts if
       both of them are received in the same order.
    
    Refer: nodejs#10361
    thefourtheye committed Dec 28, 2016
    Configuration menu
    Copy the full SHA
    a905e57 View commit details
    Browse the repository at this point in the history