lib,src: make constants not inherit from Object #10458

thefourtheye · 2016-12-26T11:19:18Z

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
commit message follows commit guidelines

Affected core subsystem(s)

lib src test

Description of change

Make sure constants object and all the nested objects don't inherit
from Object.prototype but from null.

addaleax · 2016-12-26T11:20:45Z

lib/fs.js

@@ -1004,7 +1004,7 @@ fs.fchmodSync = function(fd, mode) {
  return binding.fchmod(fd, modeNum(mode));
 };

-if (constants.hasOwnProperty('O_SYMLINK')) {
+if ('O_SYMLINK' in constants) {


I think these have a small performance impact, maybe Object.prototype.hasOwnProperty.call is better for all of these?

As constants inherit from null, will the performance implication still be applicable?

Performance of the in operator has recently been optimized in V8 (in 5.2).

@targos It's still quite slow though in master (V8 5.4). I recently swapped usage of in with a simpler undefined check and saw a ~50% improvement.

@thefourtheye I would just do an undefined check (constants.O_SYMLINK !== undefined) instead of in. It should still work fine.

Done! I changed them to !== undefined.

targos · 2016-12-26T11:49:36Z

What do we gain from this change?

thefourtheye · 2016-12-26T11:57:09Z

@targos Lookup should be comparatively faster and problems because of accidental accessing of inherited properties will be avoided, like in #10423

cjihrig · 2016-12-26T19:15:35Z

test/parallel/test-binding-constants.js

+  Object.keys(constants.os).sort(), ['UV_UDP_REUSEADDR', 'errno', 'signals']
+);
+
+// make sure all the constants objects don't inherit from Object.prototype


Can you capitalize "make" please.

cjihrig · 2016-12-26T19:16:06Z

test/parallel/test-binding-constants.js

+);
+
+// make sure all the constants objects don't inherit from Object.prototype
+const INHERITED_PROPERTIES = Object.getOwnPropertyNames(Object.prototype);


Can you name this with camelCase please.

mscdex · 2016-12-27T22:40:00Z

CI: https://ci.nodejs.org/job/node-test-pull-request/5608/

Fishrock123

LGTM for a major (if it works, ci)

mscdex · 2017-01-03T15:24:19Z

LGTM

jasnell · 2017-01-03T16:36:38Z

I'm wondering if a similar semver-major change should not be made to the docs-only deprecated require('constants')

thefourtheye · 2017-01-03T18:16:27Z

@jasnell Do you mean the object returned by require('constants') should also inherit from null?

Make sure `constants` object and all the nested objects don't inherit from `Object.prototype` but from `null`.

jasnell · 2017-01-03T19:16:31Z

@thefourtheye ... yes, that's what I'm thinking. We could choose to leave it untouched but for consistency it may make sense

thefourtheye · 2017-01-04T19:28:09Z

@jasnell I just tried that and it affects graceful-fs, https://github.com/isaacs/node-graceful-fs/blob/v4.1.11/polyfills.js#L31 :'(

jasnell · 2017-01-04T19:28:51Z

Boo. Ok, I'd leave it as is then.

jasnell · 2017-01-10T21:19:52Z

New CI: https://ci.nodejs.org/job/node-test-pull-request/5795/
CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/519/

thefourtheye · 2017-01-15T18:42:13Z

cc @nodejs/ctc as this is a major change.

thefourtheye · 2017-02-13T10:51:10Z

Yet another CI Run to BUMP https://ci.nodejs.org/job/node-test-pull-request/6372/

jasnell · 2017-02-13T15:34:31Z

@thefourtheye ... this should be good to go!

thefourtheye · 2017-02-13T15:42:48Z

@jasnell Thanks :-) I would be comfortable if I get a green CITGM as well, as this is a major change. I'll try to spend sometime this week to fix it.

thefourtheye · 2017-02-23T01:18:40Z

CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/596/
CI Run: https://ci.nodejs.org/job/node-test-pull-request/6558/

jasnell · 2017-03-22T22:05:36Z

CITGM and CI both were good. Landing.

Make sure `constants` object and all the nested objects don't inherit from `Object.prototype` but from `null`. PR-URL: #10458 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net>

jasnell · 2017-03-22T22:08:47Z

Landed in caf9ae7

thefourtheye requested review from mscdex, bnoordhuis and addaleax December 26, 2016 11:19

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to the fs subsystem / file system. process Issues and PRs related to the process subsystem. labels Dec 26, 2016

thefourtheye mentioned this pull request Dec 26, 2016

child_process: improve killSignal validations #10423

Closed

3 tasks

addaleax added lib / src Issues and PRs related to general changes in the lib or src directory. semver-major PRs that contain breaking changes and should be released in the next major version. labels Dec 26, 2016

addaleax reviewed Dec 26, 2016

View reviewed changes

thefourtheye force-pushed the make-constants-inherit-from-null branch from 11a0b88 to 8638f31 Compare December 26, 2016 18:58

jasnell approved these changes Dec 26, 2016

View reviewed changes

cjihrig reviewed Dec 26, 2016

View reviewed changes

thefourtheye force-pushed the make-constants-inherit-from-null branch from 8638f31 to aaf7165 Compare December 26, 2016 19:18

Fishrock123 approved these changes Jan 3, 2017

View reviewed changes

cjihrig approved these changes Jan 3, 2017

View reviewed changes

thefourtheye force-pushed the make-constants-inherit-from-null branch from aaf7165 to 002ce78 Compare January 3, 2017 18:18

lib,src: make constants not inherit from Object

3a75d7c

Make sure `constants` object and all the nested objects don't inherit from `Object.prototype` but from `null`.

thefourtheye force-pushed the make-constants-inherit-from-null branch from 002ce78 to 3a75d7c Compare January 3, 2017 18:19

jasnell closed this Mar 22, 2017

thefourtheye deleted the make-constants-inherit-from-null branch April 2, 2017 07:17

jasnell mentioned this pull request Apr 4, 2017

8.0.0 Release Proposal #12220

Closed

kt3k mentioned this pull request Feb 21, 2021

Do not depend on deprecated 'constants' module isaacs/node-graceful-fs#206

Open

snyk-bot mentioned this pull request Apr 24, 2023

[Snyk] Security upgrade eslint from 4.19.1 to 5.0.0 aliscco/alisco-node#97

Open

aliscco mentioned this pull request Apr 24, 2023

[Snyk] Fix for 19 vulnerabilities aliscco/alisco-node#109

Open

This was referenced Apr 24, 2023

[Snyk] Fix for 8 vulnerabilities aliscco/alisco-node#122

Open

[Snyk] Fix for 17 vulnerabilities aliscco/alisco-node#127

Open

aliscco mentioned this pull request Apr 24, 2023

[Snyk] Fix for 19 vulnerabilities aliscco/alisco-node#128

Open

This was referenced Apr 25, 2023

[Snyk] Fix for 8 vulnerabilities aliscco/alisco-node#177

Open

[Snyk] Fix for 7 vulnerabilities aliscco/alisco-node#182

Open

[Snyk] Fix for 8 vulnerabilities aliscco/alisco-node#183

Open

aliscco mentioned this pull request Apr 26, 2023

[Snyk] Fix for 2 vulnerabilities aliscco/alisco-node#195

Open

snyk-bot mentioned this pull request Apr 26, 2023

[Snyk] Security upgrade eslint from 4.19.1 to 5.0.0 aliscco/alisco-node#249

Open

aliscco mentioned this pull request Apr 28, 2023

[Snyk] Fix for 10 vulnerabilities aliscco/alisco-node#309

Open

snyk-bot mentioned this pull request Apr 28, 2023

[Snyk] Security upgrade eslint from 4.19.1 to 5.0.0 aliscco/alisco-node#336

Open

aliscco mentioned this pull request Apr 29, 2023

[Snyk] Fix for 7 vulnerabilities aliscco/alisco-node#356

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

lib,src: make constants not inherit from Object #10458

lib,src: make constants not inherit from Object #10458

thefourtheye commented Dec 26, 2016

addaleax Dec 26, 2016

thefourtheye Dec 26, 2016

targos Dec 26, 2016

mscdex Dec 26, 2016 •

edited

Loading

thefourtheye Dec 26, 2016

targos commented Dec 26, 2016

thefourtheye commented Dec 26, 2016

cjihrig Dec 26, 2016

thefourtheye Dec 26, 2016

cjihrig Dec 26, 2016

thefourtheye Dec 26, 2016

mscdex commented Dec 27, 2016

Fishrock123 left a comment

mscdex commented Jan 3, 2017

jasnell commented Jan 3, 2017

thefourtheye commented Jan 3, 2017

jasnell commented Jan 3, 2017

thefourtheye commented Jan 4, 2017

jasnell commented Jan 4, 2017

jasnell commented Jan 10, 2017

thefourtheye commented Jan 15, 2017

thefourtheye commented Feb 13, 2017

jasnell commented Feb 13, 2017

thefourtheye commented Feb 13, 2017

thefourtheye commented Feb 23, 2017

jasnell commented Mar 22, 2017

jasnell commented Mar 22, 2017

lib,src: make constants not inherit from Object #10458

lib,src: make constants not inherit from Object #10458

Conversation

thefourtheye commented Dec 26, 2016

Checklist

Affected core subsystem(s)

Description of change

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mscdex Dec 26, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

targos commented Dec 26, 2016

thefourtheye commented Dec 26, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mscdex commented Dec 27, 2016

Fishrock123 left a comment

Choose a reason for hiding this comment

mscdex commented Jan 3, 2017

jasnell commented Jan 3, 2017

thefourtheye commented Jan 3, 2017

jasnell commented Jan 3, 2017

thefourtheye commented Jan 4, 2017

jasnell commented Jan 4, 2017

jasnell commented Jan 10, 2017

thefourtheye commented Jan 15, 2017

thefourtheye commented Feb 13, 2017

jasnell commented Feb 13, 2017

thefourtheye commented Feb 13, 2017

thefourtheye commented Feb 23, 2017

jasnell commented Mar 22, 2017

jasnell commented Mar 22, 2017

mscdex Dec 26, 2016 •

edited

Loading