Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v4.x: backport test: fix test-buffer-slow #10460

Closed
wants to merge 1 commit into from
Closed

v4.x: backport test: fix test-buffer-slow #10460

wants to merge 1 commit into from

Conversation

targos
Copy link
Member

@targos targos commented Dec 26, 2016

Backport of #9809

@targos
test: fix test-buffer-slow
433cbb7 
Fix incorrect use of string instead of RegExp in `throws` assertions.

PR-URL: nodejs#9809
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@targos targos added buffer Issues and PRs related to the buffer subsystem. test Issues and PRs related to the tests. v4.x labels Dec 26, 2016
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. labels Dec 26, 2016
@targos targos changed the base branch from master to v4.x-staging December 26, 2016 12:22
@targos targos removed build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. dont-land-on-v7.x meta Issues and PRs related to the general management of the project. labels Dec 26, 2016
@targos
Copy link
Member Author

targos commented Dec 26, 2016

CI: https://ci.nodejs.org/job/node-test-pull-request/5588/

@targos
Copy link
Member Author

targos commented Dec 27, 2016

Landed in e0c8aaf

@targos targos closed this Dec 27, 2016
@targos targos deleted the backport-9809-v4.x branch December 27, 2016 12:08
@snyk-bot snyk-bot mentioned this pull request Apr 24, 2023
Open
@aliscco aliscco mentioned this pull request Apr 24, 2023
Open
This was referenced Apr 24, 2023
Open
Open
@aliscco aliscco mentioned this pull request Apr 24, 2023
Open
This was referenced Apr 25, 2023
Open
Open
Open
@aliscco aliscco mentioned this pull request Apr 26, 2023
Open
@snyk-bot snyk-bot mentioned this pull request Apr 26, 2023
Open
@aliscco aliscco mentioned this pull request Apr 28, 2023
Open
@snyk-bot snyk-bot mentioned this pull request Apr 28, 2023
Open
@aliscco aliscco mentioned this pull request Apr 29, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
buffer Issues and PRs related to the buffer subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@targos @jasnell @nodejs-github-bot