test: refactor test-stream-pipe-error-handling #10530
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* provide a RegExp for second argument to `assert.throws()` * remove unused function arguments * provide duration of 1 ms for `setTimeout()` calls that do not have a duration
Trott
added
stream
jasnell
approved these changes
Dec 30, 2016
lpinca
approved these changes
Dec 30, 2016
cjihrig
approved these changes
Dec 30, 2016
|
Landed in e5674e1 |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Jan 2, 2017
* provide a RegExp for second argument to `assert.throws()` * remove unused function arguments * provide duration of 1 ms for `setTimeout()` calls that do not have a duration PR-URL: nodejs#10530 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
evanlucas
pushed a commit
that referenced
this pull request
Jan 3, 2017
* provide a RegExp for second argument to `assert.throws()` * remove unused function arguments * provide duration of 1 ms for `setTimeout()` calls that do not have a duration PR-URL: #10530 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
evanlucas
pushed a commit
that referenced
this pull request
Jan 4, 2017
* provide a RegExp for second argument to `assert.throws()` * remove unused function arguments * provide duration of 1 ms for `setTimeout()` calls that do not have a duration PR-URL: #10530 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 23, 2017
* provide a RegExp for second argument to `assert.throws()` * remove unused function arguments * provide duration of 1 ms for `setTimeout()` calls that do not have a duration PR-URL: #10530 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 24, 2017
* provide a RegExp for second argument to `assert.throws()` * remove unused function arguments * provide duration of 1 ms for `setTimeout()` calls that do not have a duration PR-URL: #10530 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Jan 31, 2017
* provide a RegExp for second argument to `assert.throws()` * remove unused function arguments * provide duration of 1 ms for `setTimeout()` calls that do not have a duration PR-URL: #10530 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
assert.throws()setTimeout()calls that do not have aduration
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test stream