Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: cleanup test-crypto-dh.js #10753

Closed
wants to merge 1 commit into from
Closed

test: cleanup test-crypto-dh.js #10753

wants to merge 1 commit into from

Conversation

fluxsauce
Copy link

  • Checking for thrown errors from crypto.createDiffieHellman
  • Avoiding unused vars in ecdh5.setPrivateKey
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@fluxsauce
test: cleanup test-crypto-dh.js
87a4766 
Checking for thrown errors from crypto.createDiffieHellman
Avoiding unused vars in ecdh5.setPrivateKey
@nodejs-github-bot nodejs-github-bot added test Issues and PRs related to the tests. lts-watch-v6.x labels Jan 12, 2017
Trott
Trott approved these changes Jan 12, 2017
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI is green

@Trott
Copy link
Member

Trott commented Jan 12, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/5818/

@mscdex mscdex added the crypto Issues and PRs related to the crypto subsystem. label Jan 12, 2017
@mscdex
Copy link
Contributor

mscdex commented Jan 12, 2017

I think these changes are already being made in this PR: #10734

@fluxsauce fluxsauce mentioned this pull request Jan 12, 2017
Closed
3 tasks
@fluxsauce
Copy link
Author

@mscdex so they are. Made a minor note on the other PR to include one of the improvements, closing this. Thanks!

@fluxsauce fluxsauce closed this Jan 12, 2017
@fluxsauce fluxsauce deleted the test-crypto-dh-args branch January 12, 2017 05:56
@jasnell
Copy link
Member

jasnell commented Jan 12, 2017

Yes, this appears to be a duplicate

@adamlaska adamlaska mentioned this pull request Nov 25, 2023
Open
@aliscco aliscco mentioned this pull request Nov 28, 2023
Open
@leonardoadame leonardoadame mentioned this pull request Nov 28, 2023
Open
This was referenced Nov 28, 2023
Open
Open
This was referenced Nov 29, 2023
Open
Open
This was referenced Nov 29, 2023
Open
Open
Open
@leonardoadame leonardoadame mentioned this pull request Nov 29, 2023
Open
@aliscco aliscco mentioned this pull request Nov 29, 2023
Open
@leonardoadame leonardoadame mentioned this pull request Nov 29, 2023
Open
This was referenced Nov 30, 2023
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
crypto Issues and PRs related to the crypto subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fluxsauce @Trott @mscdex @jasnell @nodejs-github-bot