child_process: allow Infinity as maxBuffer value #10769

cjihrig · 2017-01-12T18:44:09Z

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
commit message follows commit guidelines

Affected core subsystem(s)

child_process

sam-github · 2017-01-12T18:48:08Z

+1 for feature, but needs docs and tests across all child_process APIs that support maxBuffer. Doesn't have to test that the behaviour is unlimited, but should test that it doesn't abort or throw arg typerrors.

jasnell · 2017-01-12T18:50:55Z

test/parallel/test-child-process-spawnsync-validation-errors.js

  fail('maxBuffer', -1, err);
  fail('maxBuffer', NaN, err);
-  fail('maxBuffer', Infinity, err);
  fail('maxBuffer', true, err);
  fail('maxBuffer', false, err);
  fail('maxBuffer', __dirname, err);


Perhaps include a fail test for -Infinity

cjihrig · 2017-01-12T19:02:08Z

src/spawn_sync.cc

-    CHECK(js_max_buffer->IsUint32());
-    max_buffer_ = js_max_buffer->Uint32Value();
+    CHECK(js_max_buffer->IsNumber());
+    max_buffer_ = js_max_buffer->NumberValue();


Hm, I'm not sure that JavaScript Infinity will convert to C++ properly here.

OK, so JavaScript Infinity translates to std::numeric_limits<double>::infinity() in C++. So, I changed max_buffer_ to a double.

mscdex · 2017-01-12T19:32:16Z

For consistency, we should probably add the same conditionals to the async counterparts.

sindresorhus · 2017-01-13T05:24:58Z

lib/child_process.js

@@ -473,7 +473,7 @@ function spawnSync(/*file, args, options*/) {

  // Validate maxBuffer, if present.
  if (options.maxBuffer != null &&
-      !(Number.isInteger(options.maxBuffer) && options.maxBuffer >= 0)) {
+      !(typeof options.maxBuffer === 'number' && options.maxBuffer >= 0)) {
    throw new TypeError('"maxBuffer" must be an unsigned integer');


Error message needs to be updated to reflect the new constraint (It now accepts any positive number, not just unsigned integer).

That's a good point. The integer check is still required otherwise we'll have nonsense things like 0.1 accepted as the maxBuffer. The check should likely be something like:

if ((Number.isInteger(options.maxBuffer) || options.maxBuffer === Infinity) && options.maxBuffer >= 0) { ... }

And the error message should certainly be updated but that would upgrade this to a semver-major change

0.1 is technically fine as a maxBuffer value, even if it is a bit weird. We're just going to be doing comparisons against the value to see if we surpass it.

And the error message should certainly be updated but that would upgrade this to a semver-major change

This builds on an existing semver major change, so this is going to be semver major regardless.

jasnell · 2017-01-13T17:47:55Z

lib/child_process.js

@@ -473,7 +473,7 @@ function spawnSync(/*file, args, options*/) {

  // Validate maxBuffer, if present.
  if (options.maxBuffer != null &&
-      !(Number.isInteger(options.maxBuffer) && options.maxBuffer >= 0)) {
+      !(typeof options.maxBuffer === 'number' && options.maxBuffer >= 0)) {
    throw new TypeError('"maxBuffer" must be an unsigned integer');


That's a good point. The integer check is still required otherwise we'll have nonsense things like 0.1 accepted as the maxBuffer. The check should likely be something like:

if ((Number.isInteger(options.maxBuffer) || options.maxBuffer === Infinity) && options.maxBuffer >= 0) { ... }

And the error message should certainly be updated but that would upgrade this to a semver-major change

mscdex · 2017-01-13T18:58:25Z

Instead of "non-negative", can we use "positive"?

cjihrig · 2017-01-13T18:59:40Z

But zero is an allowed, non-positive value.

mscdex · 2017-01-13T19:03:05Z

It depends on which zero you're talking about ;-)

cjihrig · 2017-01-13T19:03:59Z

Ha. Ok, I'll make it just "positive"

cjihrig · 2017-01-16T18:36:34Z

CI: https://ci.nodejs.org/job/node-test-pull-request/5889/

cjihrig · 2017-01-16T20:33:03Z

Another CI run because Windows: https://ci.nodejs.org/job/node-test-pull-request/5891/

cjihrig · 2017-01-17T15:19:48Z

Another CI run: https://ci.nodejs.org/job/node-test-pull-request/5911/

Fixes: nodejs#10767 PR-URL: nodejs#10769 Reviewed-By: James M Snell <jasnell@gmail.com>

This commit refactors test-child-process-spawnsync-maxbuf.js, and adds testing for the case where maxBuffer is Infinity. PR-URL: nodejs#10769 Reviewed-By: James M Snell <jasnell@gmail.com>

Fixes: nodejs#10767 PR-URL: nodejs#10769 Reviewed-By: James M Snell <jasnell@gmail.com>

This commit refactors test-child-process-spawnsync-maxbuf.js, and adds testing for the case where maxBuffer is Infinity. PR-URL: nodejs#10769 Reviewed-By: James M Snell <jasnell@gmail.com>

sam-github · 2017-04-12T21:20:03Z

@cjihrig why is this semver-major? Is it because you added validation for some args?

cjihrig · 2017-04-12T21:29:48Z

Yes.

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. child_process Issues and PRs related to the child_process subsystem. dont-land-on-v7.x labels Jan 12, 2017

cjihrig mentioned this pull request Jan 12, 2017

child_process: Allow an unlimited maxBuffer size in child_process #10767

Closed

2 tasks

sam-github added the semver-minor PRs that contain new features and should be released in the next minor version. label Jan 12, 2017

jasnell reviewed Jan 12, 2017

View reviewed changes

cjihrig commented Jan 12, 2017

View reviewed changes

cjihrig force-pushed the 10767 branch from 04bb78d to 4bde5b0 Compare January 12, 2017 19:21

nodejs-github-bot added the dont-land-on-v7.x label Jan 12, 2017

mscdex removed the dont-land-on-v7.x label Jan 12, 2017

sindresorhus reviewed Jan 13, 2017

View reviewed changes

jasnell requested changes Jan 13, 2017

View reviewed changes

cjihrig added semver-major PRs that contain breaking changes and should be released in the next major version. and removed semver-minor PRs that contain new features and should be released in the next minor version. labels Jan 13, 2017

nodejs-github-bot added the dont-land-on-v7.x label Jan 13, 2017

cjihrig force-pushed the 10767 branch from 8f597e8 to 901de6f Compare January 13, 2017 18:17

nodejs-github-bot added the dont-land-on-v7.x label Jan 13, 2017

jasnell approved these changes Jan 13, 2017

View reviewed changes

cjihrig force-pushed the 10767 branch from 901de6f to 92ac035 Compare January 16, 2017 18:10

nodejs-github-bot added the dont-land-on-v7.x label Jan 16, 2017

cjihrig force-pushed the 10767 branch from c3626e8 to 6303d66 Compare January 16, 2017 18:34

nodejs-github-bot added the dont-land-on-v7.x label Jan 16, 2017

cjihrig force-pushed the 10767 branch from 6303d66 to 57d05c9 Compare January 16, 2017 20:32

nodejs-github-bot added the dont-land-on-v7.x label Jan 16, 2017

cjihrig force-pushed the 10767 branch from 57d05c9 to 78dec95 Compare January 17, 2017 15:18

nodejs-github-bot added the dont-land-on-v7.x label Jan 17, 2017

cjihrig added 2 commits January 17, 2017 10:47

child_process: allow Infinity as maxBuffer value

8f3ff98

Fixes: nodejs#10767 PR-URL: nodejs#10769 Reviewed-By: James M Snell <jasnell@gmail.com>

test: refactor test-child-process-spawnsync-maxbuf

5b30c4f

This commit refactors test-child-process-spawnsync-maxbuf.js, and adds testing for the case where maxBuffer is Infinity. PR-URL: nodejs#10769 Reviewed-By: James M Snell <jasnell@gmail.com>

cjihrig force-pushed the 10767 branch from 78dec95 to 5b30c4f Compare January 17, 2017 15:49

nodejs-github-bot added the dont-land-on-v7.x label Jan 17, 2017

cjihrig merged commit 5b30c4f into nodejs:master Jan 17, 2017

cjihrig deleted the 10767 branch January 17, 2017 15:52

italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 18, 2017

child_process: allow Infinity as maxBuffer value

e4e29ad

Fixes: nodejs#10767 PR-URL: nodejs#10769 Reviewed-By: James M Snell <jasnell@gmail.com>

targos removed the dont-land-on-v7.x label Jan 28, 2017

jasnell mentioned this pull request Apr 4, 2017

8.0.0 Release Proposal #12220

Closed

evanlucas mentioned this pull request Apr 11, 2017

maxBuffer of Infinity aborts child_process.execSync #10768

Closed

mscdex mentioned this pull request Apr 23, 2017

net: use actual Timeout instances on Sockets #11154

Closed

3 tasks

koh110 mentioned this pull request Oct 22, 2018

child_process: use non-infinite maxBuffer defaults #23027

Closed

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

child_process: allow Infinity as maxBuffer value #10769

child_process: allow Infinity as maxBuffer value #10769

cjihrig commented Jan 12, 2017 •

edited

Loading

sam-github commented Jan 12, 2017

jasnell Jan 12, 2017

cjihrig Jan 12, 2017

cjihrig Jan 12, 2017

mscdex commented Jan 12, 2017

sindresorhus Jan 13, 2017

jasnell Jan 13, 2017

cjihrig Jan 13, 2017

jasnell Jan 13, 2017

mscdex commented Jan 13, 2017 •

edited

Loading

cjihrig commented Jan 13, 2017

mscdex commented Jan 13, 2017

cjihrig commented Jan 13, 2017

cjihrig commented Jan 16, 2017

cjihrig commented Jan 16, 2017

cjihrig commented Jan 17, 2017

sam-github commented Apr 12, 2017

cjihrig commented Apr 12, 2017

child_process: allow Infinity as maxBuffer value #10769

child_process: allow Infinity as maxBuffer value #10769

Conversation

cjihrig commented Jan 12, 2017 • edited Loading

Checklist

Affected core subsystem(s)

sam-github commented Jan 12, 2017

jasnell Jan 12, 2017

Choose a reason for hiding this comment

cjihrig Jan 12, 2017

Choose a reason for hiding this comment

cjihrig Jan 12, 2017

Choose a reason for hiding this comment

mscdex commented Jan 12, 2017

sindresorhus Jan 13, 2017

Choose a reason for hiding this comment

jasnell Jan 13, 2017

Choose a reason for hiding this comment

cjihrig Jan 13, 2017

Choose a reason for hiding this comment

jasnell Jan 13, 2017

Choose a reason for hiding this comment

mscdex commented Jan 13, 2017 • edited Loading

cjihrig commented Jan 13, 2017

mscdex commented Jan 13, 2017

cjihrig commented Jan 13, 2017

cjihrig commented Jan 16, 2017

cjihrig commented Jan 16, 2017

cjihrig commented Jan 17, 2017

sam-github commented Apr 12, 2017

cjihrig commented Apr 12, 2017

cjihrig commented Jan 12, 2017 •

edited

Loading

mscdex commented Jan 13, 2017 •

edited

Loading