Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

url: remove redundant assignment in url.parse #1095

Closed
wants to merge 1 commit into from
Closed

url: remove redundant assignment in url.parse #1095

wants to merge 1 commit into from

Conversation

rlidwka
Copy link
Contributor

@rlidwka rlidwka commented Mar 8, 2015

Just a nitpick.

this.href is set later in url.js#L345, so I believe this assignment does nothing except wastes CPU time.

@micnic
Copy link
Contributor

micnic commented Mar 8, 2015

LGTM! url.href value doesn't seem to be used somewhere before assigning url.format() to it.

Fishrock123 pushed a commit that referenced this pull request Mar 8, 2015
@rlidwka @Fishrock123
url: remove redundant assignment in url.parse
4bd3620 
PR-URL: #1095
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Nicu Micleușanu <micnic90@gmail.com>
@Fishrock123
Copy link
Contributor

Landed in 4bd3620 -- thanks! :)

@Fishrock123 Fishrock123 closed this Mar 8, 2015
@rvagg rvagg mentioned this pull request Mar 8, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rlidwka @micnic @Fishrock123