Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v4 backport: doc: unify dirname and filename description #10968

Closed
wants to merge 1 commit into from

Commits on Feb 13, 2017

  1. doc: unify dirname and filename description

    __dirname is path.dirname(__filename), but its docs, specifically the
    attempt to describe javascript scope in terms of "running" and
    "executing" had drifted apart. Rework to describe one as a variation of
    the other, move the example, and just describe the names in terms of the
    module, and it's local variables rather than the ill defined execution
    concepts.
    
    Fix: nodejs#5525
    PR-URL: nodejs#10527
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
    sam-github committed Feb 13, 2017
    Configuration menu
    Copy the full SHA
    dd97788 View commit details
    Browse the repository at this point in the history