Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal to update v7.x-staging #10989

Closed
wants to merge 168 commits into from

Conversation

italoacasas
Copy link
Contributor

@italoacasas italoacasas commented Jan 25, 2017

This is an(other) intent to update v7.x-staging... This time I cherry pick manually to detects the commits breaking the tests and the linter... I made lists by topics...

Note: This branch has two linter errors but I don't find the commit that introduces them, I was planning to deal with that later on before landing this on v7.x-staging

CI: https://ci.nodejs.org/job/node-test-pull-request/6076/console

### Question
1 - I'm doing something wrong? Because I see a lot of commits in the list for **git conflicts**
2 - @Trott do you have an idea why https://github.com/nodejs/node/commit/f44969a5ab is creating linter errors?

<details>
<summary>Do not land because git conflicts</summary>

* [[`50cb3a3711`](https://github.com/nodejs/node/commit/50cb3a3711)] - **doc**: document argument variant in the repl.md (Vse Mozhet Byt) [#10221](https://github.com/nodejs/node/pull/10221)
* [[`ba4847e879`](https://github.com/nodejs/node/commit/ba4847e879)] - **(SEMVER-MINOR)** **src**: Node Tracing Controller (misterpoe) [#9304](https://github.com/nodejs/node/pull/9304)
* [[`904b66d870`](https://github.com/nodejs/node/commit/904b66d870)] - **test**: increase coverage of Buffer.transcode (Joyee Cheung) [#10437](https://github.com/nodejs/node/pull/10437)
* [[`0f24bdd781`](https://github.com/nodejs/node/commit/0f24bdd781)] - **tracing**: fix -Wreorder warning (Santiago Gimeno) [#10416](https://github.com/nodejs/node/pull/10416)
* [[`e69a69672b`](https://github.com/nodejs/node/commit/e69a69672b)] - **tracing**: fix -Wunused-private-field warning (Santiago Gimeno) [#10416](https://github.com/nodejs/node/pull/10416)
* [[`81d0717406`](https://github.com/nodejs/node/commit/81d0717406)] - **src**: always initialize tracing controller in agent (Matt Loring) [#10507](https://github.com/nodejs/node/pull/10507)
* [[`ff1efa6087`](https://github.com/nodejs/node/commit/ff1efa6087)] - **test**: use const for all require() calls (cjihrig) [#10550](https://github.com/nodejs/node/pull/10550)
* [[`f3f2468bdc`](https://github.com/nodejs/node/commit/f3f2468bdc)] - **doc**: fix CHANGELOG.md table formatting (Сковорода Никита Андреевич) [#10743](https://github.com/nodejs/node/pull/10743)
* [[`6d31bdb872`](https://github.com/nodejs/node/commit/6d31bdb872)] - **doc**: move Boron releases to LTS column (Anna Henningsen) [#10827](https://github.com/nodejs/node/pull/10827)
* [[`e1fedfb6ae`](https://github.com/nodejs/node/commit/e1fedfb6ae)] - **test**: refactor test-stream2-readable-wrap.js (David Goussev) [#10551](https://github.com/nodejs/node/pull/10551)
* [[`7c77932fa2`](https://github.com/nodejs/node/commit/7c77932fa2)] - **test**: refactor several parallel/test-timer tests (Beth Griggs) [#10524](https://github.com/nodejs/node/pull/10524)
* [[`7a46b992d2`](https://github.com/nodejs/node/commit/7a46b992d2)] - **test**: improve the code in test-fs-read-stream (Adrian Estrada) [#10556](https://github.com/nodejs/node/pull/10556)
* [[`5a51955480`](https://github.com/nodejs/node/commit/5a51955480)] - **test**: refactor test-timer-close (BethGriggs) [#10517](https://github.com/nodejs/node/pull/10517)
* [[`6ff3b03240`](https://github.com/nodejs/node/commit/6ff3b03240)] - **src, inspector**: add --inspect-brk option (Josh Gavant) [#8979](https://github.com/nodejs/node/pull/8979)
* [[`59a61a2ba7`](https://github.com/nodejs/node/commit/59a61a2ba7)] - **doc**: deprecate debug protocol (Jan Krems) [#10320](https://github.com/nodejs/node/pull/10320)
* [[`7f69972cf0`](https://github.com/nodejs/node/commit/7f69972cf0)] - **test**: refactor test-beforeexit-event-exit.js (cjihrig) [#10577](https://github.com/nodejs/node/pull/10577)
* [[`2306acfd94`](https://github.com/nodejs/node/commit/2306acfd94)] - **test**: fix process.title expectation (Sakthipriyan Vairamani (thefourtheye)) [#10597](https://github.com/nodejs/node/pull/10597)
* [[`d2c96af152`](https://github.com/nodejs/node/commit/d2c96af152)] - **test**: refactor beforeExit tests (Rich Trott) [#10581](https://github.com/nodejs/node/pull/10581)
* [[`f43ea2a6ae`](https://github.com/nodejs/node/commit/f43ea2a6ae)] - **test**: refactor test-stream-transform-object (Rich Trott) [#10588](https://github.com/nodejs/node/pull/10588)
* [[`8839d504cc`](https://github.com/nodejs/node/commit/8839d504cc)] - **test**: refactor the code in test-util-debug.js (sivaprasanna) [#10531](https://github.com/nodejs/node/pull/10531)
* [[`6c7219efcd`](https://github.com/nodejs/node/commit/6c7219efcd)] - **test**: improve test-fs-access (Adrian Estrada) [#10542](https://github.com/nodejs/node/pull/10542)
* [[`e5499b32cf`](https://github.com/nodejs/node/commit/e5499b32cf)] - **test**: s/assert.notEqual()/assert.notStrictEqual()/ (cjihrig) [#10541](https://github.com/nodejs/node/pull/10541)
* [[`f2d3afbd88`](https://github.com/nodejs/node/commit/f2d3afbd88)] - **deps**: cherry-pick 2f5da9a from V8 upstream (Steven R. Loomis) [#9828](https://github.com/nodejs/node/pull/9828)
* [[`58c38c2d2e`](https://github.com/nodejs/node/commit/58c38c2d2e)] - **src**: fix TracingController cleanup (Jason Ginchereau) [#10623](https://github.com/nodejs/node/pull/10623)
* [[`8a12368a20`](https://github.com/nodejs/node/commit/8a12368a20)] - **test**: improve test-fs-write-file-sync (Adrian Estrada) [#10624](https://github.com/nodejs/node/pull/10624)
* [[`5d31448844`](https://github.com/nodejs/node/commit/5d31448844)] - **tools,test**: enforce assert.ifError with lint rule (Teddy Katz) [#10671](https://github.com/nodejs/node/pull/10671)
* [[`0f62ee6963`](https://github.com/nodejs/node/commit/0f62ee6963)] - **(SEMVER-MINOR)** **url**: allow use of URL with http.request and https.request (James M Snell) [#10638](https://github.com/nodejs/node/pull/10638)
* [[`85a90340e1`](https://github.com/nodejs/node/commit/85a90340e1)] - **test**: improve test-crypto-rsa-dsa (Adrian Estrada) [#10681](https://github.com/nodejs/node/pull/10681)
* [[`da96843920`](https://github.com/nodejs/node/commit/da96843920)] - **test**: refactor cluster-preload.js (abouthiroppy) [#10701](https://github.com/nodejs/node/pull/10701)
* [[`7a0e462f9f`](https://github.com/nodejs/node/commit/7a0e462f9f)] - **test**: use eslint to fix var->const/let (Gibson Fahnestock) [#10685](https://github.com/nodejs/node/pull/10685)
* [[`81fef918d5`](https://github.com/nodejs/node/commit/81fef918d5)] - **tools, test**: require const/let in test (Gibson Fahnestock) [#10685](https://github.com/nodejs/node/pull/10685)
* [[`3d2aef3979`](https://github.com/nodejs/node/commit/3d2aef3979)] - **test**: s/assert.equal/assert.strictEqual/ (Gibson Fahnestock) [#10698](https://github.com/nodejs/node/pull/10698)
* [[`6509d747ee`](https://github.com/nodejs/node/commit/6509d747ee)] - **assert, tools**: enforce strict (not)equal in eslint (Gibson Fahnestock) [#10698](https://github.com/nodejs/node/pull/10698)
* [[`537d7bd936`](https://github.com/nodejs/node/commit/537d7bd936)] - **test**: improve test stream transform constructor (Adrian Estrada) [#10699](https://github.com/nodejs/node/pull/10699)
* [[`9271a412b9`](https://github.com/nodejs/node/commit/9271a412b9)] - **test**: getgroups() may contain duplicate GIDs (Sam Roberts) [#10389](https://github.com/nodejs/node/pull/10389)
* [[`5520e40af3`](https://github.com/nodejs/node/commit/5520e40af3)] - **test**: improve the code in test-crypto-dh (Adrian Estrada) [#10734](https://github.com/nodejs/node/pull/10734)
* [[`dab22b5b7a`](https://github.com/nodejs/node/commit/dab22b5b7a)] - **http**: optimize default method case (Brian White) [#10654](https://github.com/nodejs/node/pull/10654)
* [[`97f001ab16`](https://github.com/nodejs/node/commit/97f001ab16)] - **test,net**: add tests for server.connections (Rich Trott) [#10762](https://github.com/nodejs/node/pull/10762)
* [[`e5eae97683`](https://github.com/nodejs/node/commit/e5eae97683)] - **test**: add test case to test-http-response-statuscode.js (abouthiroppy) [#10808](https://github.com/nodejs/node/pull/10808)
* [[`b9adbf25a8`](https://github.com/nodejs/node/commit/b9adbf25a8)] - **test**: refactor test-cli-eval.js (Sumit Goel) [#10759](https://github.com/nodejs/node/pull/10759)
* [[`c685638986`](https://github.com/nodejs/node/commit/c685638986)] - **test**: improve test-stream2-large-read-stall (stefan judis) [#10725](https://github.com/nodejs/node/pull/10725)
* [[`8ab561b243`](https://github.com/nodejs/node/commit/8ab561b243)] - **test**: improve code in test-crypto-verify (Adrian Estrada) [#10845](https://github.com/nodejs/node/pull/10845)
* [[`ff75e21662`](https://github.com/nodejs/node/commit/ff75e21662)] - **test**: add dgram.Socket.prototype.bind's test (abouthiroppy) [#10894](https://github.com/nodejs/node/pull/10894)
* [[`492163c74c`](https://github.com/nodejs/node/commit/492163c74c)] - **test**: increase coverage of string-decoder (abouthiroppy) [#10863](https://github.com/nodejs/node/pull/10863)
* [[`e050c349ee`](https://github.com/nodejs/node/commit/e050c349ee)] - **test**: improve code in test-domain-multi (Adrian Estrada) [#10798](https://github.com/nodejs/node/pull/10798)
* [[`8e491a4f3f`](https://github.com/nodejs/node/commit/8e491a4f3f)] - **test**: improve code in test-console-instance (Adrian Estrada) [#10813](https://github.com/nodejs/node/pull/10813)
* [[`2057a63a91`](https://github.com/nodejs/node/commit/2057a63a91)] - **test**: improving coverage for dgram (abouthiroppy) [#10783](https://github.com/nodejs/node/pull/10783)
* [[`d86ff5fc29`](https://github.com/nodejs/node/commit/d86ff5fc29)] - **test**: refactor test-fs-read-zero-length.js (abouthiroppy) [#10729](https://github.com/nodejs/node/pull/10729)
* [[`48da656b69`](https://github.com/nodejs/node/commit/48da656b69)] - **test**: improving coverage of dns-lookup (abouthiroppy) [#10844](https://github.com/nodejs/node/pull/10844)
* [[`622b43997f`](https://github.com/nodejs/node/commit/622b43997f)] - **test**: add tests for rs+, sr+ to test-fs-open-flags.js (abouthiroppy) [#10780](https://github.com/nodejs/node/pull/10780)
* [[`974ecb0598`](https://github.com/nodejs/node/commit/974ecb0598)] - **build**: sort sources alphabetically (Daniel Bevenius) [#10892](https://github.com/nodejs/node/pull/10892)
* [[`4f8582e533`](https://github.com/nodejs/node/commit/4f8582e533)] - **test**: update V8 flag in test (Franziska Hinkelmann) [#10917](https://github.com/nodejs/node/pull/10917)
* [[`33012e9866`](https://github.com/nodejs/node/commit/33012e9866)] - **(SEMVER-MINOR)** **crypto**: ability to select cert store at runtime (Adam Majer) [#8334](https://github.com/nodejs/node/pull/8334)
</details>

<details>
<summary>Do not land because break tests</summary>

* [[`e9b7291679`](https://github.com/nodejs/node/commit/e9b7291679)] - **deps**: add test for v8 bug in toUpper('ç') (Steven R. Loomis) [#9828](https://github.com/nodejs/node/pull/9828)
* [[`4444e731f2`](https://github.com/nodejs/node/commit/4444e731f2)] - **fs**: ensure readFile\[Sync\] reads from the beginning (Nikolai Vavilov) [#9699](https://github.com/nodejs/node/pull/9699)
</details>

<details>
<summary>Empty commits</summary>

* [[`8bad37a547`](https://github.com/nodejs/node/commit/8bad37a547)] - **test**: refactor test-https-truncate (Rich Trott) [#10225](https://github.com/nodejs/node/pull/10225)
* [[`26bf9545e0`](https://github.com/nodejs/node/commit/26bf9545e0)] - ***Revert*** "**test**: test.py add option to use node in path" (Sakthipriyan Vairamani (thefourtheye)) [#10613](https://github.com/nodejs/node/pull/10613)
* [[`0c8cfd4eca`](https://github.com/nodejs/node/commit/0c8cfd4eca)] - **eslint**: remove dangling eslint symlink (Sam Roberts) [#10771](https://github.com/nodejs/node/pull/10771)
</details>

<details>
<summary>Cherry Picked commits</summary>

* [[`a68987c154`](https://github.com/nodejs/node/commit/a68987c154)] - **benchmark,lib,test**: adjust for linting (Rich Trott) [#10561](https://github.com/nodejs/node/pull/10561)
* [[`f44969a5ab`](https://github.com/nodejs/node/commit/f44969a5ab)] - **tools**: update ESLint to current version (Rich Trott) [#10561](https://github.com/nodejs/node/pull/10561)
* [[`5b82800241`](https://github.com/nodejs/node/commit/5b82800241)] - **test**: refactor the code in test-fs-watch.js (sivaprasanna) [#10357](https://github.com/nodejs/node/pull/10357)
* [[`a1652324cd`](https://github.com/nodejs/node/commit/a1652324cd)] - **test**: reduce unmanaged parallelism in domain test (Joyee Cheung) [#10329](https://github.com/nodejs/node/pull/10329)
* [[`746a46ebdd`](https://github.com/nodejs/node/commit/746a46ebdd)] - **test**: increase usage of assert.ifError() (cjihrig) [#10543](https://github.com/nodejs/node/pull/10543)
* [[`ee9df357ff`](https://github.com/nodejs/node/commit/ee9df357ff)] - **test, win**: fix up symlink tests (Hitesh Kanwathirtha) [#10477](https://github.com/nodejs/node/pull/10477)
* [[`3e76364be3`](https://github.com/nodejs/node/commit/3e76364be3)] - **inspector**: remove unused uv_async_t (Eugene Ostroukhov) [#10392](https://github.com/nodejs/node/pull/10392)
* [[`c963094f3c`](https://github.com/nodejs/node/commit/c963094f3c)] - **test**: improve the code in test-process-cpuUsage (Adrian Estrada) [#10714](https://github.com/nodejs/node/pull/10714)
* [[`e21126d20f`](https://github.com/nodejs/node/commit/e21126d20f)] - **test**: increase test-crypto.js strictness (Rich Trott) [#10784](https://github.com/nodejs/node/pull/10784)
* [[`1b2d3f7ae7`](https://github.com/nodejs/node/commit/1b2d3f7ae7)] - **doc**: clarify information about ABI version (Rich Trott) [#10419](https://github.com/nodejs/node/pull/10419)
* [[`f418a22767`](https://github.com/nodejs/node/commit/f418a22767)] - **doc**: modernize child_process example code (Vse Mozhet Byt) [#10102](https://github.com/nodejs/node/pull/10102)
* [[`c1b12a2896`](https://github.com/nodejs/node/commit/c1b12a2896)] - **doc**: new TLSSocket has no secure context options (Sam Roberts) [#10545](https://github.com/nodejs/node/pull/10545)
* [[`c9b52aad0a`](https://github.com/nodejs/node/commit/c9b52aad0a)] - **doc**: update BUILDING.md (Lukasz Gasior) [#10669](https://github.com/nodejs/node/pull/10669)
* [[`59a3f868a9`](https://github.com/nodejs/node/commit/59a3f868a9)] - **doc**: document use of Refs: for references (Gibson Fahnestock) [#10670](https://github.com/nodejs/node/pull/10670)
* [[`fc647fddff`](https://github.com/nodejs/node/commit/fc647fddff)] - **doc**: killSignal option accepts integer values (Sakthipriyan Vairamani (thefourtheye)) [#10424](https://github.com/nodejs/node/pull/10424)
* [[`eb0df4a9b9`](https://github.com/nodejs/node/commit/eb0df4a9b9)] - **doc**: add test naming information to guide (Rich Trott) [#10584](https://github.com/nodejs/node/pull/10584)
* [[`4e8eb628c1`](https://github.com/nodejs/node/commit/4e8eb628c1)] - **doc**: fix missing negation in stream.md (Johannes Rieken) [#10712](https://github.com/nodejs/node/pull/10712)
* [[`db14687dec`](https://github.com/nodejs/node/commit/db14687dec)] - **doc**: "s/git apply/git am -3" in V8 guide (Myles Borins) [#10665](https://github.com/nodejs/node/pull/10665)
* [[`f1253e8627`](https://github.com/nodejs/node/commit/f1253e8627)] - **doc**: update LTS info for current releases (Evan Lucas) [#10720](https://github.com/nodejs/node/pull/10720)
* [[`ed9b6c1264`](https://github.com/nodejs/node/commit/ed9b6c1264)] - **doc**: correct vcbuild options for windows testing (Jonathan Boarman) [#10686](https://github.com/nodejs/node/pull/10686)
* [[`fa3836152d`](https://github.com/nodejs/node/commit/fa3836152d)] - **doc**: mention cc-ing nodejs/url team for reviews (Anna Henningsen) [#10652](https://github.com/nodejs/node/pull/10652)
* [[`02b9270444`](https://github.com/nodejs/node/commit/02b9270444)] - **doc**: sort require statements in tests (Sam Roberts) [#10616](https://github.com/nodejs/node/pull/10616)
* [[`e9044c83a9`](https://github.com/nodejs/node/commit/e9044c83a9)] - **doc**: handle backpressure when write() return false (Matteo Collina) [#10631](https://github.com/nodejs/node/pull/10631)
* [[`0674789f36`](https://github.com/nodejs/node/commit/0674789f36)] - **doc**: edit writing-tests.md (Rich Trott) [#10585](https://github.com/nodejs/node/pull/10585)
* [[`8781e61843`](https://github.com/nodejs/node/commit/8781e61843)] - **doc**: fix misleading language in vm docs (Alexey Orlenko) [#10708](https://github.com/nodejs/node/pull/10708)
* [[`7f20c8a3d4`](https://github.com/nodejs/node/commit/7f20c8a3d4)] - **doc**: update writable.write return value (Nathan Phillip Brink) [#10582](https://github.com/nodejs/node/pull/10582)
* [[`f9665280a4`](https://github.com/nodejs/node/commit/f9665280a4)] - **doc**: use correct tls certificate property name (Sam Roberts) [#10389](https://github.com/nodejs/node/pull/10389)
* [[`828f0c838e`](https://github.com/nodejs/node/commit/828f0c838e)] - **doc**: fix broken internal link in process.md (Anna Henningsen) [#10828](https://github.com/nodejs/node/pull/10828)
* [[`5ab910e9df`](https://github.com/nodejs/node/commit/5ab910e9df)] - **doc**: clarify memory sharing behavior of buffer ctor (Zach Bjornson) [#10778](https://github.com/nodejs/node/pull/10778)
* [[`f0ebb3ec5b`](https://github.com/nodejs/node/commit/f0ebb3ec5b)] - **doc**: fixup `added` tags in cli.md (Anna Henningsen) [#10826](https://github.com/nodejs/node/pull/10826)
* [[`753021c35b`](https://github.com/nodejs/node/commit/753021c35b)] - **doc**: add missing `added:` tag for `zlib.constants` (Anna Henningsen) [#10826](https://github.com/nodejs/node/pull/10826)
* [[`70e800a159`](https://github.com/nodejs/node/commit/70e800a159)] - **doc**: fix markdown escaping in CHANGELOG_V7.md (Anna Henningsen) [#10827](https://github.com/nodejs/node/pull/10827)
* [[`bf6e239aa9`](https://github.com/nodejs/node/commit/bf6e239aa9)] - **doc**: remove duplicate PR link from changelog (Anna Henningsen) [#10827](https://github.com/nodejs/node/pull/10827)
* [[`55c42bc6e5`](https://github.com/nodejs/node/commit/55c42bc6e5)] - **doc**: add links for zlib convenience methods (Anna Henningsen) [#10829](https://github.com/nodejs/node/pull/10829)
* [[`c4b4611e58`](https://github.com/nodejs/node/commit/c4b4611e58)] - **doc**: add edsadr to collaborators (Adrian Estrada) [#10883](https://github.com/nodejs/node/pull/10883)
* [[`762f260c4d`](https://github.com/nodejs/node/commit/762f260c4d)] - **doc**: clarifying variables in fs.write() (Jessica Quynh Tran) [#9792](https://github.com/nodejs/node/pull/9792)
* [[`0c58193d1b`](https://github.com/nodejs/node/commit/0c58193d1b)] - **doc**: mention moderation repo in onboarding doc (Anna Henningsen) [#10869](https://github.com/nodejs/node/pull/10869)
* [[`09ebdf1400`](https://github.com/nodejs/node/commit/09ebdf1400)] - **doc**: add TimothyGu to collaborators (Timothy Gu) [#10954](https://github.com/nodejs/node/pull/10954)
* [[`0345d0d645`](https://github.com/nodejs/node/commit/0345d0d645)] - **doc**: update AUTHORS list to fix name (Noah Rose Ledesma) [#10945](https://github.com/nodejs/node/pull/10945)
* [[`3e9c8ef53b`](https://github.com/nodejs/node/commit/3e9c8ef53b)] - **doc**: update examples in api/crypto.md (Vse Mozhet Byt) [#10909](https://github.com/nodejs/node/pull/10909)
* [[`7eef09ddcf`](https://github.com/nodejs/node/commit/7eef09ddcf)] - **doc**: move topics/guides to website (Evan Lucas) [#10896](https://github.com/nodejs/node/pull/10896)
* [[`c7ff96b0f7`](https://github.com/nodejs/node/commit/c7ff96b0f7)] - **async_wrap**: close the destroy_ids_idle_handle_ (René Schünemann) [#10385](https://github.com/nodejs/node/pull/10385)
* [[`aa77b767b6`](https://github.com/nodejs/node/commit/aa77b767b6)] - **lib,src**: support values > 4GB in heap statistics (Ben Noordhuis) [#10186](https://github.com/nodejs/node/pull/10186)
* [[`2e2887579f`](https://github.com/nodejs/node/commit/2e2887579f)] - ***Revert*** "**repl**: disable Ctrl+C support on win32 for now" (Anna Henningsen) [#8645](https://github.com/nodejs/node/pull/8645)
* [[`3196faedab`](https://github.com/nodejs/node/commit/3196faedab)] - **test**: fix Coverity warning in inspector test (Eugene Ostroukhov) [#10510](https://github.com/nodejs/node/pull/10510)
* [[`2177a38178`](https://github.com/nodejs/node/commit/2177a38178)] - **url**: TupleOrigin#toString use unicode by default (Joyee Cheung) [#10552](https://github.com/nodejs/node/pull/10552)
* [[`6e2f8a421b`](https://github.com/nodejs/node/commit/6e2f8a421b)] - **doc**: update TheAlphaNerd to MylesBorins (Myles Borins) [#10586](https://github.com/nodejs/node/pull/10586)
* [[`7889416b8a`](https://github.com/nodejs/node/commit/7889416b8a)] - **benchmark**: keep decimals in results (Brian White) [#10559](https://github.com/nodejs/node/pull/10559)
* [[`f955c734ba`](https://github.com/nodejs/node/commit/f955c734ba)] - **benchmark**: improve readability of net benchmarks (Brian White) [#10446](https://github.com/nodejs/node/pull/10446)
* [[`d43b14495c`](https://github.com/nodejs/node/commit/d43b14495c)] - **benchmark**: move punycode benchmark out of net (Brian White) [#10446](https://github.com/nodejs/node/pull/10446)
* [[`26f2a6e87c`](https://github.com/nodejs/node/commit/26f2a6e87c)] - **util**: avoid out-of-bounds arguments index access (Teddy Katz) [#10569](https://github.com/nodejs/node/pull/10569)
* [[`398229ac71`](https://github.com/nodejs/node/commit/398229ac71)] - **assert**: update comments (Kai Cataldo) [#10579](https://github.com/nodejs/node/pull/10579)
* [[`0a937280d8`](https://github.com/nodejs/node/commit/0a937280d8)] - **stream**: avoid additional validation for Buffers (Brian White) [#10580](https://github.com/nodejs/node/pull/10580)
* [[`aab1dd6ff4`](https://github.com/nodejs/node/commit/aab1dd6ff4)] - **events**: improve removeListener() performance (Brian White) [#10572](https://github.com/nodejs/node/pull/10572)
* [[`6830849b2e`](https://github.com/nodejs/node/commit/6830849b2e)] - **test**: improve test-fs-null-bytes (Adrian Estrada) [#10521](https://github.com/nodejs/node/pull/10521)
* [[`da71d48e47`](https://github.com/nodejs/node/commit/da71d48e47)] - **benchmark**: fix typo "categoty" -> "category" (Victor Felder) [#10568](https://github.com/nodejs/node/pull/10568)
* [[`e52fee50a0`](https://github.com/nodejs/node/commit/e52fee50a0)] - **events**: avoid emit() eager deopt (Victor Felder) [#10568](https://github.com/nodejs/node/pull/10568)
* [[`26b8c2127d`](https://github.com/nodejs/node/commit/26b8c2127d)] - **test**: mark test-tty-wrap as flaky for AIX (Michael Dawson) [#10618](https://github.com/nodejs/node/pull/10618)
* [[`132e44b402`](https://github.com/nodejs/node/commit/132e44b402)] - **meta**: decharter the http working group (James M Snell) [#10604](https://github.com/nodejs/node/pull/10604)
* [[`81228497c5`](https://github.com/nodejs/node/commit/81228497c5)] - **url**: do not decode arbitrary %2e sequences in paths (James M Snell) [#10602](https://github.com/nodejs/node/pull/10602)
* [[`5161b00af5`](https://github.com/nodejs/node/commit/5161b00af5)] - **url**: change null password handling (James M Snell) [#10601](https://github.com/nodejs/node/pull/10601)
* [[`103f6d7d34`](https://github.com/nodejs/node/commit/103f6d7d34)] - **doc**: mention cc-ing nodejs/python team for reviews (Anna Henningsen) [#10637](https://github.com/nodejs/node/pull/10637)
* [[`eab95630f1`](https://github.com/nodejs/node/commit/eab95630f1)] - **test**: check error and cleanups in test-fs-read-buffer (Anna Henningsen) [#10611](https://github.com/nodejs/node/pull/10611)
* [[`c04d4df08c`](https://github.com/nodejs/node/commit/c04d4df08c)] - **http**: eliminate capture of ClientRequest in Agent (Evan Torrie) [#10134](https://github.com/nodejs/node/pull/10134)
* [[`75ebd19d8d`](https://github.com/nodejs/node/commit/75ebd19d8d)] - **test**: improve test-event-emitter-modify-in-emit (Adrian Estrada) [#10600](https://github.com/nodejs/node/pull/10600)
* [[`6d3c5b78c8`](https://github.com/nodejs/node/commit/6d3c5b78c8)] - **src**: reduce test_inspector_socket_server output (Daniel Bevenius) [#10537](https://github.com/nodejs/node/pull/10537)
* [[`377ea285fb`](https://github.com/nodejs/node/commit/377ea285fb)] - **test**: refactor test-fs-utimes (Junshu Okamoto) [#9290](https://github.com/nodejs/node/pull/9290)
* [[`4e5cf85ada`](https://github.com/nodejs/node/commit/4e5cf85ada)] - **tools**: add lint rule to enforce timer arguments (Rich Trott) [#9472](https://github.com/nodejs/node/pull/9472)
* [[`6263c00828`](https://github.com/nodejs/node/commit/6263c00828)] - **test**: provide duration/interval to timers (Rich Trott) [#9472](https://github.com/nodejs/node/pull/9472)
* [[`38b18e330f`](https://github.com/nodejs/node/commit/38b18e330f)] - **tools**: remove no-useless-regex-char-class-escape (Rich Trott) [#10561](https://github.com/nodejs/node/pull/10561)
* [[`33cd0aa70c`](https://github.com/nodejs/node/commit/33cd0aa70c)] - **tools**: remove custom align-function-arguments rule (Rich Trott) [#10561](https://github.com/nodejs/node/pull/10561)
* [[`a5bdcc39ac`](https://github.com/nodejs/node/commit/a5bdcc39ac)] - **test**: improve test-fs-readfile-zero-byte-liar (Adrian Estrada) [#10570](https://github.com/nodejs/node/pull/10570)
* [[`f895715755`](https://github.com/nodejs/node/commit/f895715755)] - **test**: improve test-http-chunked-304 (Adrian Estrada) [#10462](https://github.com/nodejs/node/pull/10462)
* [[`fd115862f4`](https://github.com/nodejs/node/commit/fd115862f4)] - **test**: improve code in test-https-strict (Adrian Estrada) [#10648](https://github.com/nodejs/node/pull/10648)
* [[`a799854ce9`](https://github.com/nodejs/node/commit/a799854ce9)] - **test**: refactor test-watch-file.js (sivaprasanna) [#10679](https://github.com/nodejs/node/pull/10679)
* [[`a2ea1344ea`](https://github.com/nodejs/node/commit/a2ea1344ea)] - **http**: define all used properties in constructors (vitkarpov) [#9116](https://github.com/nodejs/node/pull/9116)
* [[`3f61521087`](https://github.com/nodejs/node/commit/3f61521087)] - **test,cluster**: add test-cluster-worker-deprecated (Rich Trott) [#10675](https://github.com/nodejs/node/pull/10675)
* [[`39c4af580c`](https://github.com/nodejs/node/commit/39c4af580c)] - **test**: improve zlib-from-gzip-with-trailing-garbage (Michael Lefkowitz) [#10674](https://github.com/nodejs/node/pull/10674)
* [[`41567ee9d8`](https://github.com/nodejs/node/commit/41567ee9d8)] - **test**: refactor the code in test-child-process-spawn-loop.js (sivaprasanna) [#10605](https://github.com/nodejs/node/pull/10605)
* [[`b9abeeccc0`](https://github.com/nodejs/node/commit/b9abeeccc0)] - **test**: allow testing uid and gid separately (cjihrig) [#10647](https://github.com/nodejs/node/pull/10647)
* [[`5aa210afe6`](https://github.com/nodejs/node/commit/5aa210afe6)] - **doc**: specify sorted requires in tests (Sam Roberts) [#10716](https://github.com/nodejs/node/pull/10716)
* [[`2685464e34`](https://github.com/nodejs/node/commit/2685464e34)] - **test**: improve the code in test-process-hrtime (Adrian Estrada) [#10667](https://github.com/nodejs/node/pull/10667)
* [[`596d86fc3d`](https://github.com/nodejs/node/commit/596d86fc3d)] - **test**: refactor test-crypto-padding-aes256 (adelmann) [#10622](https://github.com/nodejs/node/pull/10622)
* [[`aacd323ff3`](https://github.com/nodejs/node/commit/aacd323ff3)] - **test**: refactor the code of test-keep-alive.js (sivaprasanna) [#10684](https://github.com/nodejs/node/pull/10684)
* [[`022b53c9de`](https://github.com/nodejs/node/commit/022b53c9de)] - **lib**: refactor crypto cipher/hash/curve getters (Rich Trott) [#10682](https://github.com/nodejs/node/pull/10682)
* [[`762a303e1f`](https://github.com/nodejs/node/commit/762a303e1f)] - **test**: validate 'expected' argument to mustCall() (Nathan Friedly) [#10692](https://github.com/nodejs/node/pull/10692)
* [[`005213b43d`](https://github.com/nodejs/node/commit/005213b43d)] - **test**: fix misplaced ) in http response statuscode test (Nathan Friedly) [#10692](https://github.com/nodejs/node/pull/10692)
* [[`c61d9bade0`](https://github.com/nodejs/node/commit/c61d9bade0)] - **test**: refactor test-doctool-html.js (abouthiroppy) [#10696](https://github.com/nodejs/node/pull/10696)
* [[`a469f85653`](https://github.com/nodejs/node/commit/a469f85653)] - **https**: Use secureProtocol in Agent#getName (Andreas Lind) [#9452](https://github.com/nodejs/node/pull/9452)
* [[`74fb8a2948`](https://github.com/nodejs/node/commit/74fb8a2948)] - **deps**: upgrade libuv to 1.10.2 (cjihrig) [#10717](https://github.com/nodejs/node/pull/10717)
* [[`d3eca02576`](https://github.com/nodejs/node/commit/d3eca02576)] - **test**: move resource intensive test to sequential (Rich Trott) [#10744](https://github.com/nodejs/node/pull/10744)
* [[`d85d120593`](https://github.com/nodejs/node/commit/d85d120593)] - **src**: enable writev for pipe handles on Unix (Alexey Orlenko) [#10677](https://github.com/nodejs/node/pull/10677)
* [[`c8ed5f29ca`](https://github.com/nodejs/node/commit/c8ed5f29ca)] - **test**: add test for noAssert option in buf.read*() (larissayvette) [#10713](https://github.com/nodejs/node/pull/10713)
* [[`84a23c7205`](https://github.com/nodejs/node/commit/84a23c7205)] - **doc,test**: tls .ca option supports multi-PEM files (Sam Roberts) [#10389](https://github.com/nodejs/node/pull/10389)
* [[`733c4a813b`](https://github.com/nodejs/node/commit/733c4a813b)] - **test**: tls cert chain completion scenarios (Sam Roberts) [#10389](https://github.com/nodejs/node/pull/10389)
* [[`ea72331afc`](https://github.com/nodejs/node/commit/ea72331afc)] - **test**: check tls server verification with addCACert (Sam Roberts) [#10389](https://github.com/nodejs/node/pull/10389)
* [[`99b0c2e7a7`](https://github.com/nodejs/node/commit/99b0c2e7a7)] - **test**: move common tls connect setup into fixtures (Sam Roberts) [#10389](https://github.com/nodejs/node/pull/10389)
* [[`c001d2aab5`](https://github.com/nodejs/node/commit/c001d2aab5)] - **benchmark**: don't lint autogenerated modules (Brian White) [#10756](https://github.com/nodejs/node/pull/10756)
* [[`a2af61afc6`](https://github.com/nodejs/node/commit/a2af61afc6)] - **test**: improve tests in pummel/test-exec (Chase Starr) [#10757](https://github.com/nodejs/node/pull/10757)
* [[`dad98bfe32`](https://github.com/nodejs/node/commit/dad98bfe32)] - **readline**: refactor construct Interface (Jackson Tian) [#4740](https://github.com/nodejs/node/pull/4740)
* [[`57f6a106fb`](https://github.com/nodejs/node/commit/57f6a106fb)] - **test**: fix temp-dir option in tools/test.py (Gibson Fahnestock) [#10723](https://github.com/nodejs/node/pull/10723)
* [[`dd2d3d3f9d`](https://github.com/nodejs/node/commit/dd2d3d3f9d)] - **test**: use realpath for NODE_TEST_DIR in common.js (Gibson Fahnestock) [#10723](https://github.com/nodejs/node/pull/10723)
* [[`822bbe0bb2`](https://github.com/nodejs/node/commit/822bbe0bb2)] - **test**: fix linting for test-tls-add-ca-cert.js (Sam Roberts) [#10771](https://github.com/nodejs/node/pull/10771)
* [[`5c2ef14f21`](https://github.com/nodejs/node/commit/5c2ef14f21)] - **http**: optimize short path validation (Brian White) [#10654](https://github.com/nodejs/node/pull/10654)
* [[`6782577eef`](https://github.com/nodejs/node/commit/6782577eef)] - **test**: check error msg test-writeint.js (Irene Li) [#10755](https://github.com/nodejs/node/pull/10755)
* [[`20efbffaf8`](https://github.com/nodejs/node/commit/20efbffaf8)] - **lib**: refactor bootstrap_node.js regular expression (Rich Trott) [#10749](https://github.com/nodejs/node/pull/10749)
* [[`4424e847d5`](https://github.com/nodejs/node/commit/4424e847d5)] - **doc**: remove duplicate properties bullet in readme (Javis Sullivan) [#10741](https://github.com/nodejs/node/pull/10741)
* [[`19917ee402`](https://github.com/nodejs/node/commit/19917ee402)] - **test**: no unused args test-fs-watch-file.js (istinson) [#10758](https://github.com/nodejs/node/pull/10758)
* [[`f18b4632b9`](https://github.com/nodejs/node/commit/f18b4632b9)] - **benchmark**: use "confidence" in output of compare.R (Joyee Cheung) [#10737](https://github.com/nodejs/node/pull/10737)
* [[`57e2ec4356`](https://github.com/nodejs/node/commit/57e2ec4356)] - **test**: add http.ClientRequest defaults test (Brian White) [#10654](https://github.com/nodejs/node/pull/10654)
* [[`c5d0fd9641`](https://github.com/nodejs/node/commit/c5d0fd9641)] - **benchmark**: add ClientRequest creation benchmark (Brian White) [#10654](https://github.com/nodejs/node/pull/10654)
* [[`2f7759640e`](https://github.com/nodejs/node/commit/2f7759640e)] - **http**: misc ClientRequest cleanup (Brian White) [#10654](https://github.com/nodejs/node/pull/10654)
* [[`15c6187aa5`](https://github.com/nodejs/node/commit/15c6187aa5)] - **http**: avoid duplicate isArray() (Brian White) [#10654](https://github.com/nodejs/node/pull/10654)
* [[`dd629ba973`](https://github.com/nodejs/node/commit/dd629ba973)] - **test**: add http_incoming's matchKnownFields test (abouthiroppy) [#10811](https://github.com/nodejs/node/pull/10811)
* [[`a0e13dae1f`](https://github.com/nodejs/node/commit/a0e13dae1f)] - **test**: skip test-icu-transcode if Intl is not present (Daijiro Wachi) [#10707](https://github.com/nodejs/node/pull/10707)
* [[`92eadd3037`](https://github.com/nodejs/node/commit/92eadd3037)] - **child_process**: optimize IPC for large data (Yuya Tanaka) [#10557](https://github.com/nodejs/node/pull/10557)
* [[`1216a34590`](https://github.com/nodejs/node/commit/1216a34590)] - **benchmark**: cleanup child_process IPC benchmark (Yuya Tanaka) [#10557](https://github.com/nodejs/node/pull/10557)
* [[`338d09d25b`](https://github.com/nodejs/node/commit/338d09d25b)] - **test,repl**: add coverage for repl .clear+useGlobal (Rich Trott) [#10777](https://github.com/nodejs/node/pull/10777)
* [[`34bf31ea8a`](https://github.com/nodejs/node/commit/34bf31ea8a)] - **util**: improve readability of normalizeEncoding (Joyee Cheung) [#10439](https://github.com/nodejs/node/pull/10439)
* [[`d4b749b62f`](https://github.com/nodejs/node/commit/d4b749b62f)] - **benchmark**: improve WHATWG URL benchmarks (Joyee Cheung) [#10678](https://github.com/nodejs/node/pull/10678)
* [[`1699a8ad71`](https://github.com/nodejs/node/commit/1699a8ad71)] - **test**: improve test-fs-write-stream-throw-type (Adrian Estrada) [#10779](https://github.com/nodejs/node/pull/10779)
* [[`8628c93499`](https://github.com/nodejs/node/commit/8628c93499)] - **test,util**: remove lint workarounds (Rich Trott) [#10785](https://github.com/nodejs/node/pull/10785)
* [[`425563b59e`](https://github.com/nodejs/node/commit/425563b59e)] - **test**: delete duplicate test of noAssert in readUInt* (larissayvette) [#10791](https://github.com/nodejs/node/pull/10791)
* [[`3aa17e4e51`](https://github.com/nodejs/node/commit/3aa17e4e51)] - **(SEMVER-MINOR)** **crypto**: Use system CAs instead of using bundled ones (Adam Majer) [#8334](https://github.com/nodejs/node/pull/8334)
* [[`3ada5ae641`](https://github.com/nodejs/node/commit/3ada5ae641)] - **(SEMVER-MINOR)** **crypto**: do not use pointers to std::vector (Adam Majer) [#8334](https://github.com/nodejs/node/pull/8334)
* [[`320108c7b9`](https://github.com/nodejs/node/commit/320108c7b9)] - **test**: add dgram.Socket.prototype.sendto's test (abouthiroppy) [#10901](https://github.com/nodejs/node/pull/10901)
* [[`5614dc30dd`](https://github.com/nodejs/node/commit/5614dc30dd)] - **test**: check error message in test-fs-make-callback (legalcodes) [#10914](https://github.com/nodejs/node/pull/10914)
* [[`087516a34e`](https://github.com/nodejs/node/commit/087516a34e)] - **test**: improve test-assert (richnologies) [#10916](https://github.com/nodejs/node/pull/10916)
* [[`3160b0286d`](https://github.com/nodejs/node/commit/3160b0286d)] - **test**: increase coverage for punycode's decode (abouthiroppy) [#10940](https://github.com/nodejs/node/pull/10940)
* [[`ed0086fb46`](https://github.com/nodejs/node/commit/ed0086fb46)] - **url**: check forEach callback is a function (Timothy Gu) [#10905](https://github.com/nodejs/node/pull/10905)
* [[`106d09ab7a`](https://github.com/nodejs/node/commit/106d09ab7a)] - **test**: check fd 0,1,2 are used, not access mode (John Barboza) [#10339](https://github.com/nodejs/node/pull/10339)
* [[`4757ddcce1`](https://github.com/nodejs/node/commit/4757ddcce1)] - **(SEMVER-MINOR)** **doc**: add basic documentation for WHATWG URL API (James M Snell) [#10620](https://github.com/nodejs/node/pull/10620)
* [[`0c712b6743`](https://github.com/nodejs/node/commit/0c712b6743)] - **(SEMVER-MINOR)** **tools**: add mdn link for Iterator (James M Snell) [#10620](https://github.com/nodejs/node/pull/10620)
* [[`71f541411d`](https://github.com/nodejs/node/commit/71f541411d)] - **test**: verify shell option internals (cjihrig) [#10924](https://github.com/nodejs/node/pull/10924)
* [[`00679c3779`](https://github.com/nodejs/node/commit/00679c3779)] - **src**: remove unnecessary req_wrap_obj (Daniel Bevenius) [#10942](https://github.com/nodejs/node/pull/10942)
* [[`c8c79b937f`](https://github.com/nodejs/node/commit/c8c79b937f)] - **src**: add a missing space in node_os.cc (Alexey Orlenko) [#10931](https://github.com/nodejs/node/pull/10931)
* [[`9fcd842279`](https://github.com/nodejs/node/commit/9fcd842279)] - **buffer**: improve toJSON() performance (Brian White) [#10895](https://github.com/nodejs/node/pull/10895)
* [[`a57e2f2138`](https://github.com/nodejs/node/commit/a57e2f2138)] - **crypto**: freelist_max_len is gone in OpenSSL 1.1.0 (Adam Langley) [#10859](https://github.com/nodejs/node/pull/10859)
* [[`80c72c6d55`](https://github.com/nodejs/node/commit/80c72c6d55)] - **test**: fix flaky test-regress-GH-897 (Rich Trott) [#10903](https://github.com/nodejs/node/pull/10903)
* [[`067be658f9`](https://github.com/nodejs/node/commit/067be658f9)] - **test**: don't connect to :: (use localhost instead) (Gibson Fahnestock) [#10854](https://github.com/nodejs/node/pull/10854)
* [[`dcab88d529`](https://github.com/nodejs/node/commit/dcab88d529)] - **url**: add return value to ToUnicode/ToAscii stubs (Birunthan Mohanathas) [#10893](https://github.com/nodejs/node/pull/10893)
* [[`a024104eec`](https://github.com/nodejs/node/commit/a024104eec)] - **test**: improve test-fs-open-flags (Vinícius do Carmo)
* [[`02ccffb081`](https://github.com/nodejs/node/commit/02ccffb081)] - **test**: increase coverage of _http_outgoing (abouthiroppy) [#10820](https://github.com/nodejs/node/pull/10820)
* [[`326e967c6b`](https://github.com/nodejs/node/commit/326e967c6b)] - **url**: export URLSearchParams (Timothy Gu)
* [[`3e7a414853`](https://github.com/nodejs/node/commit/3e7a414853)] - **test**: add message verification on assert.throws (Travis Meisenheimer) [#10890](https://github.com/nodejs/node/pull/10890)
* [[`93c4820458`](https://github.com/nodejs/node/commit/93c4820458)] - ***Revert*** "**doc**: correct vcbuild options for windows testing" (Gibson Fahnestock) [#10839](https://github.com/nodejs/node/pull/10839)
* [[`b5474c8cee`](https://github.com/nodejs/node/commit/b5474c8cee)] - **test**: refactor test-repl-tab-complete (Rich Trott) [#10879](https://github.com/nodejs/node/pull/10879)
* [[`56950674d6`](https://github.com/nodejs/node/commit/56950674d6)] - **crypto,tls**: fix mutability of return values (Rich Trott) [#10795](https://github.com/nodejs/node/pull/10795)
* [[`0f0f3d3330`](https://github.com/nodejs/node/commit/0f0f3d3330)] - **build**: don't squash signal handlers with --shared (Stewart X Addison) [#10539](https://github.com/nodejs/node/pull/10539)
* [[`69674f4d3e`](https://github.com/nodejs/node/commit/69674f4d3e)] - **lib**: remove unnecessary parameter for assertCrypto() (Jackson Tian) [#10834](https://github.com/nodejs/node/pull/10834)
* [[`521767c886`](https://github.com/nodejs/node/commit/521767c886)] - **fs**: remove unused parameter for encodeRealpathResult (Jackson Tian) [#10862](https://github.com/nodejs/node/pull/10862)
* [[`21a077ae9a`](https://github.com/nodejs/node/commit/21a077ae9a)] - **test**: tests for _readableStream.awaitDrain (Mark) [#8914](https://github.com/nodejs/node/pull/8914)
* [[`f57dabe412`](https://github.com/nodejs/node/commit/f57dabe412)] - **build**: move source files from headers section (Daniel Bevenius) [#10850](https://github.com/nodejs/node/pull/10850)
* [[`ef1e77d186`](https://github.com/nodejs/node/commit/ef1e77d186)] - **vm**: improve performance of vm.runIn*() (Rich Trott) [#10816](https://github.com/nodejs/node/pull/10816)
* [[`030dd14793`](https://github.com/nodejs/node/commit/030dd14793)] - **benchmark**: add benchmark for vm.runIn*() (Rich Trott) [#10816](https://github.com/nodejs/node/pull/10816)
* [[`90a2bb53b0`](https://github.com/nodejs/node/commit/90a2bb53b0)] - **doc**: HTTP response getHeader doc fix (Faiz Halde) [#10817](https://github.com/nodejs/node/pull/10817)
* [[`165bf2804c`](https://github.com/nodejs/node/commit/165bf2804c)] - **test**: add http-common's test (abouthiroppy) [#10832](https://github.com/nodejs/node/pull/10832)
* [[`98bb65f641`](https://github.com/nodejs/node/commit/98bb65f641)] - **url**: improving URLSearchParams (Timothy Gu) [#10399](https://github.com/nodejs/node/pull/10399)
* [[`44c6b6b22a`](https://github.com/nodejs/node/commit/44c6b6b22a)] - **test**: simplify array initialization (Rich Trott) [#10860](https://github.com/nodejs/node/pull/10860)
* [[`295bd11468`](https://github.com/nodejs/node/commit/295bd11468)] - **test**: have inspector test pick an open port (Eugene Ostroukhov) [#10861](https://github.com/nodejs/node/pull/10861)
* [[`49902124a9`](https://github.com/nodejs/node/commit/49902124a9)] - **(SEMVER-MINOR)** **process**: add NODE_NO_WARNINGS environment variable (cjihrig) [#10842](https://github.com/nodejs/node/pull/10842)
* [[`71650aa8fc`](https://github.com/nodejs/node/commit/71650aa8fc)] - **test**: use common.hasIntl in tests related to ICU (Daijiro Wachi) [#10841](https://github.com/nodejs/node/pull/10841)

</details>


<details>
<summary>Gif</summary>

![giphy](https://cloud.githubusercontent.com/assets/6354455/22278122/f6d6ab32-e28e-11e6-89c0-30e0ed73a9ea.gif)
</details>

Trott and others added 30 commits January 24, 2017 18:05
PR-URL: nodejs#10419
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Refs: nodejs#9901 (comment)
1. equal => strictEqual.
2. let => const for the variable that is not reassigned.
3. fix spaces.
4. stringify erroneous raw buffer outputs.
5. fix a typo.

PR-URL: nodejs#10102
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Unlike all the other tls APIs, if any secure context configuration is
required, the caller is responsible for creating the context.

Corrects a doc regression introduced in caa7fa9.

PR-URL: nodejs#10545
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Standardise on Refs:

PR-URL: nodejs#10670
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Added a note about Visual Studio 2015 feature which should
be installed for building Node.js source code.

PR-URL: nodejs#10669
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
`killSignal` option accepts the signal name or signal number as well.

PR-URL: nodejs#10424
Reviewed-By: Julian Duque <julianduquej@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Corrected parameter for running tests on Windows. Without the corrected
parameters, Windows users encounter an error about failing to sign the
build, "Failed to sign exe", which can be discouraging to new Windows
community members.

PR-URL: nodejs#10686
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
The COLLABORATOR_GUIDE was still listing v0.10 and v0.12 as LTS when
they are EOL now.

PR-URL: nodejs#10720
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
git apply does not preserve the original commit message. These updated
instructions offer a simpler flow for backporting.

PR-URL: nodejs#10665
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Michal Zasso <targos@protonmail.com>
Changing `..can result in expected` to `..can result in unexpected`

Fixes: nodejs#10710
PR-URL: nodejs#10712
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
The guide for writing tests is missing information on how tests are
named. This adds that information.

There is also some copy-editing done on the first paragraph of the
guide.

PR-URL: nodejs#10584
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
The doc specified that writable.write() was advisory only. However,
ignoring that value might lead to memory leaks. This PR specifies that
behavior. Moreover, it adds an example on how to listen for the 'drain'
event correctly.

See: nodejs@f347dad
PR-URL: nodejs#10631
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
PR-URL: nodejs#10616
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
Add the nodejs/url github team to the table of people to /cc for
reviews on the WHATWG URL code.

PR-URL: nodejs#10652
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
The note following the http.Server example in the vm documentation
contains misleading language. This commit removes the incorrect
reference to threads.

Fixes: nodejs#10697
PR-URL: nodejs#10708
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
* Remove passive voice
* Remove unneeded modifiers
* Minor comma change

PR-URL: nodejs#10585
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Docs referred to an `issuer` property being optionally present, when it
should have referred to the `issuerCertificate` property.

PR-URL: nodejs#10389
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Fix the explanation which stated that write() would return false if
highWaterMark is exceeded to correctly state that false is returned
once highWaterMark is reached. See nodejs#9247.

PR-URL: nodejs#10582
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
PR-URL: nodejs#10828
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
* Clarify that memory is always shared and never copied.
* Fix wording that sounded like ArrayBuffer has a buffer property.

PR-URL: nodejs#10778
Ref: nodejs#10770
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: nodejs#10826
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: nodejs#10826
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This contained a duplicate link to the PR for a notable change,
presumably because that PR was composed of 2 separate commits.

PR-URL: nodejs#10827
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: nodejs#10827
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Add links to the engine classes for the zlib single-call
convenience methods.

PR-URL: nodejs#10829
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This commit clarifies variables in the Filesystem docs.
Prior, the documentation for fs.write() had an ambiguous
remark on the parameters of offset and length.

Therefore, this commit makes explicit that the length parameter
in fs.write() is used to denote the number of bytes, which is
a clearer reference for its usage.

PR-URL: nodejs#9792
Ref: nodejs#7868
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
PR-URL: nodejs#10883
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
PR-URL: nodejs#10869
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
PR-URL: nodejs#10954
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Changed authors listing from `Noah Rose` to  `Noah Rose Ledesma`.

PR-URL: nodejs#10945
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@sam-github
Copy link
Contributor

@italoacasas You are missing

@italoacasas
Copy link
Contributor Author

italoacasas commented Jan 25, 2017

@Fishrock123 @cjihrig @evanlucas can someone of you guys LGTM this PR ?

@cjihrig
Copy link
Contributor

cjihrig commented Jan 26, 2017

Did you get all of the commits @sam-github referenced? Did you run the CI against this?

Document this with the YAML meta-data.

PR-URL: nodejs#10983
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
The Hmac binding layer is not documented as part of the API, and is not
intended to be used, but it should be robust to misuse, and contains
defensive checks for misuse. This test checks that updates without init
throw (as opposed to abort or misbehave in some other way).

PR-URL: nodejs#10923
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@italoacasas
Copy link
Contributor Author

italoacasas commented Jan 26, 2017

@sam-github

@cjihrig running CI now, we are going to have two linter issues in the CI, this backport #11009 should resolve both.

@cjihrig
Copy link
Contributor

cjihrig commented Jan 26, 2017

going to have two linter issues in the CI

OK, I don't think we should land anything on the staging branch until that is resolved, but it's still good to see if the tests pass.

@italoacasas
Copy link
Contributor Author

Maybe we can land the backport in my branch instead staging ?

Trott and others added 5 commits January 26, 2017 16:23
Formatting changes for upcoming linter update.

PR-URL: nodejs#10561
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
We have been stalled on ESLint 3.8.0 for some time. Current ESLint is
3.13.0. We have been unable to upgrade because of more aggressive
reporting on some rules, including indentation.

ESLint configuration options and bugfixes are now such that we can
reasonably upgrade.

PR-URL: nodejs#10561
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
As per ESLint documentation,
http://eslint.org/docs/user-guide/configuring#configuration-file-formats
the file format .eslintrc is deprecated. This patch just renames the
files to .yaml and the structure is already in yaml format.

PR-URL: nodejs#7699

Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Rich Trott <rtrott@gmail.com>
* use common.mustCall() as appropriate
* eliminate exit handler
* var -> const/let
* provide duration for setInterval()

PR-URL: nodejs#10588
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Use common.mustCall() where appropriate, var to const/let,
assert.equal() -> assert.strictEqual(), explicit time provided to
setTimeout()

PR-URL: nodejs#10551
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
@gibfahn
Copy link
Member

gibfahn commented Jan 26, 2017

I'd like to backport the test/ stylistic fixes, otherwise I assume they'll cause a tonne of problems for people backporting things in the future. However I can't really raise a backport PR against v7.x-staging until this has landed (otherwise I'll have to fix all the merge conflicts again when it lands). What's the plan for this one? Do I raise the PR against italoacasas/node:v7.x-staging-1 or wait until this lands?

Fixes:

  • [7a0e462f9f] - test: use eslint to fix var->const/let (Gibson Fahnestock) #10685
  • [81fef918d5] - tools, test: require const/let in test (Gibson Fahnestock) #10685
  • [3d2aef3979] - test: s/assert.equal/assert.strictEqual/ (Gibson Fahnestock) #10698
  • [6509d747ee] - assert, tools: enforce strict (not)equal in eslint (Gibson Fahnestock) #10698

@MylesBorins
Copy link
Contributor

So I'd like to raise that this being the first time we have relied on a PR for updating the staging is proving to be a bit of a blocker to actually getting things in.

How do people feel about how we've been doing it in the past. More liberal landing policy. The branch is not a "source of truth" and as such can be force pushed to fix problems.

@gibfahn
Copy link
Member

gibfahn commented Jan 26, 2017

@MylesBorins

I'd always understood that vX.x-staging was basically a throwaway or work in progress branch that we shouldn't worry to much about, and that force-pushing or overwriting was a reasonable thing to do. It's basically the equivalent of a fork branch, but it's on nodejs/ so people can raise backport PRs against it.

I don't really see the need to have two different PRs, one to merge into v7.x-staging and then another one to merge into v7.x, it just adds complexity and room for error.

IMHO the person who is doing the release (be it @italoacasas or someone else) should work on v7.x-staging and raise a PR against v7.x so that backport PRs can be raised against the staging branch as it progresses. Once the PR is ready we can do checks, get approvals, run CI/citgm etc.

As I understand it the actual merging into v7.x needs to be done by a member of the release team anyway, so there's plenty of opportunity for checking/signoff.

@evanlucas
Copy link
Contributor

Yea, I prefer the way we have done it in the past where we cherry pick what we can (that is 100% working and CI passes) and then use backport PRs for stuff that needs fixing up.

@italoacasas
Copy link
Contributor Author

I want to add something.

I made the PR as a recommendation since this is my first time doing this I had more room to make mistakes and get feedback in the way I was doing the cherry-picks, etc...

@MylesBorins
Copy link
Contributor

so I think it is worth mentioning that this has been a good exercise for learning how to use the tools and land the right stuff.

@ItaloCasas I would like to encourage you to go ahead and simply land the changes onto v7.x-staging if you feel comfortable. a further audit can be done during release

@MylesBorins
Copy link
Contributor

jinx 😜

tbqh I was thinking this could be a good process to follow for the sake of auditing backport. I'm still thinking that we may want to consider backport prs, but not require sign off

@italoacasas
Copy link
Contributor Author

I have a theory in progress where this PR can be made weekly by a bot that creates the PR and a list of commits that needs backport...

@gibfahn
Copy link
Member

gibfahn commented Jan 26, 2017

@italoacasas let me know when v7.x-staging is up to date and I'll raise a backport PR for the var->const stuff.

@italoacasas
Copy link
Contributor Author

Let's wait for @cjihrig green light too since he was mentoring me on this.

@cjihrig
Copy link
Contributor

cjihrig commented Jan 27, 2017

@italoacasas go for it!

@italoacasas
Copy link
Contributor Author

@gibfahn ready.

Closing this.

@sam-github
Copy link
Contributor

@italoacasas I know this is closed, but I want to add wrt.

conflicts - [9271a41] - test: getgroups() may contain duplicate GIDs (Sam Roberts) #10389

This is because you are skipping, for reasons I don't know, many commits. There were 3 commits to that file before my PR that are present on master and not present on your branch. You need to pull every single non-semver-major commit from master, in order.

Personally, I find these lists of the commits included to not be helpful, what I want to know is what commits are not being pulled into Current from master. As I understand, every commit, if it isn't major, should make it down, or have a pretty clear justification as to why not.

@italoacasas
Copy link
Contributor Author

italoacasas commented Jan 27, 2017

@sam-github, I include the list as a request from other member.

This is the command that I run to get commits from master.

branch-diff v7.x-staging master --exclude-label=semver-major,dont-land-on-v7.x --filter-release --reverse --format=sha | xargs git cherry-pick

If for some reason I cannot use the command because breaking test or something else, I do the fallowing.

1- Make a list of all the commits

branch-diff v7.x-staging master --exclude-label=semver-major,dont-land-on-v7.x --filter-release > temp.md

2- cherry-pick each commit from that list manually running the tests after each cherry-pick, if some fails(git conflicts, test, linter) I move to the next one because that commit needs to backport.

On your specific example, one problem is a semver-major before in the History and when I ran the command, b4b37e8 had the label dont-land-on-v7.x and because of that, the commit was ignored, maybe creating conflicts with others.

@sam-github
Copy link
Contributor

right, those auto-added dont-land labels have been a problem, and should be disabled now: nodejs/github-bot#116 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.