Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http_client: ensure empty socket on error #1103

Closed
wants to merge 1 commit into from
Closed

http_client: ensure empty socket on error #1103

wants to merge 1 commit into from

Commits on Mar 9, 2015

  1. http_client: ensure empty socket on error 

    Read all pending data out of the socket on `error` event and ensure that
no `data`/`end` handlers will be invoked on `socket.destroy()`.
Otherwise following assertion happens:

    AssertionError: null == true
        at TLSSocket.socketOnData (_http_client.js:308:3)
        at TLSSocket.emit (events.js:107:17)
        at TLSSocket.Readable.read (_stream_readable.js:373:10)
        at TLSSocket.socketCloseListener (_http_client.js:229:10)
        at TLSSocket.emit (events.js:129:20)
        at TCP.close (net.js:476:12)

Fix: nodejs/node-v0.x-archive#9348
    @indutny
    indutny committed Mar 9, 2015
    Configuration menu
    Copy the full SHA
    49c0ea8 View commit details
    Browse the repository at this point in the history