Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

readline: update 6 comparisons to strict #11078

Closed
wants to merge 1 commit into from
Closed

readline: update 6 comparisons to strict #11078

wants to merge 1 commit into from

Conversation

umairishaq
Copy link
Contributor

In readline.js, update 6 comparisons to strict comparisons.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the readline Issues and PRs related to the built-in readline module. label Jan 31, 2017
@hiroppy
Copy link
Member

hiroppy commented Jan 31, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/6119/

@addaleax
Copy link
Member

Those Windows failures look weird… /cc @Fishrock123 @zkat

@jasnell jasnell changed the title readline: update 6 comparions to strict readline: update 6 comparisons to strict Jan 31, 2017
@Trott
Copy link
Member

Trott commented Jan 31, 2017

Definitely want a CI run for Windows on this. Should be able to do it once #11085 lands.

@Trott
Copy link
Member

Trott commented Jan 31, 2017

#11085 landed. CI again for Windows: https://ci.nodejs.org/job/node-test-commit-windows-fanned/6795/

@Trott
Copy link
Member

Trott commented Jan 31, 2017

Whoops, I rebased onto something that didn't have the fix in place so the build failed again.

Once more... CI (for Windows): https://ci.nodejs.org/job/node-test-commit-windows-fanned/6796/

@addaleax
Copy link
Member

addaleax commented Feb 4, 2017

Landed in b869eca – thanks for the PR!

@addaleax addaleax closed this Feb 4, 2017
addaleax pushed a commit that referenced this pull request Feb 4, 2017
@umairishaq @addaleax
readline: update 6 comparions to strict
b869eca 
PR-URL: #11078
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Feb 5, 2017
@umairishaq @italoacasas
readline: update 6 comparions to strict
edc689d 
PR-URL: nodejs#11078
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@italoacasas italoacasas mentioned this pull request Feb 5, 2017
Merged
italoacasas pushed a commit to italoacasas/node that referenced this pull request Feb 14, 2017
@umairishaq @italoacasas
readline: update 6 comparions to strict
6a45c81 
PR-URL: nodejs#11078
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
krydos pushed a commit to krydos/node that referenced this pull request Feb 25, 2017
@umairishaq @krydos
readline: update 6 comparions to strict
cdbd878 
PR-URL: nodejs#11078
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
jasnell pushed a commit that referenced this pull request Mar 7, 2017
@umairishaq @jasnell
readline: update 6 comparions to strict
d1375ad 
PR-URL: #11078
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
jasnell pushed a commit that referenced this pull request Mar 7, 2017
@umairishaq @jasnell
readline: update 6 comparions to strict
92e2767 
PR-URL: #11078
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
@umairishaq @MylesBorins
readline: update 6 comparions to strict
f7c6ad2 
PR-URL: #11078
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@MylesBorins MylesBorins mentioned this pull request Mar 9, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
@umairishaq @MylesBorins
readline: update 6 comparions to strict
a40f842 
PR-URL: #11078
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@MylesBorins MylesBorins mentioned this pull request Mar 9, 2017
Merged
@joyeecheung joyeecheung mentioned this pull request Mar 28, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

@addaleax addaleax addaleax approved these changes

@lpinca lpinca lpinca approved these changes

@targos targos targos approved these changes

Assignees
No one assigned
Labels
readline Issues and PRs related to the built-in readline module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@umairishaq @hiroppy @addaleax @Trott @jasnell @lpinca @targos @nodejs-github-bot