-
Notifications
You must be signed in to change notification settings - Fork 30.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tls_wrap: proxy handle methods in prototype #1108
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -271,6 +271,14 @@ var proxiedMethods = [ | |
'setPendingInstances' | ||
]; | ||
|
||
// Proxy HandleWrap, PipeWrap and TCPWrap methods | ||
proxiedMethods.forEach(function(name) { | ||
tls_wrap.TLSWrap.prototype[name] = function methodProxy() { | ||
if (this._parent[name]) | ||
return this._parent[name].apply(this._parent, arguments); | ||
}; | ||
}); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. do we care about the extra performance lost to creating a closure and referring to the call as There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nope, it shouldn't be critical here. |
||
|
||
TLSSocket.prototype._wrapHandle = function(handle) { | ||
var res; | ||
|
||
|
@@ -297,14 +305,6 @@ TLSSocket.prototype._wrapHandle = function(handle) { | |
} | ||
}); | ||
|
||
// Proxy HandleWrap, PipeWrap and TCPWrap methods | ||
proxiedMethods.forEach(function(name) { | ||
res[name] = function methodProxy() { | ||
if (handle[name]) | ||
return handle[name].apply(handle, arguments); | ||
}; | ||
}); | ||
|
||
return res; | ||
}; | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious, is this check really necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps we could remove it somewhere later, but I better secure ourselves with this for now.