deps: upgrade libuv to 1.11.0 #11094

cjihrig · 2017-02-01T01:08:50Z

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines

Affected core subsystem(s)

deps

santigimeno · 2017-02-01T09:02:49Z

CI: https://ci.nodejs.org/job/node-test-pull-request/6145/

santigimeno · 2017-02-01T16:10:32Z

The previous CI was bogus. New CI: https://ci.nodejs.org/job/node-test-pull-request/6147/

jasnell · 2017-02-01T16:39:09Z

@cjihrig ... would it be possible to include a short bullet point list of the key updates/fixes in this?

cjihrig · 2017-02-02T15:52:05Z

Notable changes:

zos: use gyp OS label "os390" on z/OS (John Barboza) - This was the reason for the semver-minor bump, as it adds support for a new platform, z/OS.
Revert "darwin: use clock_gettime in macOS 10.12" (Chris Araman) - This fixes a runtime link error on macOS 10.11 or earlier when libuv is compiled using the macOS 10.12 header files.

Full Changelog:

Now working on version 1.10.3 (cjihrig)
win: added fcntl.h to uv-win.h (Michele Caini)
unix: move function call out of assert (jBarz)
fs: cleanup uv__fs_scandir (Santiago Gimeno)
fs: fix crash in uv_fs_scandir_next (muflub)
win,signal: fix potential deadlock (Bartosz Sosnowski)
unix: use async-signal safe functions between fork and exec (jBarz)
sunos: fix SUNOS_NO_IFADDRS build (Ben Noordhuis)
zos: make platform functional (John Barboza)
doc: add repitition qualifier to version regexs (Daniel Bevenius)
zos: use gyp OS label "os390" on z/OS (John Barboza)
aix: enable uv_get/set_process_title (Howard Hellyer)
zos: use built-in proctitle implementation (John Barboza)
Revert "darwin: use clock_gettime in macOS 10.12" (Chris Araman)
win,test: don't write uninitialized buffer to tty (Bert Belder)
win: define ERROR_ELEVATION_REQUIRED for MinGW (Richard Lau)
aix: re-enable fs watch facility (Gireesh Punathil)

cjihrig · 2017-02-05T15:30:58Z

CI again: https://ci.nodejs.org/job/node-test-pull-request/6222/

EDIT: Another CI run: https://ci.nodejs.org/job/node-test-pull-request/6238/
EDIT: Again with the CI: https://ci.nodejs.org/job/node-test-pull-request/6260/

jasnell · 2017-02-06T01:07:20Z

OSX build bot is failing to run on CI

mhdawson · 2017-02-06T23:19:55Z

The posted results seems to be suspect. There is a failure on AIX even though the posted results seem to say its green.

I know that there was a change related to fswatch by @gireeshpunathil in libuv recently. @gireeshpunathil can you figure out what's going on here:https://ci.nodejs.org/job/node-test-commit-aix/3640/nodes=aix61-ppc64/console

gireeshpunathil · 2017-02-07T11:15:50Z

@mhdawson:

not ok 406 parallel/test-fs-watch-encoding

is bound to fail, as it involves directory watching, which is not supported in AIX. libuv/libuv#1156 is in, and we have #10085 waiting on it. This PR takes out the test exclusion from parallel.status file, and skips the test at source level. I think the green status is because of the current clause in parallel.status for this test (pass the test, but report the error)
Request reviewers to review the above PR and do the needful. thanks.

cjihrig · 2017-02-07T16:42:36Z

So we're at a point where that test on AIX is the only failure. It sounds like that is expected, so are we good to land this?

cc: @mhdawson @gireeshpunathil

jasnell

largely rubber stamp LGTM

mhdawson

Sounds like we are ok provided we land both this PR and #10085 at the same time. LGTM provided we do that.

thefourtheye

Rubber Stamp LGTM, given that CI is almost green.

cjihrig · 2017-02-09T18:15:16Z

Landed in 8514269. Thanks.

Fixes: #10165 Fixes: #9856 Fixes: #10607 Fixes: #11104 PR-URL: #11094 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

On AIX, watch feature depends on AHAFS based Event infrastructure. While in principle the watch use case is same across platforms, there are subtle differences in the way AIX deals with this, with few behavioral changes (external). This commit addresses an assertion failure on folder watch, enabling the AIX code for watch feature which was masked under a macro, open up relevant test cases, skip tests which comes under the AIX limitation, and make the document changes as appropriate. Refs: #11094 Refs: #5085 PR-URL: #10085 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>

Fixes: #10165 Fixes: #9856 Fixes: #10607 Fixes: #11104 PR-URL: #11094 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

On AIX, watch feature depends on AHAFS based Event infrastructure. While in principle the watch use case is same across platforms, there are subtle differences in the way AIX deals with this, with few behavioral changes (external). This commit addresses an assertion failure on folder watch, enabling the AIX code for watch feature which was masked under a macro, open up relevant test cases, skip tests which comes under the AIX limitation, and make the document changes as appropriate. Refs: #11094 Refs: #5085 PR-URL: #10085 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>

Fixes: nodejs#10165 Fixes: nodejs#9856 Fixes: nodejs#10607 Fixes: nodejs#11104 PR-URL: nodejs#11094 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

On AIX, watch feature depends on AHAFS based Event infrastructure. While in principle the watch use case is same across platforms, there are subtle differences in the way AIX deals with this, with few behavioral changes (external). This commit addresses an assertion failure on folder watch, enabling the AIX code for watch feature which was masked under a macro, open up relevant test cases, skip tests which comes under the AIX limitation, and make the document changes as appropriate. Refs: nodejs#11094 Refs: nodejs#5085 PR-URL: nodejs#10085 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>

Notable changes: * deps: * update V8 to 5.5 (Michaël Zasso) [#11029](#11029) * upgrade libuv to 1.11.0 (cjihrig) [#11094](#11094) * add node-inspect 1.10.2 (Jan Krems) [#10187](#10187) * lib: build `node inspect` into `node` (Anna Henningsen) [#10187](#10187) * crypto: Remove expired certs from CNNIC whitelist (Shigeki Ohtsu) [#9469](#9469) * inspector: add --inspect-brk (Josh Gavant) [#11149](#11149) * fs: allow WHATWG URL and file: URLs as paths (James M Snell) [#10739](#10739) * src: support UTF-8 in compiled-in JS source files (Ben Noordhuis) [#11129](#11129) * url: extend url.format to support WHATWG URL (James M Snell) [#10857](#10857) PR-URL: #11185

Notable changes: * deps: * update V8 to 5.5 (Michaël Zasso) [nodejs#11029](nodejs#11029) * upgrade libuv to 1.11.0 (cjihrig) [nodejs#11094](nodejs#11094) * add node-inspect 1.10.4 (Jan Krems) [nodejs#10187](nodejs#10187) * upgrade zlib to 1.2.11 (Sam Roberts) [nodejs#10980](nodejs#10980) * lib: build `node inspect` into `node` (Anna Henningsen) [nodejs#10187](nodejs#10187) * crypto: Remove expired certs from CNNIC whitelist (Shigeki Ohtsu) [nodejs#9469](nodejs#9469) * inspector: add --inspect-brk (Josh Gavant) [nodejs#11149](nodejs#11149) * fs: allow WHATWG URL objects as paths (James M Snell) [nodejs#10739](nodejs#10739) * src: support UTF-8 in compiled-in JS source files (Ben Noordhuis) [nodejs#11129](nodejs#11129) * url: extend url.format to support WHATWG URL (James M Snell) [nodejs#10857](nodejs#10857) PR-URL: nodejs#11185

Fixes: nodejs#10165 Fixes: nodejs#9856 Fixes: nodejs#10607 Fixes: nodejs#11104 PR-URL: nodejs#11094 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

On AIX, watch feature depends on AHAFS based Event infrastructure. While in principle the watch use case is same across platforms, there are subtle differences in the way AIX deals with this, with few behavioral changes (external). This commit addresses an assertion failure on folder watch, enabling the AIX code for watch feature which was masked under a macro, open up relevant test cases, skip tests which comes under the AIX limitation, and make the document changes as appropriate. Refs: nodejs#11094 Refs: nodejs#5085 PR-URL: nodejs#10085 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>

Notable changes: * deps: * update V8 to 5.5 (Michaël Zasso) [#11029](nodejs/node#11029) * upgrade libuv to 1.11.0 (cjihrig) [#11094](nodejs/node#11094) * add node-inspect 1.10.4 (Jan Krems) [#10187](nodejs/node#10187) * upgrade zlib to 1.2.11 (Sam Roberts) [#10980](nodejs/node#10980) * lib: build `node inspect` into `node` (Anna Henningsen) [#10187](nodejs/node#10187) * crypto: Remove expired certs from CNNIC whitelist (Shigeki Ohtsu) [#9469](nodejs/node#9469) * inspector: add --inspect-brk (Josh Gavant) [#11149](nodejs/node#11149) * fs: allow WHATWG URL objects as paths (James M Snell) [#10739](nodejs/node#10739) * src: support UTF-8 in compiled-in JS source files (Ben Noordhuis) [#11129](nodejs/node#11129) * url: extend url.format to support WHATWG URL (James M Snell) [#10857](nodejs/node#10857) PR-URL: nodejs/node#11185 Signed-off-by: Ilkka Myller <ilkka.myller@nodefield.com>

jasnell · 2017-03-07T18:59:23Z

@nodejs/lts ... should we pull this into v6 or v4?

MylesBorins · 2017-04-17T16:51:08Z

I think we should consider landing this in a future minor

On AIX, watch feature depends on AHAFS based Event infrastructure. While in principle the watch use case is same across platforms, there are subtle differences in the way AIX deals with this, with few behavioral changes (external). This commit addresses an assertion failure on folder watch, enabling the AIX code for watch feature which was masked under a macro, open up relevant test cases, skip tests which comes under the AIX limitation, and make the document changes as appropriate. Refs: #11094 Refs: #5085 PR-URL: #10085 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>

gibfahn · 2017-05-17T16:58:12Z

@nodejs/lts (and anyone else) thoughts on backporting this to v6.11.0? It'd need a backport PR, and I missed it in the last review. We're currently upgrading from 1.9.0 to 1.10.3 (in v6.11.0-proposal). The tests currently fail on the rc because this hasn't landed yet.

@nodejs/lts we can try out our asynchronous voting process with this issue, so please +1 or -1 here.

gibfahn · 2017-05-17T19:48:43Z

+1 to landing this in v6.11.0 from me

sam-github · 2017-05-17T19:54:53Z

+1

mhdawson · 2017-05-17T21:42:57Z

Since this has backed in Current for 3 months seems reasonable to me +1

Fixes: #10165 Fixes: #9856 Fixes: #10607 Fixes: #11104 PR-URL: #11094 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

On AIX, watch feature depends on AHAFS based Event infrastructure. While in principle the watch use case is same across platforms, there are subtle differences in the way AIX deals with this, with few behavioral changes (external). This commit addresses an assertion failure on folder watch, enabling the AIX code for watch feature which was masked under a macro, open up relevant test cases, skip tests which comes under the AIX limitation, and make the document changes as appropriate. Refs: #11094 Refs: #5085 PR-URL: #10085 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>

Fixes: #10165 Fixes: #9856 Fixes: #10607 Fixes: #11104 PR-URL: #11094 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

On AIX, watch feature depends on AHAFS based Event infrastructure. While in principle the watch use case is same across platforms, there are subtle differences in the way AIX deals with this, with few behavioral changes (external). This commit addresses an assertion failure on folder watch, enabling the AIX code for watch feature which was masked under a macro, open up relevant test cases, skip tests which comes under the AIX limitation, and make the document changes as appropriate. Refs: #11094 Refs: #5085 PR-URL: #10085 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>

This LTS release comes with 126 commits. This includes 40 which are test related, 32 which are doc related, 12 which are build / tool related and 4 commits which are updates to dependencies. Notable Changes: * build: - support for building mips64el (nanxiongchao) #10991 * cluster: - disconnect() now returns a reference to the disconnected worker. (Sean Villars) #10019 * crypto: - ability to select cert store at runtime (Adam Majer) #8334 - Use system CAs instead of using bundled ones (Adam Majer) #8334 - The `Decipher` methods `setAuthTag()` and `setAAD` now return `this`. (Kirill Fomichev) #9398 - adding support for OPENSSL_CONF again (Sam Roberts) #11006 - make LazyTransform compabile with Streams1 (Matteo Collina) #12380 * deps: - upgrade libuv to 1.11.0 (cjihrig) #11094 - upgrade libuv to 1.10.2 (cjihrig) #10717 - upgrade libuv to 1.10.1 (cjihrig) #9647 - upgrade libuv to 1.10.0 (cjihrig) #9267 * dns: - Implemented `{ttl: true}` for `resolve4()` and `resolve6()` (Ben Noordhuis) #9296 * process: - add NODE_NO_WARNINGS environment variable (cjihrig) #10842 * readline: - add option to stop duplicates in history (Danny Nemer) #2982 * src: - support "--" after "-e" as end-of-options (John Barboza) #10651 * tls: - new tls.TLSSocket() supports sec ctx options (Sam Roberts) #11005 - Allow obvious key/passphrase combinations. (Sam Roberts) #10294 PR-URL: #13059

Fixes: nodejs/node#10165 Fixes: nodejs/node#9856 Fixes: nodejs/node#10607 Fixes: nodejs/node#11104 PR-URL: nodejs/node#11094 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

On AIX, watch feature depends on AHAFS based Event infrastructure. While in principle the watch use case is same across platforms, there are subtle differences in the way AIX deals with this, with few behavioral changes (external). This commit addresses an assertion failure on folder watch, enabling the AIX code for watch feature which was masked under a macro, open up relevant test cases, skip tests which comes under the AIX limitation, and make the document changes as appropriate. Refs: nodejs/node#11094 Refs: nodejs/node#5085 PR-URL: nodejs/node#10085 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>

This LTS release comes with 126 commits. This includes 40 which are test related, 32 which are doc related, 12 which are build / tool related and 4 commits which are updates to dependencies. Notable Changes: * build: - support for building mips64el (nanxiongchao) nodejs/node#10991 * cluster: - disconnect() now returns a reference to the disconnected worker. (Sean Villars) nodejs/node#10019 * crypto: - ability to select cert store at runtime (Adam Majer) nodejs/node#8334 - Use system CAs instead of using bundled ones (Adam Majer) nodejs/node#8334 - The `Decipher` methods `setAuthTag()` and `setAAD` now return `this`. (Kirill Fomichev) nodejs/node#9398 - adding support for OPENSSL_CONF again (Sam Roberts) nodejs/node#11006 - make LazyTransform compabile with Streams1 (Matteo Collina) nodejs/node#12380 * deps: - upgrade libuv to 1.11.0 (cjihrig) nodejs/node#11094 - upgrade libuv to 1.10.2 (cjihrig) nodejs/node#10717 - upgrade libuv to 1.10.1 (cjihrig) nodejs/node#9647 - upgrade libuv to 1.10.0 (cjihrig) nodejs/node#9267 * dns: - Implemented `{ttl: true}` for `resolve4()` and `resolve6()` (Ben Noordhuis) nodejs/node#9296 * process: - add NODE_NO_WARNINGS environment variable (cjihrig) nodejs/node#10842 * readline: - add option to stop duplicates in history (Danny Nemer) nodejs/node#2982 * src: - support "--" after "-e" as end-of-options (John Barboza) nodejs/node#10651 * tls: - new tls.TLSSocket() supports sec ctx options (Sam Roberts) nodejs/node#11005 - Allow obvious key/passphrase combinations. (Sam Roberts) nodejs/node#10294 PR-URL: nodejs/node#13059

deps: upgrade libuv to 1.11.0

e269996

nodejs-github-bot added the libuv Issues and PRs related to the libuv dependency or the uv binding. label Feb 1, 2017

santigimeno approved these changes Feb 1, 2017

View reviewed changes

joyeecheung mentioned this pull request Feb 1, 2017

7.5.0 clock_gettime runtime failure built with macOS 10.11 and Xcode 8.x #11104

Closed

bricss mentioned this pull request Feb 6, 2017

Proposal - 7.6.0 (Current) #11185

Merged

jasnell approved these changes Feb 7, 2017

View reviewed changes

mhdawson approved these changes Feb 7, 2017

View reviewed changes

thefourtheye approved these changes Feb 8, 2017

View reviewed changes

cjihrig closed this Feb 9, 2017

cjihrig deleted the libuv branch February 9, 2017 18:15

hhellyer mentioned this pull request Feb 16, 2017

test: Run test-setproctitle where setting the process title is supported by libuv #11416

Closed

3 tasks

gireeshpunathil mentioned this pull request Mar 8, 2017

fs: re-enable watch facility in AIX #10085

Closed

3 tasks

MylesBorins added the backport-requested-v6.x label Apr 17, 2017

This was referenced May 17, 2017

AIX: fs-watch backport issues #13070

Closed

v6.11.0 proposal #13059

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

deps: upgrade libuv to 1.11.0 #11094

deps: upgrade libuv to 1.11.0 #11094

cjihrig commented Feb 1, 2017

santigimeno commented Feb 1, 2017

santigimeno commented Feb 1, 2017

jasnell commented Feb 1, 2017

cjihrig commented Feb 2, 2017

cjihrig commented Feb 5, 2017 •

edited

Loading

jasnell commented Feb 6, 2017

mhdawson commented Feb 6, 2017

gireeshpunathil commented Feb 7, 2017 •

edited by thefourtheye

Loading

cjihrig commented Feb 7, 2017

jasnell left a comment

mhdawson left a comment

thefourtheye left a comment

cjihrig commented Feb 9, 2017

jasnell commented Mar 7, 2017

MylesBorins commented Apr 17, 2017

gibfahn commented May 17, 2017

gibfahn commented May 17, 2017

sam-github commented May 17, 2017

mhdawson commented May 17, 2017

deps: upgrade libuv to 1.11.0 #11094

deps: upgrade libuv to 1.11.0 #11094

Conversation

cjihrig commented Feb 1, 2017

Checklist

Affected core subsystem(s)

santigimeno commented Feb 1, 2017

santigimeno commented Feb 1, 2017

jasnell commented Feb 1, 2017

cjihrig commented Feb 2, 2017

cjihrig commented Feb 5, 2017 • edited Loading

jasnell commented Feb 6, 2017

mhdawson commented Feb 6, 2017

gireeshpunathil commented Feb 7, 2017 • edited by thefourtheye Loading

cjihrig commented Feb 7, 2017

jasnell left a comment

Choose a reason for hiding this comment

mhdawson left a comment

Choose a reason for hiding this comment

thefourtheye left a comment

Choose a reason for hiding this comment

cjihrig commented Feb 9, 2017

jasnell commented Mar 7, 2017

MylesBorins commented Apr 17, 2017

gibfahn commented May 17, 2017

gibfahn commented May 17, 2017

sam-github commented May 17, 2017

mhdawson commented May 17, 2017

cjihrig commented Feb 5, 2017 •

edited

Loading

gireeshpunathil commented Feb 7, 2017 •

edited by thefourtheye

Loading