build: notify about the redundancy of "nosign" #11119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vcbuild doesn't sign by default since 92ed1ab, but there might be people who haven't noticed the change. This adds a message informing them that "nosign" is no longer necessary.
nodejs-github-bot
added
the
build
cjihrig
approved these changes
Feb 2, 2017
jasnell
approved these changes
Feb 2, 2017
thefourtheye
approved these changes
Feb 2, 2017
|
@seishun This is not landing in |
|
@italoacasas |
|
Thanks. Adding |
krydos
pushed a commit
to krydos/node
that referenced
this pull request
Feb 25, 2017
vcbuild doesn't sign by default since 92ed1ab, but there might be people who haven't noticed the change. This adds a message informing them that "nosign" is no longer necessary. PR-URL: nodejs#11119 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vcbuild doesn't sign by default since 92ed1ab, but there might be people who haven't noticed the change. This adds a message informing them that "nosign" is no longer necessary.
Checklist
Affected core subsystem(s)
build