Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert broken commits #11155

Closed
wants to merge 2 commits into from
Closed

Revert broken commits #11155

wants to merge 2 commits into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Feb 3, 2017 •
edited
Loading

It appears I somehow inadvertently was looking at the wrong CI results when evaluating this one for landing. Looks like it broke CI. We should do a quick revert.

Reverts: #11096
Reverts: #10739

/cc @mhdawson

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Feb 3, 2017
@jasnell
Copy link
Member Author

jasnell commented Feb 3, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/6207/

mhdawson
mhdawson approved these changes Feb 3, 2017
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jasnell
Copy link
Member Author

jasnell commented Feb 4, 2017

It looks like the File URL commit is failing also. Will revert that one too

@jasnell jasnell mentioned this pull request Feb 4, 2017
Closed
4 tasks
@jasnell jasnell changed the title Revert "test: refactor test-fs-error-messages.js" Revert broken commits Feb 4, 2017
@jasnell
Copy link
Member Author

jasnell commented Feb 4, 2017

CI looking good. will land as soon as it completes

jasnell added a commit that referenced this pull request Feb 4, 2017
@jasnell
Revert "test: refactor test-fs-error-messages.js"
9562bf4 
This reverts commit 907ce8d.

PR-URL: #11155
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
jasnell added a commit that referenced this pull request Feb 4, 2017
@jasnell
Revert "fs: allow WHATWG URL and file: URLs as paths"
5e52a9a 
This reverts commit 79400bf.

PR-URL: #11155
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
@jasnell
Copy link
Member Author

jasnell commented Feb 4, 2017

The file URL commit appears to be flaky on windows, does not always fail. I'll keep investigating.

Landed in 9562bf4...5e52a9a

@jasnell jasnell closed this Feb 4, 2017
@mscdex mscdex added the fs Issues and PRs related to the fs subsystem / file system. label Feb 4, 2017
krydos pushed a commit to krydos/node that referenced this pull request Feb 25, 2017
@jasnell @krydos
Revert "test: refactor test-fs-error-messages.js"
26210b3 
This reverts commit 907ce8d.

PR-URL: nodejs#11155
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
krydos pushed a commit to krydos/node that referenced this pull request Feb 25, 2017
@jasnell @krydos
Revert "fs: allow WHATWG URL and file: URLs as paths"
6855065 
This reverts commit 79400bf.

PR-URL: nodejs#11155
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
@jasnell jasnell mentioned this pull request Apr 4, 2017
Closed
@gibfahn gibfahn mentioned this pull request Jun 15, 2017
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhdawson mhdawson mhdawson approved these changes

@TimothyGu TimothyGu TimothyGu approved these changes

Assignees
No one assigned
Labels
fs Issues and PRs related to the fs subsystem / file system. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jasnell @TimothyGu @mhdawson @mscdex @evanlucas @gibfahn @nodejs-github-bot