-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: typographical fixes in COLLABORATOR_GUIDE.md #11163
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a typo and add a missing line break.
mscdex
added
the
meta
Issues and PRs related to the general management of the project.
label
Feb 4, 2017
thefourtheye
approved these changes
Feb 4, 2017
seishun
approved these changes
Feb 4, 2017
joyeecheung
approved these changes
Feb 4, 2017
joyeecheung
approved these changes
Feb 4, 2017
I feel fairly comfortable calling this a “trivial change” ;) Landed in 0101d77, thanks for the quick reviews. |
addaleax
added a commit
that referenced
this pull request
Feb 4, 2017
Fix a typo and add a missing line break. PR-URL: #11163 Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Nikolai Vavilov <vvnicholas@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Feb 5, 2017
Fix a typo and add a missing line break. PR-URL: nodejs#11163 Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Nikolai Vavilov <vvnicholas@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Feb 14, 2017
Fix a typo and add a missing line break. PR-URL: nodejs#11163 Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Nikolai Vavilov <vvnicholas@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
krydos
pushed a commit
to krydos/node
that referenced
this pull request
Feb 25, 2017
Fix a typo and add a missing line break. PR-URL: nodejs#11163 Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Nikolai Vavilov <vvnicholas@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
jasnell
pushed a commit
that referenced
this pull request
Mar 7, 2017
Fix a typo and add a missing line break. PR-URL: #11163 Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Nikolai Vavilov <vvnicholas@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
jasnell
pushed a commit
that referenced
this pull request
Mar 7, 2017
Fix a typo and add a missing line break. PR-URL: #11163 Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Nikolai Vavilov <vvnicholas@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 9, 2017
Fix a typo and add a missing line break. PR-URL: #11163 Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Nikolai Vavilov <vvnicholas@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Mar 9, 2017
Fix a typo and add a missing line break. PR-URL: #11163 Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Nikolai Vavilov <vvnicholas@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a typo and add a missing line break.
Checklist