child_process: increase default maxBuffer to 1024*1024 bytes #11196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
child_process
seppevs
changed the title
sam-github
reviewed
Feb 11, 2017
sam-github
added
the
semver-minor
|
@cjihrig @trevnorris ... PTAL |
|
There are a few other places in the documentation that need to be updated. I don't really have an opinion on whether this needs to be done or not, but the changes LGTM. |
|
the commit message will need to conform to standards, and could you include information in the referenced issue in the git commit message body? also, it should be possible to detect when the process is attempting to write more than |
|
@trevnorris I will change the commit message. |
|
Ping on this. |
seppevs
force-pushed
the
child_process_maxBuffer_default_too_small
branch
from
0947cf0
to
9d9af5a
Compare
Increase the default maxBuffer for child_process.exec from 200 * 1024 bytes to 1024 KB so child processes don't get terminated too soon. This is a fix for nodejs#9829
seppevs
force-pushed
the
child_process_maxBuffer_default_too_small
branch
from
9d9af5a
to
fefd78a
Compare
|
Closing due to inactivity. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
child_process: increase default maxBuffer to 1024*1024
Increase the default
maxBufferforchild_process.execfrom 200 * 1024 bytes to 1024 KB.This is a fix for #9829
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
child_process