Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: make tools/update-authors.sh cross-platform #1121

Merged
merged 1 commit into from
Mar 11, 2015

Conversation

bnoordhuis
Copy link
Member

And by cross-platform I mean Linux and OS X. The awk script is not
compatible with BSD awk, that's why this commit changes it to perl.

Update the .mailmap to remove some duplicates and regenerate the
AUTHORS file.

Fixes: #1120

R=@rvagg

@@ -723,5 +722,11 @@ Ryan Scheel <Ryan.havvy@gmail.com>
Benjamin Gruenbaum <inglor@gmail.com>
Pavel Medvedev <pmedvedev@gmail.com>
Russell Dempsey <sgtpooki@gmail.com>
&! (bitandbang) <tieliaco@gmail.com>
h7lin <i@h7lin.com>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't find real names for these two. :-/

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ping @bnb, got a name you want listed in AUTHORS?

@rvagg
Copy link
Member

rvagg commented Mar 11, 2015

sad, but close enough to the original, LGTM

And by cross-platform I mean Linux and OS X.  The awk script is not
compatible with BSD awk, that's why this commit changes it to perl.

Update the .mailmap to remove some duplicates and regenerate the
AUTHORS file.

Fixes: nodejs#1120
PR-URL: nodejs#1121
Reviewed-By: Rod Vagg <rod@vagg.org>
@bnoordhuis bnoordhuis closed this Mar 11, 2015
@bnoordhuis bnoordhuis deleted the fix-update-authors branch March 11, 2015 12:26
@bnoordhuis bnoordhuis merged commit d33a647 into nodejs:v1.x Mar 11, 2015
@rvagg rvagg mentioned this pull request Mar 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants