Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: remove dependency on node-weak #11239

Merged
merged 3 commits into from
Feb 11, 2017
Merged

test: remove dependency on node-weak #11239

merged 3 commits into from
Feb 11, 2017

Commits on Feb 11, 2017

  1. test: don't call process.exit() in gc tests 

    Rewrite the tests in test/gc so that they no longer call process.exit().
Instead they exit gracefully now.

PR-URL: nodejs#11239
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    @bnoordhuis
    bnoordhuis committed Feb 11, 2017
    Configuration menu
    Copy the full SHA
    da52fcd View commit details
    Browse the repository at this point in the history

  2. test: remove dependency on node-weak 

    Replace node-weak with a small hand-rolled add-on.  We can now drop
node-weak and nan, reducing the size of the source tree by about 750 kB
and the size of the tarball by about 150-300 kB.

PR-URL: nodejs#11239
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    @bnoordhuis
    bnoordhuis committed Feb 11, 2017
    Configuration menu
    Copy the full SHA
    bae093a View commit details
    Browse the repository at this point in the history

  3. test: remove nan + weak 

    Since the previous commit obsoleted them, remove them.

PR-URL: nodejs#11239
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    @bnoordhuis
    bnoordhuis committed Feb 11, 2017
    Configuration menu
    Copy the full SHA
    75019df View commit details
    Browse the repository at this point in the history