Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dgram: remove this aliases #11243

Merged
merged 1 commit into from
Feb 10, 2017
Merged

dgram: remove this aliases #11243

merged 1 commit into from
Feb 10, 2017

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Feb 8, 2017

This commit removes self = this style assignments from dgram.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

dgram

@nodejs-github-bot nodejs-github-bot added the dgram Issues and PRs related to the dgram subsystem / UDP. label Feb 8, 2017
@cjihrig
Copy link
Contributor Author

cjihrig commented Feb 9, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/6319/

@cjihrig
dgram: remove this aliases
b594b3b 
This commit removes self = this style assignments from dgram.

PR-URL: nodejs#11243
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@cjihrig cjihrig merged commit b594b3b into nodejs:master Feb 10, 2017
@cjihrig cjihrig deleted the no-self branch February 10, 2017 17:41
@vsemozhetbyt vsemozhetbyt mentioned this pull request Feb 10, 2017
Closed
2 tasks
italoacasas pushed a commit that referenced this pull request Feb 13, 2017
@cjihrig @italoacasas
dgram: remove this aliases
3abd86b 
This commit removes self = this style assignments from dgram.

PR-URL: #11243
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@italoacasas italoacasas mentioned this pull request Feb 13, 2017
Merged
italoacasas pushed a commit to italoacasas/node that referenced this pull request Feb 14, 2017
@cjihrig @italoacasas
dgram: remove this aliases
d9ed965 
This commit removes self = this style assignments from dgram.

PR-URL: nodejs#11243
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
krydos pushed a commit to krydos/node that referenced this pull request Feb 25, 2017
@cjihrig @krydos
dgram: remove this aliases
bc69c2e 
This commit removes self = this style assignments from dgram.

PR-URL: nodejs#11243
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell pushed a commit that referenced this pull request Mar 8, 2017
@cjihrig @jasnell
dgram: remove this aliases
ae333d7 
This commit removes self = this style assignments from dgram.

PR-URL: #11243
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell
Copy link
Member

jasnell commented Mar 8, 2017

Landed on v6. Needs a backport if it should land on v4

MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
@cjihrig @MylesBorins
dgram: remove this aliases
c7257e7 
This commit removes self = this style assignments from dgram.

PR-URL: #11243
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Mar 9, 2017
Merged
@joyeecheung joyeecheung mentioned this pull request Mar 28, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@targos targos targos approved these changes

Assignees
No one assigned
Labels
dgram Issues and PRs related to the dgram subsystem / UDP.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cjihrig @jasnell @targos @nodejs-github-bot