Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add coverage for string array dgram send() #11247

Merged
merged 1 commit into from
Feb 10, 2017
Merged

test: add coverage for string array dgram send() #11247

merged 1 commit into from
Feb 10, 2017

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Feb 8, 2017

This commit adds code coverage for dgram's Socket#send() where the data is an array of strings.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Feb 8, 2017
@mscdex mscdex added the dgram Issues and PRs related to the dgram subsystem / UDP. label Feb 8, 2017
jasnell
jasnell reviewed Feb 9, 2017
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I'm curious: do we / should we test arrays of other data types also?

@cjihrig
Copy link
Contributor Author

cjihrig commented Feb 9, 2017

do we / should we test arrays of other data types also?

Yea, that code is already covered.

@cjihrig
Copy link
Contributor Author

cjihrig commented Feb 9, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/6320/

mhdawson
mhdawson approved these changes Feb 9, 2017
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cjihrig
test: add coverage for string array dgram send()
df14956 
This commit adds code coverage for dgram's Socket#send() where
the data is an array of strings.

PR-URL: nodejs#11247
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@cjihrig cjihrig merged commit df14956 into nodejs:master Feb 10, 2017
@cjihrig cjihrig deleted the string-array branch February 10, 2017 20:39
italoacasas pushed a commit that referenced this pull request Feb 13, 2017
@cjihrig @italoacasas
test: add coverage for string array dgram send()
c21e030 
This commit adds code coverage for dgram's Socket#send() where
the data is an array of strings.

PR-URL: #11247
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@italoacasas italoacasas mentioned this pull request Feb 13, 2017
Merged
italoacasas pushed a commit to italoacasas/node that referenced this pull request Feb 14, 2017
@cjihrig @italoacasas
test: add coverage for string array dgram send()
e1beb9f 
This commit adds code coverage for dgram's Socket#send() where
the data is an array of strings.

PR-URL: nodejs#11247
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
krydos pushed a commit to krydos/node that referenced this pull request Feb 25, 2017
@cjihrig @krydos
test: add coverage for string array dgram send()
e38e47b 
This commit adds code coverage for dgram's Socket#send() where
the data is an array of strings.

PR-URL: nodejs#11247
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
jasnell pushed a commit that referenced this pull request Mar 7, 2017
@cjihrig @jasnell
test: add coverage for string array dgram send()
9c368b4 
This commit adds code coverage for dgram's Socket#send() where
the data is an array of strings.

PR-URL: #11247
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
@cjihrig @MylesBorins
test: add coverage for string array dgram send()
baec432 
This commit adds code coverage for dgram's Socket#send() where
the data is an array of strings.

PR-URL: #11247
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@MylesBorins MylesBorins mentioned this pull request Mar 9, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhdawson mhdawson mhdawson approved these changes

@hiroppy hiroppy hiroppy approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
dgram Issues and PRs related to the dgram subsystem / UDP. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@cjihrig @jasnell @hiroppy @mhdawson @mscdex @nodejs-github-bot