dns: gate setServers to avoid async cares conflicts #1132
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use an EE with some state data to gate async resolution operations in c-ares so that setServers() can run independently. Likely a temporary fix for nodejs#894 with a better solution being to fix c-ares to do this without barfing.
rvagg
force-pushed
the
dns-setserver-async-gate
branch
from
481846e to
ee5056f
Compare
| @@ -278,7 +313,31 @@ exports.getServers = function() { | |||
| }; | |||
|
|
|||
|
|
|||
| exports.setServers = function(servers) { | |||
| exports.setServers = function setServers(servers) { | |||
There was a problem hiding this comment.
this is no longer guaranteed to throw synchronously if there is a problem setting the servers list; perhaps this is a breaking change that makes this PR unworkable?
There was a problem hiding this comment.
Throwing asynchronously should be considered a bug (or at least very undesirable) IMO.
There was a problem hiding this comment.
try { setServers() } would still catch it in this case, right?
There was a problem hiding this comment.
in the common case, probably, but not guaranteed
|
I'm deciding this isn't such a great idea because of the changed error semantics of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use an EE with some state data to gate async resolution operations in c-ares so that setServers() can run independently.
Likely a temporary fix for #894 with a better solution being to fix c-ares to do this without barfing.
I have no perf data on this, would appreciate insight from others.
Frankly I'm just sick of seeing this item in "Known issues" with each release, crashing is not really acceptable.
Thoughts anyone?