-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: fix crypto-binary-default bad crypto check #1141
test: fix crypto-binary-default bad crypto check #1141
Conversation
Ah, nice catch. Thanks for fixing this. I'd give you LGTM but you'll have to wait for next week :-) Did you look for other tests that did similar stuff? Otherwise I can give it a go. |
@jbergstroem haha. I did a check for TLS related ones like this one and I couldn't find any, but that doesn't mean there aren't others. I wasn't stalking your commit btw, I just happened across it while doing something else. |
I'm planning to run through the test suite for other reasons shortly. I'll have one eye open for this. |
Now that you're a collaborator, does this LGTY? @jbergstroem |
Looking closer at it - it doesn't look like |
Ah, looks like its predecessor, I'll push, removing it altogether. |
This commit fixes a small bug introduced in 671fbd5 that caused the test to not be run. crypto was properly checked, but since tls was not imported, a TypeError would be thrown in the `try {} catch {}` block and falsely reported as no crypto. This is now fixed.
996dc9b
to
59c304f
Compare
Updated. PTAL @jbergstroem |
LGTM |
This commit fixes a small bug introduced in 671fbd5 that caused the test to not be run. crypto was properly checked, but since tls was not imported, a TypeError would be thrown in the `try {} catch {}` block and falsely reported as no crypto. This is now fixed. PR-URL: #1141 Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Thanks, merged in |
This commit fixes a small bug introduced in
671fbd5
that caused the test to not be run.
crypto
was properlychecked, but since
tls
was not imported, aTypeError
would be thrown in the
try {} catch {}
block andfalsely reported as no crypto.
This is now fixed.
cc @jbergstroem