Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

console: fixup console.dir() error handling #11443

Closed
wants to merge 1 commit into from
Closed

console: fixup console.dir() error handling #11443

wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

Apply the console: do not emit error events changes properly to console.dir().

This was overlooked in f18e08d (#9744).

Ref: f18e08d#commitcomment-20934407

/cc @Fishrock123

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

console

@addaleax
console: fixup console.dir() error handling
b13d561 
Apply the `console: do not emit error events` changes properly
to `console.dir()`.

This was overlooked in f18e08d
(nodejs#9744).

Ref: nodejs@f18e08d#commitcomment-20934407
@addaleax addaleax added console Issues and PRs related to the console subsystem. dont-land-on-v4.x labels Feb 17, 2017
@nodejs-github-bot nodejs-github-bot added the console Issues and PRs related to the console subsystem. label Feb 17, 2017
@addaleax
Copy link
Member Author

CI: https://ci.nodejs.org/job/node-test-commit/7982/

@addaleax
Copy link
Member Author

Landed in c969047

@addaleax addaleax closed this Feb 21, 2017
@addaleax addaleax deleted the console-no-errors2-fixup branch February 21, 2017 15:53
addaleax added a commit that referenced this pull request Feb 21, 2017
@addaleax
console: fixup console.dir() error handling
c969047 
Apply the `console: do not emit error events` changes properly
to `console.dir()`.

This was overlooked in f18e08d
(#9744).

Ref: f18e08d#commitcomment-20934407
PR-URL: #11443
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell jasnell mentioned this pull request Apr 4, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
console Issues and PRs related to the console subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@addaleax @jasnell @nodejs-github-bot