Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Fix flaky test-vm-timeout-rethrow #11530

Closed
wants to merge 3 commits into from
Closed

test: Fix flaky test-vm-timeout-rethrow #11530

wants to merge 3 commits into from

Commits on Feb 24, 2017

  1. test: Fix flaky test-vm-timeout-rethrow 

    The intention of test case is to make sure that `timeout` property is honored
and the code in context terminates and throws correct exception. However in
test case, the code inside context would complete before `timeout` for windows
and would sometimes fail. Updated the code so it guarantee to not complete
execution until timeout is triggered.

Fixes: nodejs#11261
    @kunalspathak
    kunalspathak committed Feb 24, 2017
    Configuration menu
    Copy the full SHA
    247d487 View commit details
    Browse the repository at this point in the history

  2. test: Removed unnecessary function

    @kunalspathak
    kunalspathak committed Feb 24, 2017
    Configuration menu
    Copy the full SHA
    b0907c0 View commit details
    Browse the repository at this point in the history

  3. test: More refactoring

    @kunalspathak
    kunalspathak committed Feb 24, 2017
    Configuration menu
    Copy the full SHA
    f1a5b63 View commit details
    Browse the repository at this point in the history