Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add missing entry in v6 changelog table #11534

Closed
wants to merge 1 commit into from
Closed

doc: add missing entry in v6 changelog table #11534

wants to merge 1 commit into from

Conversation

lpinca
Copy link
Member

@lpinca lpinca commented Feb 24, 2017

This adds an anchor for v6.10.0 in the LTS column.

Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

@lpinca
doc: add missing entry in v6 changelog table
2611ca4 
This adds an anchor for v6.10.0 in the LTS column.
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Feb 24, 2017
@MylesBorins
Copy link
Contributor

doh

jasnell
jasnell approved these changes Feb 24, 2017
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't need to wait the 48 hours to land

mhdawson
mhdawson approved these changes Feb 24, 2017
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jasnell pushed a commit that referenced this pull request Feb 25, 2017
@lpinca @jasnell
doc: add missing entry in v6 changelog table
289e532 
This adds an anchor for v6.10.0 in the LTS column.

PR-URL: #11534
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@jasnell
Copy link
Member

jasnell commented Feb 25, 2017

landed in 289e532

@jasnell jasnell closed this Feb 25, 2017
@lpinca lpinca deleted the add/missing-entry branch February 25, 2017 06:18
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
@lpinca @MylesBorins
doc: add missing entry in v6 changelog table
2324676 
This adds an anchor for v6.10.0 in the LTS column.

PR-URL: #11534
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
@lpinca @MylesBorins
doc: add missing entry in v6 changelog table
10413ca 
This adds an anchor for v6.10.0 in the LTS column.

PR-URL: #11534
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@MylesBorins MylesBorins mentioned this pull request Mar 9, 2017
Merged
@jasnell jasnell mentioned this pull request Apr 4, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@MylesBorins MylesBorins MylesBorins approved these changes

@evanlucas evanlucas evanlucas approved these changes

@cjihrig cjihrig cjihrig approved these changes

@mhdawson mhdawson mhdawson approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@lpinca @MylesBorins @jasnell @evanlucas @cjihrig @mhdawson @italoacasas @nodejs-github-bot