Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: make the heading consistent #11569

Closed
wants to merge 1 commit into from

Conversation

thefourtheye
Copy link
Contributor

All the other headings are in level 3. This patch fixes the offending
heading to use level 3.

Checklist
  • commit message follows commit guidelines
Affected core subsystem(s)

doc


cc @jasnell @ChALkeR

Ref: https://github.com/nodejs/node/pull/11355/files#r103103460

All the other headings are in level 3. This patch fixes the offending
heading to use level 3.
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Feb 26, 2017
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't need to wait the 48 hours to land

@thefourtheye
Copy link
Contributor Author

Landed in ed3ecd0

@thefourtheye thefourtheye deleted the doc-fix-heading branch February 27, 2017 12:28
thefourtheye added a commit that referenced this pull request Feb 27, 2017
All the other headings are in level 3. This patch fixes the offending
heading to use level 3.

PR-URL: #11569

Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@italoacasas italoacasas added the semver-major PRs that contain breaking changes and should be released in the next major version. label Feb 28, 2017
@jasnell jasnell mentioned this pull request Apr 4, 2017
@thefourtheye
Copy link
Contributor Author

This is not a major change.

@thefourtheye thefourtheye removed the semver-major PRs that contain breaking changes and should be released in the next major version. label Apr 5, 2017
italoacasas pushed a commit to italoacasas/node that referenced this pull request Apr 10, 2017
All the other headings are in level 3. This patch fixes the offending
heading to use level 3.

PR-URL: nodejs#11569

Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@italoacasas italoacasas mentioned this pull request Apr 10, 2017
2 tasks
@MylesBorins
Copy link
Contributor

This does not land cleanly in LTS. Please feel free to manually backport. Please also feel free to replace do-not-land if it is being backported

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants