-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: make the heading consistent #11569
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All the other headings are in level 3. This patch fixes the offending heading to use level 3.
cjihrig
approved these changes
Feb 27, 2017
jasnell
approved these changes
Feb 27, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This shouldn't need to wait the 48 hours to land
Landed in ed3ecd0 |
thefourtheye
added a commit
that referenced
this pull request
Feb 27, 2017
All the other headings are in level 3. This patch fixes the offending heading to use level 3. PR-URL: #11569 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
italoacasas
added
the
semver-major
PRs that contain breaking changes and should be released in the next major version.
label
Feb 28, 2017
This is not a major change. |
thefourtheye
removed
the
semver-major
PRs that contain breaking changes and should be released in the next major version.
label
Apr 5, 2017
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Apr 10, 2017
All the other headings are in level 3. This patch fixes the offending heading to use level 3. PR-URL: nodejs#11569 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This does not land cleanly in LTS. Please feel free to manually backport. Please also feel free to replace do-not-land if it is being backported |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the other headings are in level 3. This patch fixes the offending
heading to use level 3.
Checklist
Affected core subsystem(s)
doc
cc @jasnell @ChALkeR
Ref: https://github.com/nodejs/node/pull/11355/files#r103103460