Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add regex to assert in test_cyclic_link_protection #11622

Closed
wants to merge 8 commits into from
Closed

test: add regex to assert in test_cyclic_link_protection #11622

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e9e90c8
test: add regex to match error message
clarenced Feb 19, 2017
123510f
test: lint error correction
clarenced Feb 22, 2017
0a3902b
test: add regex to match error message
clarenced Feb 19, 2017
c76fbf1
test: lint error correction
clarenced Feb 22, 2017
214b8de
test: test assertions improvements
clarenced Feb 25, 2017
d7d0ce7
test: update the call of the function common.expectsError
clarenced Feb 28, 2017
36d5204
test: tests assertions improvments
clarenced Feb 28, 2017
a330181
test: path entry fixed using path.join()
clarenced Mar 3, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions test/parallel/test-fs-realpath.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,21 +191,25 @@ function test_cyclic_link_protection(callback) {
common.skip('symlink test (no privs)');
return runNextTest();
}
const entry = common.tmpDir + '/cycles/realpath-3a';
const entry = path.join(common.tmpDir, '/cycles/realpath-3a');
[
[entry, '../cycles/realpath-3b'],
[common.tmpDir + '/cycles/realpath-3b', '../cycles/realpath-3c'],
[common.tmpDir + '/cycles/realpath-3c', '../cycles/realpath-3a']
[path.join(common.tmpDir, '/cycles/realpath-3b'), '../cycles/realpath-3c'],
[path.join(common.tmpDir, '/cycles/realpath-3c'), '../cycles/realpath-3a']
].forEach(function(t) {
try { fs.unlinkSync(t[0]); } catch (e) {}
fs.symlinkSync(t[1], t[0], 'dir');
unlink.push(t[0]);
});
assert.throws(function() { fs.realpathSync(entry); });
asynctest(fs.realpath, [entry], callback, function(err, result) {
assert.ok(err && true);
return true;
});
assert.throws(() => {
fs.realpathSync(entry);
}, common.expectsError({ code: 'ELOOP', type: Error }));
asynctest(
fs.realpath, [entry], callback, common.mustCall(function(err, result) {
assert.strictEqual(err.path, entry);
assert.strictEqual(result, undefined);
return true;
}));
}

function test_cyclic_link_overprotection(callback) {
Expand Down