Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net: refactor overloaded argument handling #11667

Closed
wants to merge 5 commits into from
Closed

net: refactor overloaded argument handling #11667

wants to merge 5 commits into from

Commits on Mar 5, 2017

  1. net: make normalizeArgs return tuples 

    Make normalizeArgs return either [options, null] or [options, cb]
(the second element won't be undefined anymore) and avoid OOB read
    @joyeecheung
    joyeecheung committed Mar 5, 2017
    Configuration menu
    Copy the full SHA
    ba793bc View commit details
    Browse the repository at this point in the history

  2. net: replace apply with call 

    Use Socket.prototype.connect.call instead of .apply when the number
of arguments is certain(returned by normalizeArgs).
    @joyeecheung
    joyeecheung committed Mar 5, 2017
    Configuration menu
    Copy the full SHA
    a8d0c24 View commit details
    Browse the repository at this point in the history

  3. net: rename some args[i] for readability

    @joyeecheung
    joyeecheung committed Mar 5, 2017
    Configuration menu
    Copy the full SHA
    1ea81d5 View commit details
    Browse the repository at this point in the history

  4. net: refactor Server.prototype.listen 

    * Separate backlogFromArgs and options.backlog
* Comment the overloading process
    @joyeecheung
    joyeecheung committed Mar 5, 2017
    Configuration menu
    Copy the full SHA
    ce3fc05 View commit details
    Browse the repository at this point in the history

  5. net: refactor server.listen flow control

    @joyeecheung
    joyeecheung committed Mar 5, 2017
    Configuration menu
    Copy the full SHA
    bcd4ff7 View commit details
    Browse the repository at this point in the history