net: fix net.Server.prototype.listen error message #11693
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mscdex
added
semver-major
lpinca
reviewed
Mar 5, 2017
| assert.throws(() => listen(65536, common.mustNotCall()), portError); | ||
| assert.throws(() => listen(1 / 0, common.mustNotCall()), portError); | ||
| assert.throws(() => listen(-1 / 0, common.mustNotCall()), portError); | ||
| assert.throws(() => listen(-1 / 0, common.mustNotCall()), portError); |
jasnell
approved these changes
Mar 6, 2017
Previously the error messages are mostly `[object Object]` after the options get normalized. Use util.inspect to make it more useful.
Refactor the listen option test, add precise error message validation and a few more test cases.
joyeecheung
force-pushed
the
fix-net-listen-error
branch
from
8ae4ffc
to
dbcba0d
Compare
|
Got a conflict after #11667 landed. Rebased. New CI: https://ci.nodejs.org/job/node-test-pull-request/6742/ |
fhinkel
approved these changes
Mar 9, 2017
|
Thanks. Squashed and landed in 4775942 |
fhinkel
pushed a commit
that referenced
this pull request
Mar 9, 2017
Previously the error messages are mostly `[object Object]` after the options get normalized. Use util.inspect to make it more useful. Refactor the listen option test, add precise error message validation and a few more test cases. PR-URL: #11693 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
jungx098
pushed a commit
to jungx098/node
that referenced
this pull request
Mar 21, 2017
Previously the error messages are mostly `[object Object]` after the options get normalized. Use util.inspect to make it more useful. Refactor the listen option test, add precise error message validation and a few more test cases. PR-URL: nodejs#11693 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit uses
util.inspectto make the error messages thrown byserver.listenmore useful.Before:
After:
The second commit refactors the listen option test, adding precise error message validation and a few more test cases.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
net, test