Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: delay child exit in AIX for pseudo-tty tests #11715

Closed
wants to merge 1 commit into from
Closed

test: delay child exit in AIX for pseudo-tty tests #11715

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions test/pseudo-tty/no_dropped_stdio.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// https://github.com/nodejs/node/issues/6456#issuecomment-219320599
// https://gist.github.com/isaacs/1495b91ec66b21d30b10572d72ad2cdd
'use strict';
require('../common');
const common = require('../common');

// 1000 bytes wrapped at 50 columns
// \n turns into a double-byte character
Expand All @@ -11,5 +11,9 @@ let out = ('o'.repeat(48) + '\n').repeat(20);
// This results in 1025 bytes, just enough to overflow the 1kb OS X TTY buffer.
out += 'o'.repeat(24) + 'O';

process.stdout.write(out);
process.exit(0);
// In AIX, the child exits even before the python parent
// can setup the readloop. Provide a reasonable delay.
setTimeout(function() {
process.stdout.write(out);
process.exit(0);
}, common.isAix ? 200 : 0);
10 changes: 7 additions & 3 deletions test/pseudo-tty/no_interleaved_stdio.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// https://github.com/nodejs/node/issues/6456#issuecomment-219320599
// https://gist.github.com/isaacs/1495b91ec66b21d30b10572d72ad2cdd
'use strict';
require('../common');
const common = require('../common');

// 1000 bytes wrapped at 50 columns
// \n turns into a double-byte character
Expand All @@ -13,5 +13,9 @@ out += 'o'.repeat(24) + 'O';

const err = '__This is some stderr__';

process.stdout.write(out);
process.stderr.write(err);
// In AIX, the child exits even before the python parent
// can setup the readloop. Provide a reasonable delay.
setTimeout(function() {
process.stdout.write(out);
process.stderr.write(err);
}, common.isAix ? 200 : 0);
3 changes: 0 additions & 3 deletions test/pseudo-tty/pseudo-tty.status
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
prefix pseudo-tty

[$system==aix]
# test issue only, covered under https://github.com/nodejs/node/issues/7973
no_dropped_stdio : SKIP
no_interleaved_stdio : SKIP
# being investigated under https://github.com/nodejs/node/issues/9728
test-tty-wrap : FAIL, PASS
6 changes: 5 additions & 1 deletion test/pseudo-tty/test-stderr-stdout-handle-sigwinch.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,4 +27,8 @@ process.stdout._refreshSize = wrap(originalRefreshSizeStdout,
process.stdout,
'calling stdout._refreshSize');

process.emit('SIGWINCH');
// In AIX, the child exits even before the python parent
// can setup the readloop. Provide a reasonable delay.
setTimeout(function() {
process.emit('SIGWINCH');
}, common.isAix ? 200 : 0);