Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

7.7.3 Release Proposal #11831

Merged
merged 32 commits into from
Mar 14, 2017
Merged

7.7.3 Release Proposal #11831

merged 32 commits into from
Mar 14, 2017

Conversation

italoacasas
Copy link
Contributor

@italoacasas italoacasas commented Mar 13, 2017 •
edited
Loading

2017-03-14, Version 7.7.3 (Current), @italoacasas

Not landing right now: https://gist.github.com/italoacasas/d3212151d158a8a7792e76b5e1efd38c

Notable changes

  • module: The module loading global fallback to the Node executable's directory now works correctly on Windows. (Richard Lau) #9283
  • net: Socket.prototype.connect now once again functions without a callback. (Juwan Yoo) #11762
  • url: URL.prototype.origin now properly specified an opaque return of 'null' for file:// URLs. (Brian White) #11691

CI

Commits

  • [542a3735a7] - build: add node_use_openssl check to install.py (Daniel Bevenius) #11766
  • [2fcefeeda0] - dgram: refactor dgram to module.exports (Claudio Rodriguez) #11696
  • [dd3e6adaa7] - doc: add missing changelog heading for 7.7.2 (Evan Lucas) #11823
  • [b543fd441c] - doc: update to current V8 versions (Franziska Hinkelmann) #11787
  • [6cc7b30c62] - doc: improve child_process maxBuffer text (Rich Trott) #11791
  • [188cbc6eea] - doc: package main can be directory with an index (Bradley Farias) #11581
  • [a20aa0ee48] - doc: http cleanup and missing argument types (Amelia Clarke) #11681
  • [8a1b2b4417] - doc: reduce font size on smaller screens (Gibson Fahnestock) #11695
  • [5bea8b42d9] - doc: fix occurences of "the the" (Jeroen Mandersloot) #11711
  • [517c3af21a] - doc: fix process links to console.log/error (Sam Roberts) #11718
  • [108449b6ff] - doc: add Franziska Hinkelmann to the CTC (Rod Vagg) #11488
  • [9c3cf13cbc] - doc: argument types for https methods (Amelia Clarke) #11681
  • [103458772a] - module: fix loading from global folders on Windows (Richard Lau) #9283
  • [1dff218cd1] - net: allow missing callback for Socket.connect (Juwan Yoo) #11762
  • [52f0092f54] - s390: enable march=z196 (Junliang Yan) #11730
  • [032becdc28] - src: add missing #include <unicode/ustring.h> (Steven R. Loomis) #11754
  • [1da2afcc26] - src: drop the NODE_ISOLATE_SLOT macro (Anna Henningsen) #11692
  • [734ddbe77b] - test: fix flaky test-http-set-timeout-server (Santiago Gimeno) #11790
  • [aaf8536dbc] - test: add test for loading from global folders (Richard Lau) #9283
  • [c01c7a490a] - test: add script to create 0-dns-cert.pem (Shigeki Ohtsu) #11579
  • [4477e15217] - test: add regex in test_cyclic_link_protection (Clarence Dimitri CHARLES) #11622
  • [3d55cf06b1] - test: add more WHATWG URL origin tests (Brian White) #11691
  • [a98d963082] - test: increase coverage of console (DavidCai) #11653
  • [1af0fa4b84] - test: test buffer behavior when zeroFill undefined (Rich Trott) #11706
  • [1e52ba3b3d] - test: limit lint rule disabling in message test (Rich Trott) #11724
  • [5e7baa5a72] - tools: add links to the stability index reference (Michael Cox) #11664
  • [c5874d1bd4] - url: remove invalid file protocol check (Brian White) #11691

mscdex and others added 24 commits March 13, 2017 11:18
@mscdex @italoacasas
url: remove invalid file protocol check
c5874d1 
'file' should have been 'file:' but since the WHATWG URL spec
suggests using an opaque origin (which is what was already being
used for file URLs), we'll just keep using that, making this merely
a cleanup.

PR-URL: #11691
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@michaelcox @italoacasas
tools: add links to the stability index reference
5e7baa5 
This modifies the script that generates the docs
to create a static link from each Stability Index callout bar to
the Stability Index explanations in documentation.html.

PR-URL: #11664
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
@Trott @italoacasas
test: limit lint rule disabling in message test
1e52ba3 
nexttick_throw.js has a comment that disables all ESLint rules for a
line. Change it to only disable the one ESLint rule that the line
violates.

PR-URL: #11724
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
@Trott @italoacasas
test: test buffer behavior when zeroFill undefined
1af0fa4 
When ArrayBufferAllocator has an undefined zeroFill property,
Buffer.allocUnsafe() should zero fill.

Refs: 27e84ddd4e1#commitcomment-19182129

PR-URL: #11706
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
@DavidCai1111 @italoacasas
test: increase coverage of console
a98d963 
PR-URL: #11653
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
@mscdex @italoacasas
test: add more WHATWG URL origin tests
3d55cf0 
PR-URL: #11691
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@clarenced @italoacasas
test: add regex in test_cyclic_link_protection
4477e15 
PR-URL: #11622
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@shigeki @italoacasas
test: add script to create 0-dns-cert.pem
c01c7a4 
0-dns-cert.pem  and 0-dns-key.pem were stored in `test/fixtures/key`
directory, but the cert file cannot be created with the openssl
command via Makefile.

Added a script to create it with using  `asn1.js` and
`asn1.js-rfc5280` and moved them out of key directory and put into
`test/fixtures/0-dns`.

The domains listed in the cert were also changed into example.com and
example.org to show the use for only testing.

Fixes: #10228
PR-URL: #11579
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
@richardlau @italoacasas
test: add test for loading from global folders
aaf8536 
Test executes with a copy of the node executable since $PREFIX/lib/node
is relative to the executable location.

PR-URL: #9283
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@addaleax @italoacasas
src: drop the NODE_ISOLATE_SLOT macro
1da2afc 
The `NODE_ISOLATE_SLOT` macro has been unused since c3cd453.

PR-URL: #11692
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
@srl295 @italoacasas
src: add missing #include <unicode/ustring.h>
032becd 
* We use these functions that are declared in <unicode/ustring.h>

  u_strFromUTF8()
    u_strToUTF8()

* At present, <unicode/ustring.h> is indirectly included, but this will
likely change in future ICUs. Adding this header has been the right
thing to do for many years, so it is backwards compatible.

Fixes: #11753
PR-URL: #11754
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
@italoacasas
s390: enable march=z196
52f0092 
PR-URL: #11730
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@vhain @italoacasas
net: allow missing callback for Socket.connect
1dff218 
Arguments of Socket.prototype.connect should be also normalized,
causing error when called without callback.

Changed Socket.prototype.connect's code same as net.connect and added
test.

Fixes: #11761
PR-URL: #11762
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
@richardlau @italoacasas
module: fix loading from global folders on Windows
1034587 
Code was calculating $PREFIX/lib/node relative to process.execPath, but
on Windows process.execPath is $PREFIX\node.exe whereas everywhere else
process.execPath is $PREFIX/bin/node (where $PREFIX is the root of the
installed Node.js).

PR-URL: #9283
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@ameliavoncat @italoacasas
doc: argument types for https methods
9c3cf13 
Ref: #9399
PR-URL: #11681
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@rvagg @italoacasas
doc: add Franziska Hinkelmann to the CTC
108449b 
PR-URL: #11488
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Julien Gilli <jgilli@nodejs.org>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@sam-github @italoacasas
doc: fix process links to console.log/error
517c3af 
Fixes: #11717

PR-URL: #11718
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
@JeroenMandersloot @italoacasas
doc: fix occurences of "the the"
5bea8b4 
I identified a number of files where it said "the the" in the comments
of the source code and in general documentation texts. I replaced
these occurences with a single instance of "the".

PR-URL: #11711
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
@gibfahn @italoacasas
doc: reduce font size on smaller screens
8a1b2b4 
The font size for tablet sized screens (or half a laptop screen) is
overly large, reduce it to a more readable size.

Fixes: nodejs/nodejs.org#919

PR-URL: #11695
Fixes: https://github.com/nodejs/nodejs.org#919
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
@claudiorodriguez @italoacasas
dgram: refactor dgram to module.exports
2fcefee 
Refactor dgram module to use the more efficient
module.exports = {} pattern.

PR-URL: #11696
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Ron Korving <ron@ronkorving.nl>
@silverwind @italoacasas
doc: consistent case for primitive types
612bd68 
PR-URL: #11167
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@silverwind @italoacasas
doc: linkify type[] syntax, support lowercase for primitives
97d1f5f 
PR-URL: #11167
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@silverwind @italoacasas
tools: fix lint issue in doctool
5a9e30f 
PR-URL: #11658
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@silverwind @italoacasas
doc/tools: fix more type inconsistencies
757bf48 
- fix a number of uppercase types
- lowercase 'integer'
- consistent formatting in crypto

PR-URL: #11697
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. dgram Issues and PRs related to the dgram subsystem / UDP. doc Issues and PRs related to the documentations. v7.x labels Mar 13, 2017
@italoacasas italoacasas added meta Issues and PRs related to the general management of the project. and removed build Issues and PRs related to build files or the CI. labels Mar 13, 2017
@italoacasas italoacasas removed dgram Issues and PRs related to the dgram subsystem / UDP. doc Issues and PRs related to the documentations. labels Mar 13, 2017
santigimeno and others added 7 commits March 14, 2017 10:01
@santigimeno @italoacasas
test: fix flaky test-http-set-timeout-server
734ddbe 
It can happen that the connection and server is closed before the second
reponse has been processed by server. In this case, the
`res.setTimeout()` callback will never be called causing the test to
fail. Fix this by only closing the connection and server when the 2nd
has been received.

PR-URL: #11790
Fixes: #11768
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
@ameliavoncat @italoacasas
doc: http cleanup and missing argument types
a20aa0e 
Ref: #9399
PR-URL: #11681
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@bmeck @italoacasas
doc: package main can be directory with an index
188cbc6 
This behavior dates back to 2011 but was not documented.

PR-URL: #11581
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: James Snell <jasnell@gmail.com>
@Trott @italoacasas
doc: improve child_process maxBuffer text
6cc7b30 
`maxBuffer` information in child_process.md used atypical formatting.
This uses a single consistent style for all instances of `maxBuffer`
information.

PR-URL: #11791
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@fhinkel @italoacasas
doc: update to current V8 versions
b543fd4 
Update the documentation to the correct V8 versions
in the guide *Maintaining V8 in Node.js*.

PR-URL: #11787
Reviewed-By: James M Snell <jasnell@gmail.com>
@evanlucas @italoacasas
doc: add missing changelog heading for 7.7.2
dd3e6ad 
When the release was cut, the changelog heading in CHANGELOG_V7
was accidentally omitted.

PR-URL: #11823
Fixes: #11822
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@danbev @italoacasas
build: add node_use_openssl check to install.py
542a373 
When configuring --without-ssl and then running make install
openssl headers will be copied from deps/openssl to the target
installation directory.

This commit adds a check for is node_use_openssl is set in which
case the headers are not copied.

PR-URL: #11766
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Brian White <mscdex@mscdex.net>
italoacasas added a commit to italoacasas/node that referenced this pull request Mar 14, 2017
@italoacasas
2017-03-14, Version 7.7.3 (Current)
42c0900 
Notable changes:

* module: fix loading from global folders on Windows (Richard Lau)
[nodejs#9283](nodejs#9283)
* net: allow missing callback for Socket.connect (Juwan Yoo)
[nodejs#11762](nodejs#11762)

PR-URL: nodejs#11831
@italoacasas
Copy link
Contributor Author

Any idea why readable-stream is failing in CITGM

https://ci.nodejs.org/job/citgm-smoker/nodes=ubuntu1604-64/654/testReport/

cc: @nodejs/citgm @nodejs/streams

@italoacasas
Copy link
Contributor Author

I see Error: ENOENT: no such file or directory, lstat '/home/iojs/tmp' in every error, this looks like a CITGM failure?

@mcollina
Copy link
Member

mcollina commented Mar 14, 2017 •
edited
Loading

@italoacasas we have just pushed a new release of readable-stream that includes some of the new tests that have been added to nodejs/node (those were skipped before, our tooling was relying on GitHub scraping, now it downloads the source from nodejs.org). Everything is passing on travis on v7.7.2 so either it's a problem here, or in CITGM or in our https://github.com/nodejs/readable-stream/blob/master/test/common.js.

@italoacasas
Copy link
Contributor Author

@mcollina I don't think the error is on readable-stream, the version failing is 2.2.4 not 2.2.5 and is just Ubuntu 16.04 😑... I think is something infra related. I'll keep you posted.

@mcollina
Copy link
Member

I've just published v2.2.5, that's what you should test. v2.2.4 had a bug that caused a failure with node --harmony on node v0.10 (yes, it's old).

@Fishrock123
Copy link
Contributor

Fishrock123 commented Mar 14, 2017 •
edited
Loading 

## Notable Changes
* **module**: The [module loading global fallback](https://nodejs.org/dist/latest-v6.x/docs/api/modules.html#modules_loading_from_the_global_folders) to the Node executable's directory now works correctly on Windows. (Richard Lau) [#9283](https://github.com/nodejs/node/pull/9283)
* *net**: `Socket.prototype.connect` now once again functions without a callback. (Juwan Yoo) [#11762](https://github.com/nodejs/node/pull/11762)
* **url**: `URL.prototype.origin` now properly specified an opaque return of `'null'` for `file://` URLs. (Brian White) [#11691](https://github.com/nodejs/node/pull/11691)

@italoacasas
Copy link
Contributor Author

italoacasas commented Mar 14, 2017 •
edited
Loading

The issue in CITGM with readable-stream is because CITGM is trying to download this package https://github.com/nodejs/readable-stream/archive/v2.2.5.tar.gz, but because the version doesn't have a tag in Github is failing.

cc: @mcollina

I'm signing off the CITGM failure.

@mcollina
Copy link
Member

@italoacasas that's fixed.

@italoacasas
2017-03-14, Version 7.7.3 (Current)
9c68a69 
Notable changes:

* module: The [module loading global fallback]
(https://nodejs.org/dist/latest-v6.x/docs/api/modules.html#modules_loading_from_the_global_folders)
to the Node executable's directory now works correctly on Windows.
(Richard Lau) [#9283](#9283)

* net: `Socket.prototype.connect` now once again functions without
a callback. (Juwan Yoo) [#11762](#11762)

* url: `URL.prototype.origin` now properly specified an opaque return of
`'null'` for `file://` URLs. (Brian White)
[#11691](#11691)

PR-URL: #11831
italoacasas added a commit to italoacasas/node that referenced this pull request Mar 14, 2017
@italoacasas
Working on v7.7.4
753adee 
PR-URL: nodejs#11831
@italoacasas italoacasas merged commit 9c68a69 into v7.x Mar 14, 2017
italoacasas added a commit to italoacasas/node that referenced this pull request Mar 14, 2017
@italoacasas
2017-03-14, Version 7.7.3 (Current)
bc26c62 
Notable changes:

* module: The [module loading global fallback]
(https://nodejs.org/dist/latest-v6.x/docs/api/modules.html#modules_loading_from_the_global_folders)
to the Node executable's directory now works correctly on Windows.
(Richard Lau) [nodejs#9283](nodejs#9283)

* net: `Socket.prototype.connect` now once again functions without
a callback. (Juwan Yoo) [nodejs#11762](nodejs#11762)

* url: `URL.prototype.origin` now properly specified an opaque return of
`'null'` for `file://` URLs. (Brian White)
[nodejs#11691](nodejs#11691)

PR-URL: nodejs#11831
italoacasas added a commit to italoacasas/nodejs.org that referenced this pull request Mar 14, 2017
@italoacasas
blog: add release post for v7.7.2 release
216f288 
PR-URL: nodejs/node#11831
@italoacasas italoacasas mentioned this pull request Mar 14, 2017
Merged
italoacasas added a commit to nodejs/nodejs.org that referenced this pull request Mar 14, 2017
@italoacasas
blog: add release post for v7.7.2 release (#1171)
59df688 
PR-URL: nodejs/node#11831
@gibfahn gibfahn deleted the v7.7.3-proposal branch March 15, 2017 01:01
imyller added a commit to imyller/meta-nodejs that referenced this pull request Mar 16, 2017
@imyller
2017-03-14, Version 7.7.3 (Current)
78018dc 
    Notable changes:

    * module: The [module loading global fallback]
    (https://nodejs.org/dist/latest-v6.x/docs/api/modules.html#modules_loading_from_the_global_folders)
    to the Node executable's directory now works correctly on Windows.
    (Richard Lau) [#9283](nodejs/node#9283)

    * net: `Socket.prototype.connect` now once again functions without
    a callback. (Juwan Yoo) [#11762](nodejs/node#11762)

    * url: `URL.prototype.origin` now properly specified an opaque return of
    `'null'` for `file://` URLs. (Brian White)
    [#11691](nodejs/node#11691)

    PR-URL: nodejs/node#11831

Signed-off-by: Ilkka Myller <ilkka.myller@nodefield.com>
jungx098 pushed a commit to jungx098/node that referenced this pull request Mar 21, 2017
@italoacasas @jungx098
2017-03-14, Version 7.7.3 (Current)
67320f2 
Notable changes:

* module: The [module loading global fallback]
(https://nodejs.org/dist/latest-v6.x/docs/api/modules.html#modules_loading_from_the_global_folders)
to the Node executable's directory now works correctly on Windows.
(Richard Lau) [nodejs#9283](nodejs#9283)

* net: `Socket.prototype.connect` now once again functions without
a callback. (Juwan Yoo) [nodejs#11762](nodejs#11762)

* url: `URL.prototype.origin` now properly specified an opaque return of
`'null'` for `file://` URLs. (Brian White)
[nodejs#11691](nodejs#11691)

PR-URL: nodejs#11831
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.