Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stream: Fixes missing 'unpipe' event for pipes made with {end: false} #11876

Closed

Commits on Apr 6, 2017

  1. stream: Fixes missing 'unpipe' event for pipes made with {end: false}

      Currently when the destination emits an 'error', 'finish' or 'close'
    event the pipe calls unpipe to emit 'unpipe' and trigger the clean up
    of all it's listeners.
      When the source emits an 'end' event without {end: false} it calls
    end() on the destination leading it to emit a 'close', this will again
    lead to the pipe calling unpipe. However the source emitting an 'end'
    event along side {end: false} is the only time the cleanup gets ran
    directly without unpipe being called. This fixes that so the 'unpipe'
    event does get emitted and cleanup in turn gets ran by that event.
    
    Fixes: nodejs#11837
    zaide-chris committed Apr 6, 2017
    Configuration menu
    Copy the full SHA
    850cd09 View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2017

  1. Configuration menu
    Copy the full SHA
    a773504 View commit details
    Browse the repository at this point in the history