doc: document extent of crypto Uint8Array support #11982
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
crypto
cjihrig
approved these changes
Mar 22, 2017
jasnell
approved these changes
Mar 22, 2017
lpinca
approved these changes
Mar 23, 2017
TimothyGu
reviewed
Mar 23, 2017
doc/api/crypto.md
Outdated
| [initialization vector][]. Both arguments must be `'utf8'` encoded strings or | ||
| [buffers][`Buffer`]. | ||
| [initialization vector][]. Both arguments must be `'utf8'` encoded strings, | ||
| [buffers][`Buffer`] or `Uint8Array`s. |
There was a problem hiding this comment.
@TimothyGu you mean the buffers that was already there should be uppercase? makes sense, updated
addaleax
force-pushed
the
crypto-uint8array-doc
branch
from
1d68984 to
bf026b0
Compare
addaleax
force-pushed
the
crypto-uint8array-doc
branch
from
bf026b0 to
ad775e1
Compare
jasnell
pushed a commit
that referenced
this pull request
Mar 24, 2017
PR-URL: #11982 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
|
Landed in e40ac30 |
|
This will require a manual backport to v7.x |
3 tasks
|
Should this be backported to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)